This is an implementation of the 16,8,8 ip lookup
(longest prefix matching) algorithm. The key of the
table is 32-bit IPv4 address.
Signed-off-by: Ru Jia
---
helper/Makefile.am | 2 +
helper/iplookuptable.c | 974
Signed-off-by: Ru Jia
---
helper/test/Makefile.am | 4 +-
helper/test/iplookuptable.c | 150
2 files changed, 153 insertions(+), 1 deletion(-)
create mode 100644 helper/test/iplookuptable.c
diff --git a/helper/test/Makefile.am
Updates packet marking api documentation to traffic manager user guide
Signed-off-by: Balasubramanian Manoharan
---
doc/users-guide/users-guide-tm.adoc | 73 +
1 file changed, 73 insertions(+)
diff --git
I have those changes. Please check if i have missed anything.
On 12 May 2016 at 23:32, Bala Manoharan wrote:
> Hi Nikhil,
>
> I had some comments on V1 regarding session type.
> If you agree can you please incorporate on next version.
>
> Regards,
> Bala
>
> On 12 May
Applying this patch shows whitespace errors:
bill@Ubuntu15:~/linaro/mikedoc2$ git am ~/Mail/Incoming/Mike/1
Applying: doc: process-guide: convert CONTRIBUTING to asciidoc
.git/rebase-apply/patch:129: indent with spaces.
`odp_pktio_t`
.git/rebase-apply/patch:164: new blank line at EOF.
+
On Thu, May 12, 2016 at 1:56 PM, Maxim Uvarov
wrote:
> Not used assigned, should just removed.
> https://bugs.linaro.org/show_bug.cgi?id=2221
>
> Signed-off-by: Maxim Uvarov
>
Reviewed-by: Bill Fischofer
> ---
>
From: Mike Holmes
Signed-off-by: Mike Holmes
Signed-off-by: Bill Fischofer
---
doc/images/packet_flow.svg | 532 +
1 file changed, 532 insertions(+)
create mode 100644
From: Mike Holmes
Signed-off-by: Mike Holmes
Signed-off-by: Bill Fischofer
---
doc/users-guide/Makefile.am | 1 +
doc/users-guide/users-guide.adoc | 89 +---
2 files changed,
From: Mike Holmes
Signed-off-by: Mike Holmes
Signed-off-by: Bill Fischofer
---
doc/users-guide/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/users-guide/Makefile.am
On Thu, May 12, 2016 at 3:40 AM, Yi He wrote:
> Hi, Bill and Petri
>
> After yesterday's discussion/email I realized some strict rules in ARCH:
>
>1. odp apis do not want to handle thread-to-core arrangement except
>only providing availability info, right? (may be
Compiling this on a 32-bit system I get:
CC odp_system_info.lo
odp_system_info.c: In function ‘default_huge_page_size’:
odp_system_info.c:86:19: error: format ‘%lu’ expects argument of type ‘long
unsigned int *’, but argument 3 has type ‘uint64_t * {aka long long
unsigned int *}’
On Thu, May 12, 2016 at 2:35 PM, Maxim Uvarov
wrote:
> Current validation test can produce bug:
> timer.c:250:handle_tmo():Wrong tick: expected 18446744073709551615 actual
> 149
> FAILED
> 1. timer.c:246 - CU_FAIL("Wrong status (stale) for fresh timeout")
> 2.
On Thu, May 12, 2016 at 5:13 AM, Matias Elo wrote:
> Use strong typing for odp_timer_t and odp_timeout_t. Fix
> couple exposed usage errors.
>
> Signed-off-by: Matias Elo
>
Reviewed-and-tested-by: Bill Fischofer
> ---
>
On Thu, May 12, 2016 at 7:36 AM, Matias Elo wrote:
> Using memset to initialize struct odp_packet_hdr_t contents
> to 0 has a significant overhead. Instead, initialize only
> the required members of the struct.
>
> Signed-off-by: Matias Elo
> ---
>
On Thu, May 12, 2016 at 10:46 AM, Nikhil Agarwal
wrote:
> Signed-off-by: Nikhil Agarwal
> ---
> doc/users-guide/users-guide.adoc | 83
> +++-
> 1 file changed, 65 insertions(+), 18 deletions(-)
>
> diff
Current validation test can produce bug:
timer.c:250:handle_tmo():Wrong tick: expected 18446744073709551615 actual 149
FAILED
1. timer.c:246 - CU_FAIL("Wrong status (stale) for fresh timeout")
2. timer.c:251 - CU_FAIL("odp_timeout_tick() wrong tick")
Which caused with wrong destroy
Converting to asciidoc allows a tidy page to be added to the online
documentation without cutting and pasting into wordpress.
Being Asccidoc a tiny amount of clutter is added to show code snippets
attractively when rendered that make it slightly hard to read as a raw
document.
Signed-off-by: Mike
On Thu, May 12, 2016 at 6:22 AM, Maxim Uvarov
wrote:
> Having system call inside loop couse unpredictable delay
> as the result wrong time diff calculation. Just removing
> print make hole test execution shorter on 0.1 seconds
> according to cunit stats. Also make
Not used assigned, should just removed.
https://bugs.linaro.org/show_bug.cgi?id=2221
Signed-off-by: Maxim Uvarov
---
platform/linux-generic/pktio/ipc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/platform/linux-generic/pktio/ipc.c
https://bugs.linaro.org/show_bug.cgi?id=
--- Comment #1 from Maxim Uvarov ---
http://patches.opendataplane.org/patch/6004/
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing
On Thu, May 12, 2016 at 10:50 AM, Maxim Uvarov
wrote:
> recv_packets_tmo() has if for not initialized
> pkt_seq array, while init is done in create_packets(),
> so we need just reorder that lines.
> https://bugs.linaro.org/show_bug.cgi?id=
>
> Signed-off-by: Maxim
On Thu, May 12, 2016 at 10:24 AM, Maxim Uvarov
wrote:
> bug:
> https://bugs.linaro.org/show_bug.cgi?id=2224
>
> Signed-off-by: Maxim Uvarov
>
Reviewed-by: Bill Fischofer
> ---
>
On Thu, May 12, 2016 at 10:20 AM, Maxim Uvarov
wrote:
> Fix wrong return code check due to assignment to unsigned variable.
> https://bugs.linaro.org/show_bug.cgi?id=2224
>
> Signed-off-by: Maxim Uvarov
>
Reviewed-by: Bill Fischofer
Good idea Bill, I will add to ARCH call
On 12 May 2016 at 14:02, Bala Manoharan wrote:
> Hi Nikhil,
>
> I had some comments on V1 regarding session type.
> If you agree can you please incorporate on next version.
>
> Regards,
> Bala
>
> On 12 May 2016 at 22:22, Nikhil
Hi Nikhil,
I had some comments on V1 regarding session type.
If you agree can you please incorporate on next version.
Regards,
Bala
On 12 May 2016 at 22:22, Nikhil Agarwal wrote:
> Yes I do agree with mentioning only the API names here. I did that in v2
> of this
Reviewed-by: Zoltan Kiss
On 12/05/16 17:29, Bill Fischofer wrote:
Correct typo in spelling of _LARGEFILE64_SOURCE. This also removes an
extraneous non-ascii character from the source file.
Suggested-by: Zoltan Kiss
Signed-off-by: Bill Fischofer
On Thu, May 12, 2016 at 8:24 AM, Christophe Milard <
christophe.mil...@linaro.org> wrote:
> Hi Bill,
> Just sent you a v4 containing my proposal regarding the FSMs and the text
> around it.
> I still have a few comments:
>
> First, your FSM mixed events and actions on the transition arrow. I
This looks good. I've sent a v5 that slightly reformats the images to make
them consistent, but I'm happy with the two diagrams if that looks better
to you.
And I've now just read your other comments. Let me look and see if a v6 is
needed to address them :)
On Thu, May 12, 2016 at 8:24 AM,
Signed-off-by: Ivan Khoronzhuk
Signed-off-by: Bill Fischofer
Signed-off-by: Christophe Milard
---
doc/users-guide/Makefile.am| 1 +
doc/users-guide/users-guide-timer.adoc | 107
Signed-off-by: Bill Fischofer
Signed-off-by: Christophe Milard
---
doc/images/.gitignore | 2 ++
doc/images/timeout_fsm.gv | 29 +
doc/images/timer_fsm.gv | 24
Yes I do agree with mentioning only the API names here. I did that in v2 of
this patch.
On 12 May 2016 at 22:14, Bill Fischofer wrote:
>
> On Thu, May 12, 2016 at 11:25 AM, Mike Holmes
> wrote:
>
>>
>>
>> On 11 May 2016 at 19:15, Bill
On Thu, May 12, 2016 at 11:25 AM, Mike Holmes
wrote:
>
>
> On 11 May 2016 at 19:15, Bill Fischofer wrote:
>
>> A number of grammatical corrections and suggestions for improvement.
>>
>> On Wed, May 11, 2016 at 9:45 AM, Nikhil Agarwal <
>>
Suggested-by: Zoltan Kiss
Signed-off-by: Bill Fischofer
---
doc/application-api-guide/api_guide_lines.dox | 14 ++--
doc/process-guide/bylaws-guide.adoc | 16 +++---
doc/users-guide/users-guide-tm.adoc | 32
Correct typo in spelling of _LARGEFILE64_SOURCE. This also removes an
extraneous non-ascii character from the source file.
Suggested-by: Zoltan Kiss
Signed-off-by: Bill Fischofer
---
platform/linux-generic/include/odp_posix_extensions.h | 2 +-
On 4 May 2016 at 20:38, Brian Brooks wrote:
> Reviewed-by: Brian Brooks
>
> for the series.
>
> On 05/11 18:41:44, Christophe Milard wrote:
> > Pull can be performed from the URL at the end of this cover letter
> > All patches sent to the list
Good catch. The only legit ones are the tree diagrams. I'll post a patch to
fix the rest. A lot of it seems to have come from cut and paste resulting
in "smart quotes" being carried over.
On Thu, May 12, 2016 at 10:05 AM, Zoltan Kiss
wrote:
> Hi,
>
> I've came accross a
On 05/12/16 18:47, Mike Holmes wrote:
On 11 May 2016 at 14:08, Sudeepto Roy > wrote:
HI,
I have been able to successfully install odp on my machine.
I wanted to know if you have a any kind of documentation available
recv_packets_tmo() has if for not initialized
pkt_seq array, while init is done in create_packets(),
so we need just reorder that lines.
https://bugs.linaro.org/show_bug.cgi?id=
Signed-off-by: Maxim Uvarov
---
test/validation/pktio/pktio.c | 10 +-
1 file
On 11 May 2016 at 14:08, Sudeepto Roy wrote:
> HI,
>
> I have been able to successfully install odp on my machine.
>
> I wanted to know if you have a any kind of documentation available for the
> examples directory so that i can understand the use case.
>
The examples
I already did
On 12 May 2016 at 11:36, Grant Likely wrote:
> It's Wikipedia! Go fix it! :-)
>
> g.
>
> On Thu, May 12, 2016 at 4:12 PM, Zoltan Kiss
> wrote:
> > Hi,
> >
> > The link to Wind River is broken, it should point here:
> >
> >
It's Wikipedia! Go fix it! :-)
g.
On Thu, May 12, 2016 at 4:12 PM, Zoltan Kiss wrote:
> Hi,
>
> The link to Wind River is broken, it should point here:
>
> https://en.wikipedia.org/wiki/Wind_River_Systems
>
> On 12/05/16 13:27, Raj Murali wrote:
>>
>> Dear All,
>>
>> I
https://bugs.linaro.org/show_bug.cgi?id=2227
Mike Holmes changed:
What|Removed |Added
Status|UNCONFIRMED |IN_PROGRESS
Ever
https://bugs.linaro.org/show_bug.cgi?id=2224
--- Comment #2 from Maxim Uvarov ---
http://patches.opendataplane.org/patch/6002/
http://patches.opendataplane.org/patch/6003/
--
You are receiving this mail because:
You are on the CC list for the
bug:
https://bugs.linaro.org/show_bug.cgi?id=2224
Signed-off-by: Maxim Uvarov
---
platform/linux-generic/pktio/socket_mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/platform/linux-generic/pktio/socket_mmap.c
Fix wrong return code check due to assignment to unsigned variable.
https://bugs.linaro.org/show_bug.cgi?id=2224
Signed-off-by: Maxim Uvarov
---
test/validation/pktio/pktio.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Hi,
The link to Wind River is broken, it should point here:
https://en.wikipedia.org/wiki/Wind_River_Systems
On 12/05/16 13:27, Raj Murali wrote:
Dear All,
I am happy to inform you all that, we are now on Wikipedia - at last.
https://en.wikipedia.org/wiki/Open_Data_Plane_(ODP)
Thanks to all
On 12 May 2016 at 12:54, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
> Those that add new definitions into helper/linux.h and depend on each
> other, so that the entire proposed spec is easy to see today and later on
> from git history. Since those are new calls, it
Hi,
I've came accross a lot in the doc folder, I don't know if we want to do
anything about them, but here is an easy way to find them:
git grep --color='auto' -P -n "[\x80-\xFF]"
There is only one place outside docs:
diff --git a/platform/linux-generic/include/odp_posix_extensions.h
On 05/12 13:57:52, Christophe Milard wrote:
> On 12 May 2016 at 13:33, Savolainen, Petri (Nokia - FI/Espoo) <
> petri.savolai...@nokia.com> wrote:
>
> >
> > *From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of
> > *Christophe
> > Milard
> > *Sent:* Thursday, May 12, 2016 2:14
Hi Maxim,
Yes, it is working now.
Sorry, my suggestion was wrong.
On Thu, May 12, 2016 at 6:32 PM, Maxim Uvarov
wrote:
> Hi nousi,
>
> can you please confirm that this patch solves issue:
>
> http://patches.opendataplane.org/patch/5947/
>
> Thank you,
> Maxim.
>
> On
Hi Bill,
Just sent you a v4 containing my proposal regarding the FSMs and the text
around it.
I still have a few comments:
First, your FSM mixed events and actions on the transition arrow. I could
not get graphviz to have 2 colors on the same transition (one for events,
one for actions), so I
Hi nousi,
can you please confirm that this patch solves issue:
http://patches.opendataplane.org/patch/5947/
Thank you,
Maxim.
On 05/11/16 15:24, nousi wrote:
Hi Maxim,
plese make correction in patch, check sscanf with "!= 1" instead "== 1'.
if (pos) {
*(pos - 1) = '\0';
Bill, this patch was a little bit changes since v2, please review it.
Maxim.
On 05/12/16 13:13, Matias Elo wrote:
Use strong typing for odp_timer_t and odp_timeout_t. Fix
couple exposed usage errors.
Signed-off-by: Matias Elo
---
V2:
+ Split too long string lines
https://bugs.linaro.org/show_bug.cgi?id=2031
Mike Holmes changed:
What|Removed |Added
Status|CONFIRMED |IN_PROGRESS
--
You are
https://bugs.linaro.org/show_bug.cgi?id=2082
Mike Holmes changed:
What|Removed |Added
Resolution|--- |FIXED
Ping, looks like it wasn't merged for some reason?
Any blockers?
Maxim.
On 04/28/16 10:38, HePeng wrote:
Hi,
We appreciate more comments on the patch. Thanks.
在 2016年4月27日,下午7:35,Raj Murali > 写道:
Agree with Bill.
The original
https://bugs.linaro.org/show_bug.cgi?id=2103
Mike Holmes changed:
What|Removed |Added
Status|CONFIRMED |IN_PROGRESS
https://bugs.linaro.org/show_bug.cgi?id=2211
Mike Holmes changed:
What|Removed |Added
Status|CONFIRMED |IN_PROGRESS
--
You are
https://bugs.linaro.org/show_bug.cgi?id=2102
Anders Roxell changed:
What|Removed |Added
Status|CONFIRMED |IN_PROGRESS
--
You
https://bugs.linaro.org/show_bug.cgi?id=2220
Mike Holmes changed:
What|Removed |Added
Status|CONFIRMED |IN_PROGRESS
--
You are
https://bugs.linaro.org/show_bug.cgi?id=2235
Mike Holmes changed:
What|Removed |Added
Assignee|lng-odp@lists.linaro.org
Define ipc_addr_offset member of struct odp_buffer_hdr_t
only if ipc pktio is enabled to reduce struct size.
Signed-off-by: Matias Elo
---
platform/linux-generic/include/odp_buffer_internal.h | 8 +---
platform/linux-generic/pktio/ipc.c | 14
Using memset to initialize struct odp_packet_hdr_t contents
to 0 has a significant overhead. Instead, initialize only
the required members of the struct.
Signed-off-by: Matias Elo
---
platform/linux-generic/include/odp_packet_internal.h | 8 +---
There is no way to read vlan tags in the ODP API, so don't
save them.
Signed-off-by: Matias Elo
---
platform/linux-generic/include/odp_packet_internal.h | 4
platform/linux-generic/odp_packet.c | 4
2 files changed, 8 deletions(-)
diff --git
Dear All,
I am happy to inform you all that, we are now on Wikipedia - at last.
https://en.wikipedia.org/wiki/Open_Data_Plane_(ODP)
Thanks to all for sharing links and contributing content used in the page.
Raj Murali
Director - Linaro Networking Group
Skype: rajmurali_s │ M: +91 98450 70135
On 12 May 2016 at 13:33, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
>
>
>
>
> *From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of
> *Christophe
> Milard
> *Sent:* Thursday, May 12, 2016 2:14 PM
> *To:* Savolainen, Petri (Nokia - FI/Espoo)
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Christophe
Milard
Sent: Thursday, May 12, 2016 2:14 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCHv6 05/38] helpers: linux: creating
Having system call inside loop couse unpredictable delay
as the result wrong time diff calculation. Just removing
print make hole test execution shorter on 0.1 seconds
according to cunit stats. Also make verbose errors in
places where we out of limit in cunit. This should be
very helpful to
Those that add new definitions into helper/linux.h and depend on each other, so
that the entire proposed spec is easy to see today and later on from git
history. Since those are new calls, it should be easy to introduce those in
their final form. Patches (e.g. 1 and 12) should not expose
> +int odph_odpthreads_create(odph_odpthread_t *thread_tbl,
> +const odp_cpumask_t *mask,
> +const odph_odpthread_params_t *thr_params)
> +{
> + int i;
> + int num;
> + int cpu_count;
> + int cpu;
> +
> + num =
Signed-off-by: Nikhil Agarwal
---
doc/users-guide/users-guide.adoc | 83 +++-
1 file changed, 65 insertions(+), 18 deletions(-)
diff --git a/doc/users-guide/users-guide.adoc b/doc/users-guide/users-guide.adoc
index 0221634..e8d690e
Use strong typing for odp_timer_t and odp_timeout_t. Fix
couple exposed usage errors.
Signed-off-by: Matias Elo
---
V2:
+ Split too long string lines (Maxim)
example/timer/odp_timer_test.c| 10 ++
Add missing odp_timer_pool_to_u64(), odp_timer_to_u64(), and
odp_timeout_to_u64() functions. Use the functions in timer
validation tests.
Signed-off-by: Matias Elo
---
V2:
+ Reversed patch order (Maxim)
platform/linux-generic/odp_timer.c | 15 +++
Not sure which patches you want to squash here: "helper: adding a function
to merge getopt parameters" and "parsing the complete set of options" ?
Aren't these 2 different steps? They were at least tested separately...
Or did I misunderstood?
Christophe.
On 12 May 2016 at 10:21, Savolainen,
On 12 May 2016 at 10:17, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
>
>
> > -Original Message-
> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> > Christophe Milard
> > Sent: Wednesday, May 11, 2016 7:42 PM
> > To:
Hi, Bill and Petri
After yesterday's discussion/email I realized some strict rules in ARCH:
1. odp apis do not want to handle thread-to-core arrangement except only
providing availability info, right? (may be repeated several time until I
got it :)).
2. then application needs
It would be really good to squash these patches introducing (and then modifying
the previously introduced) new helper function prototypes into a single patch.
This way it's hard to see the complete picture what functions were actually
added into helper/linux.h
-Petri
> -Original
Thanks, I'll fix this and the patch 1 right away.
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Wednesday, May 11, 2016 7:12 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH v2 2/2]
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Christophe Milard
> Sent: Wednesday, May 11, 2016 7:42 PM
> To: brian.bro...@linaro.org; mike.hol...@linaro.org; lng-
> o...@lists.linaro.org
> Subject: [lng-odp] [PATCHv6 05/38] helpers: linux:
Hi,
I am still confused with this shared FSM for the 2 distinct objects: The
red seems to be actions associated with the transitions (and the timer
expiration event is no longer shown on the transition showing the actions).
I am not sure what the distinction between the green and blue events are.
80 matches
Mail list logo