Re: [lng-odp] [PATCH 1/4] linux-generic: define cache line size in one place

On 07/18 13:54:25, Mike Holmes wrote: > Is there a performance benifit to this ? > > I would rather we have non conflicting per architecture files, we had all > the defines in one file before and it caused issues when people sent > patches that conflicted, I now have to review an x86 change even i

[lng-odp] [PATCHv2] linux-gen: scope ipc shared memory for packet pools only

Instead of placing all allocation to shared memory, place only packets pool. Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_pool.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index e

Re: [lng-odp] [PATCH 1/2] example: odp_timer_simple: decrease timer pool resolution

On 07/18 13:41:32, Mike Holmes wrote: > Is 10 milliseconds adequate for real work ? > > Should this be in some way calculated depending on the platform > capabilities where it is executes since this example will also be run on > real HW accelerated systems and for those I assume we want the bette

Re: [lng-odp] [API-NEXT PATCH 00/18] basic driver interface elements

http://patches.opendataplane.org/patch/6537/ With the driver docs patch applied I get the following warnings, maybe you can pull the doxygen into your series or depend on it ? /home/mike/git/odp/include/odp/api/spec/byteorder.h:33: warning: documentation for unknown define ODP_BIG_ENDIAN_BITFIELD

Re: [lng-odp] [PATCH 1/4] linux-generic: define cache line size in one place

Is there a performance benifit to this ? I would rather we have non conflicting per architecture files, we had all the defines in one file before and it caused issues when people sent patches that conflicted, I now have to review an x86 change even if I am on an ARM platform just incase something

Re: [lng-odp] [PATCH 1/2] example: odp_timer_simple: decrease timer pool resolution

Is 10 milliseconds adequate for real work ? Should this be in some way calculated depending on the platform capabilities where it is executes since this example will also be run on real HW accelerated systems and for those I assume we want the better resolution. On 18 July 2016 at 13:16, Brian B

Re: [lng-odp] [PATCH] linux-gen: scope ipc shared memory for packet pools only

On 18 July 2016 at 11:26, Maxim Uvarov wrote: > Instead of placing all allocation to shared memory, place > only packets pool. > > Signed-off-by: Maxim Uvarov > Reviewed-by: Mike Holmes > --- > platform/linux-generic/odp_pool.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > d

Re: [lng-odp] [PATCH] test: add termination path for l2fwd

On 18 July 2016 at 11:50, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov > Reviewed-by: Mike Holmes > --- > test/performance/odp_l2fwd.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/test/performance/odp_l2fwd.c b/test/performance/odp_l2fwd.c

[lng-odp] [PATCH 3/4] linux-generic: odp_cpu_pause() for aarch64

Signed-off-by: Brian Brooks --- platform/linux-generic/include/odp/api/cpu.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/include/odp/api/cpu.h b/platform/linux-generic/include/odp/api/cpu.h index 3330326..b9405b7 100644 --- a/platform/linux-gener

[lng-odp] [PATCH 2/2] timer: add missing atomic decrement

Signed-off-by: Brian Brooks --- platform/linux-generic/odp_timer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/linux-generic/odp_timer.c b/platform/linux-generic/odp_timer.c index becea9d..f47c291 100644 --- a/platform/linux-generic/odp_timer.c +++ b/platform/linux-generic/odp

[lng-odp] [PATCH 1/2] example: odp_timer_simple: decrease timer pool resolution

POSIX timer overruns are experienced on Linux generic platforms when resolution is less than one millisecond. Decrease resolution from 10 microseconds to 10 milliseconds so this example program works as intended on generic Linux platforms. Signed-off-by: Brian Brooks --- example/timer/odp_timer_

[lng-odp] [PATCH 4/4] linux-generic: remove cpu_arch.h

Signed-off-by: Brian Brooks --- platform/linux-generic/Makefile.am | 8 +--- platform/linux-generic/arch/arm/odp/api/cpu_arch.h | 1 - platform/linux-generic/arch/default/odp/api/cpu_arch.h | 18 -- platform/linux-generic/arch/mips64/odp/api/cpu_arch.

[lng-odp] [PATCH 1/4] linux-generic: define cache line size in one place

Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp/api/cpu_arch.h | 10 -- platform/linux-generic/arch/mips64/odp/api/cpu_arch.h | 12 platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 10 -- platform/linux-generic/arch/x86/odp/api/cpu_arc

[lng-odp] [PATCH 2/4] linux-generic: define odp_cpu_pause() in one place

Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp/api/cpu_arch.h | 4 platform/linux-generic/arch/mips64/odp/api/cpu_arch.h | 8 platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 4 platform/linux-generic/arch/x86/odp/api/cpu_arch.h | 9 ---

[lng-odp] [API-NEXT PATCH 10/18] drv: fixing Makefile for compiler.h

Signed-off-by: Christophe Milard --- platform/Makefile.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/Makefile.inc b/platform/Makefile.inc index fbf65aa..dd3b376 100644 --- a/platform/Makefile.inc +++ b/platform/Makefile.inc @@ -64,5 +64,6 @@ odpapispecinclude_HEADERS = \ odpdr

[lng-odp] [API-NEXT PATCH 01/18] linux-generic: Makefile: reintroducing lost change for drv

The change done for commit id 1fcd2369be88a6f4f7a7a93e9bb315d0e65ab128 in the Makefile, and delated after is reintroduced here. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/platform/linux-generic/Makefile.am b/p

[lng-odp] [API-NEXT PATCH 18/18] linux-generic: adding spinlock.h

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918.) Signed-off-by: Christophe Milard --- include/odp_drv.h | 1 + platform/linux-generic/Makefile.am | 5 ++- platform/linux-generic/drv_spinlock.c | 39

[lng-odp] [API-NEXT PATCH 17/18] drv: adding spinlock.h

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918.) Signed-off-by: Christophe Milard --- include/odp/drv/spec/spinlock.h | 86 + platform/Makefile.inc | 1 + 2 files changed, 87 insertions(+) create mode 100644 includ

[lng-odp] [API-NEXT PATCH 15/18] linux-generic: drv: adding atomic

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918.) Signed-off-by: Christophe Milard --- include/odp_drv.h | 1 + platform/linux-generic/Makefile.am | 3 + platform/linux-generic/drv_atomic.c| 26 ++

[lng-odp] [API-NEXT PATCH 16/18] linux-generic: cosmetic changes on spinlock

To please check-patch before the copy to the drv interface. Signed-off-by: Christophe Milard --- include/odp/api/spec/spinlock.h | 7 --- platform/linux-generic/odp_spinlock.c | 4 2 files changed, 11 deletions(-) diff --git a/include/odp/api/spec/spinlock.h b/include/odp/api/spe

[lng-odp] [API-NEXT PATCH 14/18] drv: adding atomic.h

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918.) Signed-off-by: Christophe Milard --- include/odp/drv/spec/atomic.h | 634 ++ platform/Makefile.inc | 1 + 2 files changed, 635 insertions(+) create mode 100644 in

[lng-odp] [API-NEXT PATCH 12/18] linux-generic: drv: adding align.h

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918.) Signed-off-by: Christophe Milard --- include/odp_drv.h | 1 + platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp/drv/align.h | 60 ++

[lng-odp] [API-NEXT PATCH 13/18] linux-generic: cosmetic changes on atomic

To please check-patch before the copy to the drv interface. Signed-off-by: Christophe Milard --- include/odp/api/spec/atomic.h | 1 - platform/linux-generic/include/odp/api/plat/atomic_types.h | 1 - 2 files changed, 2 deletions(-) diff --git a/include/odp/api/spec/

[lng-odp] [API-NEXT PATCH 11/18] drv: adding align.h

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918) Signed-off-by: Christophe Milard --- include/odp/drv/spec/align.h | 78 platform/Makefile.inc| 1 + 2 files changed, 79 insertions(+) create mode 100644 include/od

[lng-odp] [API-NEXT PATCH 09/18] drv: fixing Makefile for std_types

Signed-off-by: Christophe Milard --- platform/Makefile.inc | 1 + platform/linux-generic/Makefile.am | 1 + 2 files changed, 2 insertions(+) diff --git a/platform/Makefile.inc b/platform/Makefile.inc index 21f2922..fbf65aa 100644 --- a/platform/Makefile.inc +++ b/platform/Makefile.i

[lng-odp] [API-NEXT PATCH 08/18] linux-generic: drv: adding sync.h

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918) Signed-off-by: Christophe Milard --- include/odp_drv.h | 1 + platform/linux-generic/Makefile.am| 3 +- platform/linux-generic/include/odp/drv/sync.h | 49 +

[lng-odp] [API-NEXT PATCH 07/18] drv: adding sync.h

copied from API side, hash 77a27212b563299959fb2a609b86bb9117a8f918. Signed-off-by: Christophe Milard --- include/odp/drv/spec/sync.h | 91 + platform/Makefile.inc | 3 +- 2 files changed, 93 insertions(+), 1 deletion(-) create mode 100644 incl

[lng-odp] [API-NEXT PATCH 06/18] linux-generic: cosmetic changes on sync files

To please check-patch before the copy to the drv interface. Signed-off-by: Christophe Milard --- include/odp/api/spec/sync.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/odp/api/spec/sync.h b/include/odp/api/spec/sync.h index b48e0ab..6f87db5 100644 --- a/include/odp/api/spec/sync.

[lng-odp] [API-NEXT PATCH 04/18] drv: adding byteorder.h

copied from api interface (77a27212b563299959fb2a609b86bb9117a8f918). Signed-off-by: Christophe Milard --- include/odp/drv/spec/byteorder.h | 178 +++ platform/Makefile.inc| 4 + 2 files changed, 182 insertions(+) create mode 100644 include/odp/

[lng-odp] [API-NEXT PATCH 05/18] linux-generic: drv: adding byteorder.h

duplicated from the API side (hash: 77a27212b563299959fb2a609b86bb9117a8f918) Signed-off-by: Christophe Milard --- include/odp_drv.h | 1 + platform/linux-generic/Makefile.am | 5 + platform/linux-generic/include/odp/drv/byteorder.h | 146

[lng-odp] [API-NEXT PATCH 02/18] linux-generic: moving the visibility files one step up

include/odp/api/visibility_begin.h and include/odp/api/visibility_end.h move one step up (in include/odp/) and can therefore be used on other interfaces. Signed-off-by: Christophe Milard --- include/odp/api/spec/align.h| 4 ++-- include/odp/api/spec/atomic.h

[lng-odp] [API-NEXT PATCH 00/18] basic driver interface elements

This Patch series introduces the basic elements needed on the driver interface: synchro mechanisms, atomics, spinlocks... These are simply copied from the Application interfaces, with minor changes on path and prefix to fit the new interface. Patch 1 reintroduce a change made in commit 1fcd2369be8

[lng-odp] [API-NEXT PATCH 03/18] linux-generic: cosmetic changes on byteorder files

To please check-patch before the copy to the drv interface. Signed-off-by: Christophe Milard --- include/odp/api/spec/byteorder.h | 4 platform/linux-generic/include/odp/api/byteorder.h| 3 --- platform/linux-generic/include/odp/api/plat/byteorder_ty

[lng-odp] [PATCH] test: add termination path for l2fwd

Signed-off-by: Maxim Uvarov --- test/performance/odp_l2fwd.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/test/performance/odp_l2fwd.c b/test/performance/odp_l2fwd.c index f4947ca..f05aa30 100644 --- a/test/performance/odp_l2fwd.c +++ b/test/performance/od

[lng-odp] [PATCH] linux-gen: scope ipc shared memory for packet pools only

Instead of placing all allocation to shared memory, place only packets pool. Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_pool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index ec6d86

[lng-odp] [PATCH] configure.ac: fix have_pcap AM_CONDITIONAL

This causes "./configure: line 20048: test: =: unary operator expected" error messages, while the generated code was like this: if test $pktio_dpdk_support = yes ; then PKTIO_DPDK_TRUE= PKTIO_DPDK_FALSE='#' else ... Signed-off-by: Zoltan Kiss --- diff --git a/configure.ac b/configure.ac ind

Re: [lng-odp] [PATCH 2/2] example/ipsec: add .sh for valgrind to skip

On 18 July 2016 at 04:41, Maxim Uvarov wrote: > you need to declare scripts extensions so that valgrind will start skip > checks on scripts. I.e.: > > TEST_EXTENSIONS = .sh Thank you, will add > > > Maxim. > > > On 07/15/16 18:28, Mike Holmes wrote: > >> Suggested-by: Maxim Uvarov >> Signed-

Re: [lng-odp] The number of ODP pools

On 07/18/16 12:14, Sorin Vultureanu wrote: Hi, Please increase the number of available pools for odp-dpdk and odp-linux as now 16 is on the small side. ofp/scripts/odp-dpdk/platform/linux-dpdk/include/odp_config_internal.h:17: #define ODP_CONFIG_POOLS 16 I suppose a platform will put here the

[lng-odp] The number of ODP pools

Hi, Please increase the number of available pools for odp-dpdk and odp-linux as now 16 is on the small side. ofp/scripts/odp-dpdk/platform/linux-dpdk/include/odp_config_internal.h:17: #define ODP_CONFIG_POOLS 16 I suppose a platform will put here the real maximum number of pools, so there is n

Re: [lng-odp] [PATCH 2/2] example/ipsec: add .sh for valgrind to skip

you need to declare scripts extensions so that valgrind will start skip checks on scripts. I.e.: TEST_EXTENSIONS = .sh Maxim. On 07/15/16 18:28, Mike Holmes wrote: Suggested-by: Maxim Uvarov Signed-off-by: Mike Holmes --- example/ipsec/Makefile.am | 18 +++