Re: [lng-odp] [PATCH v2 0/6] scheduler rings

2016-09-05 Thread Yi He
For this series: Reviewed-and-tested-by: Yi He On 5 September 2016 at 18:09, Petri Savolainen wrote: > > v2: > * Addressed both comments from Yi He > * Fixed a clang compilation issue > > Optimized scheduler priority queue and packet IO poll queue implementation > with a ring based data st

Re: [lng-odp] [PATCH] example: l2fwd: fix clang build

2016-09-05 Thread Bill Fischofer
Yes, other than the subject typo, this looks good. Thanks. On Mon, Sep 5, 2016 at 10:18 PM, Maxim Uvarov wrote: > subject has to be l3fwd :) > > I have to read what I write before sending. Will change subject on merge. > > Maxim. > > > On 09/05/16 22:05, Maxim Uvarov wrote: > >> Signed-off-by:

Re: [lng-odp] [PATCH] example: l2fwd: fix clang build

2016-09-05 Thread Maxim Uvarov
subject has to be l3fwd :) I have to read what I write before sending. Will change subject on merge. Maxim. On 09/05/16 22:05, Maxim Uvarov wrote: Signed-off-by: Maxim Uvarov --- example/l3fwd/odp_l3fwd_db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/l3fwd/

Re: [lng-odp] [API-NEXT PATCHv3 00/13] drv shared memory allocator

2016-09-05 Thread Maxim Uvarov
Merged, after doxygen drv clean up patches warnings went away. Thanks! Maxim. On 09/02/16 18:27, Bill Fischofer wrote: I think Christophe is the only one affected by this patch, so I agree that waiting for him to issue a v4 makes sense. I'm sure it's a simple update, but best to continue the

Re: [lng-odp] [API-NEXT PATCH] doc: application-api-guide: excluding drv interface

2016-09-05 Thread Maxim Uvarov
merged, Maxim. On 08/19/16 18:10, Christophe Milard wrote: The input files parsed to generate the ODP platform specific API doc included (wrongly) part of the drv interface specification. This led to warning on undefined symbols. Fixed by restricting imput files to API only. Signed-off-by: Chri

Re: [lng-odp] [API-NEXT PATCH] doc: drv: fix doxyfile for drv doc generation

2016-09-05 Thread Maxim Uvarov
Merged, Maxim. On 08/19/16 17:46, Christophe Milard wrote: Restricting to the driver interface and defining general macros. Signed-off-by: Christophe Milard --- doc/driver-api-guide/Doxyfile | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/doc/driver-api-gui

[lng-odp] [PATCH] example: l2fwd: fix clang build

2016-09-05 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- example/l3fwd/odp_l3fwd_db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/l3fwd/odp_l3fwd_db.c b/example/l3fwd/odp_l3fwd_db.c index 4731237..082b2c2 100644 --- a/example/l3fwd/odp_l3fwd_db.c +++ b/example/l3fwd/odp_l3fwd_db.c @@ -209,

Re: [lng-odp] [PATCH 3/3] example/l3fwd: enhance flow lookup performance in hash

2016-09-05 Thread Maxim Uvarov
uh.. some previous version had clang issue and I was sure that it's fixed. Will send a patch due to it's very trivial. Maxim. On 5 September 2016 at 16:34, Bill Fischofer wrote: > Looks like this was merged too soon. It fails to compile with clang: > > Making all in l3fwd > make[2]: Entering di

Re: [lng-odp] [PATCH 3/3] example/l3fwd: enhance flow lookup performance in hash

2016-09-05 Thread Bill Fischofer
Looks like this was merged too soon. It fails to compile with clang: Making all in l3fwd make[2]: Entering directory '/home/bill/linaro/petrisched/example/l3fwd' CC odp_l3fwd-odp_l3fwd.o CC odp_l3fwd-odp_l3fwd_db.o odp_l3fwd_db.c:212:10: error: cast from 'char *' to 'flow_entry_t *

Re: [lng-odp] [PATCH 3/3] example/l3fwd: enhance flow lookup performance in hash

2016-09-05 Thread Maxim Uvarov
merged. On 09/02/16 18:23, Elo, Matias (Nokia - FI/Espoo) wrote: Just nitpicking here but there is an extra ' From: Xuelin Shi ' in all commit messages. You should also include the version tag in all patches (e.g. [PATCHv9 3/3]). This way one can apply all the patches with a single 'git am /

Re: [lng-odp] [PATCH] test: l2fwd: remove wait time from sched mode

2016-09-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Friday, September 02, 2016 5:05 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com>; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH] test: l2fwd: remove wait time from sched > mode > > On 09

[lng-odp] [PATCH v2] test: l2fwd: remove wait time from sched mode

2016-09-05 Thread Petri Savolainen
Application requested 100ms timeout for no reason in the scheduler mode. For example on odp-linux, performance is improved about 10% when the timeout is removed (as time keeping creates system calls). Signed-off-by: Petri Savolainen --- test/common_plat/performance/odp_l2fwd.c | 6 ++ 1 file

Re: [lng-odp] [PATCH 1/6] linux-gen: sched: ring based priority queues

2016-09-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
Both comments, this one and 2/6 are fixed by v2. Thanks, Petri From: Yi He [mailto:yi...@linaro.org] Sent: Monday, September 05, 2016 9:51 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: lng-odp Subject: Re: [lng-odp] [PATCH 1/6] linux-gen: sched: ring based priority queues Hi, Petri Here a

[lng-odp] [PATCH v2 1/6] linux-gen: sched: ring based priority queues

2016-09-05 Thread Petri Savolainen
Implemented scheduler priority queues with a ring based data structure instead of odp_queue_t queues. This enables performance optimization since a ring of indexes is more efficient to access than pointers in a linked list. Ring operations maybe further optimized with another lockfree algorithm. S

[lng-odp] [PATCH v2 5/6] linux-gen: sched: increase max dequeue batch size

2016-09-05 Thread Petri Savolainen
Increased queue dequeue batch size to improve throughput. Low priority queues have smaller batch size than high/default, so that head of line blocking latency is limited. Signed-off-by: Petri Savolainen --- .../linux-generic/include/odp_schedule_internal.h | 2 +- platform/linux-generic/odp_sc

[lng-odp] [PATCH v2 2/6] linux-gen: sched: ring based pktio command queues

2016-09-05 Thread Petri Savolainen
Implement scheduler pktio poll command queues with a ring based data structure instead of odp_queue_t queues. Also scheduler initialization and termination is simplified as there is no more dependency to pool, buffer and queue APIs. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp

[lng-odp] [PATCH v2 4/6] linux-gen: sched: pktio poll loop optimization

2016-09-05 Thread Petri Savolainen
Optimized pktio poll loop if-branches with likely/unlikely hints. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_schedule.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/platform/linux-generic/odp_schedule.c b/platform/l

[lng-odp] [PATCH v2 0/6] scheduler rings

2016-09-05 Thread Petri Savolainen
v2: * Addressed both comments from Yi He * Fixed a clang compilation issue Optimized scheduler priority queue and packet IO poll queue implementation with a ring based data structure. Scheduler performance is improved tens of percents in a typical test case. Also there's no more dependency

[lng-odp] [PATCH v2 6/6] linux-gen: sched: call schedule_release_atomic directly

2016-09-05 Thread Petri Savolainen
Use local schedule_release_atomic call instead of the API call. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_schedule.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/

[lng-odp] [PATCH v2 3/6] linux-gen: sched: increase number of pktin

2016-09-05 Thread Petri Savolainen
Increased maximum number of pktin queues supported by the scheduler. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_schedule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c index