Re: [lng-odp] [API-NEXT PATCHv2 00/16] using _ishm as north API mem allocator

2016-10-18 Thread Bill Fischofer
This looks good. Minor doc corrections/suggestions noted in part 16. Given that this breaks the current IPC implementation is should not be merged until Maxim has a sympathetic IPC update to link to these changes. For this series: Reviewed-and-tested-by: Bill Fischofer On Tue, Oct 18, 2016 at 6

Re: [lng-odp] [API-NEXT PATCHv2 16/16] doc: updating docs for the shm interface extension

2016-10-18 Thread Bill Fischofer
On Tue, Oct 18, 2016 at 6:56 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Signed-off-by: Christophe Milard > --- > doc/users-guide/users-guide.adoc | 58 ++ > +- > 1 file changed, 57 insertions(+), 1 deletion(-) > > diff --git a/doc/users-gui

Re: [lng-odp] [PATCH 2/2] add travis.yml for gitub automation

2016-10-18 Thread Mike Holmes
On 18 October 2016 at 15:36, Maxim Uvarov wrote: > btw, > > can you also add call for: > ./scripts/build-pktio-dpdk > > to compile dpdk pktio? > > And I think something similar for netmap. Not now, this is purely to get to the goal of simple validation of ODP using what auto make provides with th

Re: [lng-odp] [PATCH 2/2] add travis.yml for gitub automation

2016-10-18 Thread Maxim Uvarov
btw, can you also add call for: ./scripts/build-pktio-dpdk to compile dpdk pktio? And I think something similar for netmap. Maxim. On 10/18/16 19:06, Mike Holmes wrote: On 18 October 2016 at 11:52, Maxim Uvarov wrote: On 10/18/16 18:24, Mike Holmes wrote: allows pushes to a github clone o

Re: [lng-odp] [API-NEXT PATCHv4 0/5] Add Packet Splice/Reference APIs

2016-10-18 Thread Bill Fischofer
On Tue, Oct 18, 2016 at 9:56 AM, Ola Liljedahl wrote: > > > On 17 October 2016 at 16:34, Bill Fischofer > wrote: > >> >> >> On Mon, Oct 17, 2016 at 8:54 AM, Ola Liljedahl >> wrote: >> >>> On 10 October 2016 at 17:50, Bill Fischofer >>> wrote: >>> This patch adds support for packet referen

Re: [lng-odp] api-next drvshmem_main validation test failing

2016-10-18 Thread Christophe Milard
Hi, First, Matias, I need to apologize for not answering this sooner: I just missed it the the list (and Thanks Petri for the recall on the arch call). If you face shm problems, you can copy me in the future. There are Many interresting things in your log: First, I think we are exceeding the (cur

Re: [lng-odp] [PATCH 2/2] add travis.yml for gitub automation

2016-10-18 Thread Mike Holmes
On 18 October 2016 at 11:52, Maxim Uvarov wrote: > On 10/18/16 18:24, Mike Holmes wrote: >> >> allows pushes to a github clone of ODP to automatically trigger CI builds >> >> Signed-off-by: Mike Holmes >> --- >> .travis.yml | 35 +++ >> 1 file changed, 35 insert

Re: [lng-odp] [PATCH 2/2] add travis.yml for gitub automation

2016-10-18 Thread Maxim Uvarov
On 10/18/16 18:24, Mike Holmes wrote: allows pushes to a github clone of ODP to automatically trigger CI builds Signed-off-by: Mike Holmes --- .travis.yml | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 .travis.yml diff --git a/.travis.yml b/.

[lng-odp] [PATCH 1/2] configure: the version cannot use a script

2016-10-18 Thread Mike Holmes
Use of a script in the autotools breaks github CI Define the API version in configure and reuse it in the code Benefits: removes dependence on scripts to build removes scripts and the make file from odp/scripts removes generated .scmversion file places api versioning right next to lib versioning i

[lng-odp] [PATCH 2/2] add travis.yml for gitub automation

2016-10-18 Thread Mike Holmes
allows pushes to a github clone of ODP to automatically trigger CI builds Signed-off-by: Mike Holmes --- .travis.yml | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0

Re: [lng-odp] [API-NEXT PATCHv4 0/5] Add Packet Splice/Reference APIs

2016-10-18 Thread Ola Liljedahl
On 17 October 2016 at 16:34, Bill Fischofer wrote: > > > On Mon, Oct 17, 2016 at 8:54 AM, Ola Liljedahl > wrote: > >> On 10 October 2016 at 17:50, Bill Fischofer >> wrote: >> >>> This patch adds support for packet references and splices following >>> discussions at LAS16 on this subject. >>> >>

[lng-odp] [API-NEXT PATCHv2 16/16] doc: updating docs for the shm interface extension

2016-10-18 Thread Christophe Milard
Signed-off-by: Christophe Milard --- doc/users-guide/users-guide.adoc | 58 +++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide.adoc b/doc/users-guide/users-guide.adoc index 62f5833..60364cb 100755 --- a/doc/users-guid

[lng-odp] [API-NEXT PATCHv2 15/16] linux_gen: _ishm: decreasing the number of error messages when no huge pages

2016-10-18 Thread Christophe Milard
Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c index 11bb316..0c08998 100644 --- a/platform/linux-generic/_ishm.c +++ b/

[lng-odp] [API-NEXT PATCHv2 13/16] test: linux-gen: api: shmem: test sharing memory between ODP instances

2016-10-18 Thread Christophe Milard
The platform tests odp/test/linux-generic/validation/api/shmem are updated to both test ODP<->linux process memory sharing, but also test ODP to ODP (different instances) memory sharing. shmem_linux is the main test process, and shmem_linux.c contains (at file top) a chart flow of the test procedur

[lng-odp] [API-NEXT PATCHv2 14/16] linux-gen: _ishm: cleaning remaining block at odp_term_global

2016-10-18 Thread Christophe Milard
Remaining (forgotten, not freed) blocks are gathered and related files cleaned when odp_term_global() is called. An error message is also issued so the application writters get to know about these blocks Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c | 16 1

[lng-odp] [API-NEXT PATCHv2 11/16] linux-gen: _ishm: adding function to map memory from other ODP

2016-10-18 Thread Christophe Milard
functionality to export and map memory between ODP instance is added: This includes: - a bit of simplification in _odp_ishm_reserve() for externaly provided file descriptors. - a new function, _odp_ishm_reserve_exported() to map memory from other ODP instances (On same OS) Signed-off-by: Chris

[lng-odp] [API-NEXT PATCHv2 12/16] linux-gen: shm: add flag and function to share memory between ODP instances

2016-10-18 Thread Christophe Milard
Implemented by calling the related functions from _ishm. Signed-off-by: Christophe Milard --- platform/linux-generic/odp_shared_memory.c | 37 ++ 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/odp_shared_memory.c b/platform/linu

[lng-odp] [API-NEXT PATCHv2 10/16] api: shmem: add flag and function to share memory between ODP instances

2016-10-18 Thread Christophe Milard
The flag ODP_SHM_EXPORT is added: when passed at odp_shm_reserve() time the memory block becomes visible to other ODP instances. The function odp_shm_reserve_exported() is added: this function enables to reserve block of memories exported by other ODP instances (using the ODP_SHM_EXPORT flag). Sig

[lng-odp] [API-NEXT PATCHv2 09/16] test: api: shmem: new proper tests for shm API

2016-10-18 Thread Christophe Milard
The shmem "sunnydays" tests for the north interface API are replaced with proper tests, testing memory allocation at different time (before and after ODP thread creation, i.e. the tests make sure shmem behaves the same regardless of fork time). The tests also include stress testing trying to provoq

[lng-odp] [API-NEXT PATCHv2 08/16] linux-gen: shm: new ODP_SHM_LOCK flag implementation

2016-10-18 Thread Christophe Milard
The flag locks the allocated memory (prevent swapping) The patch just exposes the _ODP_ISHM_LOCK flag of the internal memory allocator, ishm. Signed-off-by: Christophe Milard --- platform/linux-generic/odp_shared_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic

[lng-odp] [API-NEXT PATCHv2 06/16] linux-gen: shm: new ODP_SHM_SINGLE_VA flag implementation

2016-10-18 Thread Christophe Milard
This flag guarentess the unicity the the block address on all ODP threads. The patch just exposes the _ODP_ISHM_SINGLE_VA flag of the internal memory allocator, ishm. Signed-off-by: Christophe Milard --- platform/linux-generic/odp_shared_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git

[lng-odp] [API-NEXT PATCHv2 07/16] api: shm: add flag to lock memory

2016-10-18 Thread Christophe Milard
The ODP_SHM_LOCK flag is created: when set (at odp_shm_reserve()), this flag locks the reserved memory (prevent swapping) Signed-off-by: Christophe Milard --- include/odp/api/spec/shared_memory.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/odp/api/spec/shared_memory.h b/include/

[lng-odp] [API-NEXT PATCHv2 05/16] api: shm: add flag to guarantee address unicity on all ODP threads

2016-10-18 Thread Christophe Milard
The ODP_SHM_SINGLE_VA flag is created: when set (at odp_shm_reserve()), this flag guarantees that all ODP threads sharing this memory block will see the block at the same address (regadless of ODP thread type -pthread vs process- or fork time) Signed-off-by: Christophe Milard --- include/odp/api

[lng-odp] [API-NEXT PATCHv2 04/16] linux-gen: Push internal flag definition

2016-10-18 Thread Christophe Milard
File platform/linux-generic/include/odp_shm_internal.h exposes shm internals used by IPC. The bits used by the internal flags are moved to make room for more "official" values. The platform/linux-generic/include/odp_shm_internal.h file should really be removed when _ishm is used, but as long as we

[lng-odp] [API-NEXT PATCHv2 03/16] linux-gen: use ishm as north API mem allocator

2016-10-18 Thread Christophe Milard
The odp shared_memory API is changed to use the ODP internal memory allocator: _ishm. _ishm supports memory sharing between processes, regardless of fork time. The test testing the ODP_SHM_PROC flag is also changed to cope with the new OS sharing interface used by _ishm (link in /tmp). Signed-off-

[lng-odp] [API-NEXT PATCHv2 02/16] linux-gen: _ishm: allow memory alloc/free at global init/term

2016-10-18 Thread Christophe Milard
_ishm.c assumed that both _ishm_init_global() and _ishm_init_local() had been run to work properly. This assumption turns out the be a problem if _ishm is to be used as main memory allocator, as many modules init_global functions assume the availability of the odp_reserve() function before any init

[lng-odp] [API-NEXT PATCHv2 00/16] using _ishm as north API mem allocator

2016-10-18 Thread Christophe Milard
since v1: -flag _ODP_SHM_PROC_NOCREAT and _ODP_SHM_O_EXCL get new values (but remain useless: Should be removed when IPC is updated) (Maxim) -In get_ishm_flags(), odp_shm_capability() local variable flgs renamed (for be better distinction from other "flags" variable. (Maxim) -Added doc updates w

[lng-odp] [API-NEXT PATCHv2 01/16] linux-gen: _ishm: create link for external memory sharing

2016-10-18 Thread Christophe Milard
A new flag called _ODP_ISHM_LINK is added to _ishm. When this flag is specified at reserve() time, a link ("/tmp/odp--shm-" where is the process ID of the main ODP instatiation process and is the block name given at reserve time) is created, linking to the underlying block file (either in /tmp or