[lng-odp] [RFC API-NEXT PATCH 5/5] test: drv: shm: adding small allocation stress tests

2016-12-19 Thread Christophe Milard
stress tests added for allocation of small memory units using odpdrv_shm_sreserve() and odpdrv_shm_sfree(). Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 164 + .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files cha

[lng-odp] [RFC API-NEXT PATCH 4/5] test: drv: shm: adding small allocation tests

2016-12-19 Thread Christophe Milard
Tests for odpdrv_shm_sreserve() and odpdrv_shm_sfree are added, testing the ishm small memory unit allocator. Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 77 ++ .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files ch

[lng-odp] [RFC API-NEXT PATCH 1/5] linux-gen: _ishm: adding buddy allocation

2016-12-19 Thread Christophe Milard
_ishm now provides a function to create a pool for buddy memory allocation, as well as functions to allocated/release memory from the created pool. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 2 + platform/linux-generic/_ishmbuddy.c

[lng-odp] [RFC API-NEXT PATCH 2/5] drv: adding odpdrv_shm_sreserve and odpdrv_shm_sfree()

2016-12-19 Thread Christophe Milard
The two functions are meant to be used fo small amount of memory allocation. They are quicker, lighter and have a smaller granularity than the odpdrv_shm_reserve() / odpdrv_shm_free_*() sets of function, but also lacks some of their functionality (lookup, export, flags). Signed-off-by: Christophe

[lng-odp] [RFC API-NEXT PATCH 3/5] linux-gen: drv: shm: adding buddy allocator

2016-12-19 Thread Christophe Milard
A pool for buddy allocation of small memory sizes is created at boot time and functions to reserve/free memory from this pool added (using the _ishm equivalent, of course). Memory allocated from this pool is sharable between ODP threads, (which malloc() would not guarantee in the odptreads as proce

[lng-odp] [RFC API-NEXT PATCH 0/5] small memory amount allocator for drv shm

2016-12-19 Thread Christophe Milard
This patch series aims at giving the ability for units using the ODP drv (south) interface to allocate small unit of memory (hence going lower than the page size, which is the lower limit for odp_drvshm_reserve). The interface now provides two functions (whose usage is very similar to malloc/free,

Re: [lng-odp] [API-NEXT PATCHv5 0/5] driver initialisation framework

2016-12-19 Thread Yi He
for this patch series Reviewed-and-tested-by: Yi He On 19 December 2016 at 18:50, Christophe Milard < christophe.mil...@linaro.org> wrote: > Since V4: > -typo fix (Thanks Yi!) > -rebased. > > Since V3: > -minor interface simplification and name change (Christophe) > -Fix for clang (Bill)

[lng-odp] [Bug 2779] CID 173342: Error handling issues (CHECKED_RETURN)

2016-12-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2779 Bill Fischofer changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [Bug 2779] CID 173342: Error handling issues (CHECKED_RETURN)

2016-12-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2779 --- Comment #1 from Bill Fischofer --- *** Bug 2780 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 2780] CID 173342: Error handling issues (CHECKED_RETURN)

2016-12-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2780 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[lng-odp] [PATCH] example: l3fwd: explicitly ignore rc from parse call

2016-12-19 Thread Bill Fischofer
odph_eth_addr_parse always returns RC == 0. Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2780 by explicitly ignoring this. Signed-off-by: Bill Fischofer --- example/l3fwd/odp_l3fwd_db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/l3fwd/odp_l3fwd_db.c b/exam

[lng-odp] [Bug 2779] New: CID 173342: Error handling issues (CHECKED_RETURN)

2016-12-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2779 Bug ID: 2779 Summary: CID 173342: Error handling issues (CHECKED_RETURN) Product: OpenDataPlane - linux- generic reference Version: v1.11.0.0 Hardware: Other OS: Linux

[lng-odp] [Bug 2780] New: CID 173342: Error handling issues (CHECKED_RETURN)

2016-12-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2780 Bug ID: 2780 Summary: CID 173342: Error handling issues (CHECKED_RETURN) Product: OpenDataPlane - linux- generic reference Version: v1.11.0.0 Hardware: Other OS: Linux

Re: [lng-odp] [PATCH] example: introducing multi-threaded traffic management case

2016-12-19 Thread Barry Spinney
Yes, I would like to - BUT I just found out that the test that my Doctor ordered for me for tomorrow morning takes ~3 hours (I had assumed < 30 minutes), and so I will NOT be able to join tomorrow's ODP external call to discuss this (this isn't so simple as just giving feedback, but probably needs

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bill Fischofer
On Mon, Dec 19, 2016 at 1:22 PM, Maxim Uvarov wrote: > On 12/19/16 19:41, Bill Fischofer wrote: >> On Mon, Dec 19, 2016 at 9:57 AM, Maxim Uvarov >> wrote: >>> how about group all packet reference apis to odp_packet_ref_ naming? >>> >>> In that case >>> >>> odp_packet_ref() -> odp_packet_ref_crea

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Maxim Uvarov
On 12/19/16 19:41, Bill Fischofer wrote: > On Mon, Dec 19, 2016 at 9:57 AM, Maxim Uvarov wrote: >> how about group all packet reference apis to odp_packet_ref_ naming? >> >> In that case >> >> odp_packet_ref() -> odp_packet_ref_create() (same as odp_pool_create, >> odp_queue, create). > > I think

Re: [lng-odp] [PATCH 1/3] test: l2fwd: lookup table for sched mode

2016-12-19 Thread Maxim Uvarov
Merged with my review, Maxim. On 12/05/16 15:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Ping. > >> -Original Message- >> From: Savolainen, Petri (Nokia - FI/Espoo) >> Sent: Thursday, November 17, 2016 10:14 AM >> To: 'lng-odp@lists.linaro.org' >> Cc: 'Maxim Uvarov' >> Subject: R

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bill Fischofer
On Mon, Dec 19, 2016 at 9:57 AM, Maxim Uvarov wrote: > how about group all packet reference apis to odp_packet_ref_ naming? > > In that case > > odp_packet_ref() -> odp_packet_ref_create() (same as odp_pool_create, > odp_queue, create). I think the _create() suffix is unnecessary but have no obje

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Maxim Uvarov
how about group all packet reference apis to odp_packet_ref_ naming? In that case odp_packet_ref() -> odp_packet_ref_create() (same as odp_pool_create, odp_queue, create). both odp_packet_is_ref() and odp_packet_has_ref() -> odp_packet_ref() (function which returns ref counter) It will be more

Re: [lng-odp] [API-NEXT PATCHv9 1/3] api: random: add explicit controls over random data

2016-12-19 Thread Maxim Uvarov
Merged, Maxim. On 12/19/16 13:36, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Reviewed-by: Petri Savolainen > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Monday, December 12, 2016 5:06 PM >> To: lng-odp@lis

Re: [lng-odp] [PATCH] example: introducing multi-threaded traffic management case

2016-12-19 Thread Bill Fischofer
+cc Barry. Barry: would you also like to take a look at this? Thanks. On Mon, Dec 19, 2016 at 12:01 AM, wrote: > From: Xuelin Shi > > introduce a new example of traffic management with following features: > - multiple TM threads: one TM thread for each pktio > - for small system less than

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bill Fischofer
On Mon, Dec 19, 2016 at 4:06 AM, Bala Manoharan wrote: > Comments inline > > > On 15 November 2016 at 20:14, Bill Fischofer > wrote: >> Introduce three new APIs that support efficient sharing of portions of >> packets. >> >> odp_packet_ref_static() creates an alias for a base packet >> >> od

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

2016-12-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Thursday, December 08, 2016 1:04 PM > To: lng-odp@lists.linaro.org > Subject: Suspected SPAM - [lng-odp] [API-NEXT PATCH] linux-gen: > schedule_sp: use ring as prio

Re: [lng-odp] [API-NEXT PATCHv9 1/3] api: random: add explicit controls over random data

2016-12-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Monday, December 12, 2016 5:06 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv9 1/3] api: random: add explicit > cont

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

2016-12-19 Thread Bala Manoharan
Comments inline On 15 November 2016 at 20:14, Bill Fischofer wrote: > Introduce three new APIs that support efficient sharing of portions of > packets. > > odp_packet_ref_static() creates an alias for a base packet > > odp_packet_ref() creates a reference to a base packet > > odp_packet_ref_

[lng-odp] [API-NEXT PATCHv5 4/5] test: preventing odp.conf loading for tests

2016-12-19 Thread Christophe Milard
The tests should not be affected by any system or user ODP configuration file. The ODP_SYSCONFIG_FILE environment variables is therefore set to "none" in TESTS_ENVIRONMENT. Tests which needs specific a configuration file will have to overwrite this setting. Note that tests ran manually (not using m

[lng-odp] [API-NEXT PATCHv5 5/5] linux-gen: drv_drivers: loading modules from config file

2016-12-19 Thread Christophe Milard
The shared objects listed in the ODP configuration files are loaded at init time. The odp configuration file list the shared objects to be loaded as shown in the following example: module = { modules = ["enumerator1.so", "driver1.so"]; }; Signed-off-by: Christophe Milard --- configure.ac

[lng-odp] [API-NEXT PATCHv5 3/5] linux-gen: init: adding configuration file parsing

2016-12-19 Thread Christophe Milard
The parsing of the odp.conf configuration file is added. The file is searched first in the local directory (.) and then is the $prefix/etc directory. This requires libconfig (sudo apt-get install libconfig-dev) Signed-off-by: Christophe Milard --- DEPENDENCIES |

[lng-odp] [API-NEXT PATCHv5 2/5] linux-gen: adding enum, devio and driver registration interface (stub)

2016-12-19 Thread Christophe Milard
The linux implementation for the enumerator class registration function, enumerator instance registration function, devio and driver registration functions (stub) Signed-off-by: Christophe Milard --- include/odp_drv.h | 1 + platform/linux-generic/Makefile.am

[lng-odp] [API-NEXT PATCHv5 0/5] driver initialisation framework

2016-12-19 Thread Christophe Milard
Since V4: -typo fix (Thanks Yi!) -rebased. Since V3: -minor interface simplification and name change (Christophe) -Fix for clang (Bill) -Google doc describing the driver and device frameworks structure: https://docs.google.com/document/d/1eCKPJF6uSlOllXi_sKDvRwUD2BXm-ZzxZoKT0nVEsl4/edit#headi

[lng-odp] [API-NEXT PATCHv5 1/5] drv: adding driver registration interface (stub)

2016-12-19 Thread Christophe Milard
The enumerator class, enumerator instance, devio and driver registration functions prototypes (and a draft of their parameters) are defined, the goal being to define the registration framework only. Signed-off-by: Christophe Milard --- include/odp/drv/spec/driver.h | 299