[lng-odp] [API-NEXT] linux-gen: init: avoiding segfault if cleaning files

2017-01-02 Thread Christophe Milard
The call the the cleanup_files() function (which cleans up possible remaining file(s) from a defunc OPD with same pid) may use ODP_DBG and ODP_ERR functions, but is (before this patch) placed before these ODP_* functions are initialized. This would surely sigfault. The call the the cleanup_files()

Re: [lng-odp] [PATCH 2/4] helper: cleanup Linux rename to thread

2017-01-02 Thread Christophe Milard
On 2016-12-23 14:15, Mike Holmes wrote: > Remove the OS specific Linux filename and use the name of the generic > apis it contains which is for odp_threads > > Signed-off-by: Mike Holmes > --- > example/classifier/odp_classifier.c | 2 +- > example/generator/odp_generator.c

Re: [lng-odp] [PATCH 3/4] helper: move thread implementation under platform

2017-01-02 Thread Christophe Milard
On 2016-12-23 14:15, Mike Holmes wrote: > Only the portable api is built by default, use --enable-helper-extn > to enable non portable APIs for a helper platform > > Signed-off-by: Mike Holmes > --- Got the following warning when applying this patch: Applying: helper: move thread implementation

Re: [lng-odp] [PATCH v3 2/2] test: pktio_ordered: add test script

2017-01-02 Thread Elo, Matias (Nokia - FI/Espoo)
> pktio/socket_mmap.c:78:mmap_pkt_socket():socket(SOCK_RAW): Operation > not permitted > _ishm.c:451:create_file():open failed for > /tmp/odp-10626-ishm-pktio-pcap:in=./udp64.pcap: No such file or > directory. > _ishm.c:891:_odp_ishm_reserve():_ishm_reserve failed. > odp_packet_io.c:224:setup_pkti

Re: [lng-odp] [PATCH 3/4] helper: move thread implementation under platform

2017-01-02 Thread Christophe Milard
On 2016-12-23 14:15, Mike Holmes wrote: > Only the portable api is built by default, use --enable-helper-extn > to enable non portable APIs for a helper platform > > Signed-off-by: Mike Holmes > --- I am probably missing something, but, seen from the original file, I would have expected everythi

Re: [lng-odp] [API-NEXT PATCHv8 0/5] driver initialisation framework

2017-01-02 Thread Christophe Milard
Something when obviously wrong when I generated this. Seems corrupt. Will inverstigate and send a v9. With year update to 2017 as well Christophe On 30 December 2016 at 16:19, Christophe Milard wrote: > Since V7: > -changed include order in drv_driver.c (Anders) > -correction of package name f

[lng-odp] [PATCH] linux-gen: netmap: bump supported netmap version to 11.2

2017-01-02 Thread Matias Elo
Signed-off-by: Matias Elo --- DEPENDENCIES | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DEPENDENCIES b/DEPENDENCIES index f1f0edd..574859c 100644 --- a/DEPENDENCIES +++ b/DEPENDENCIES @@ -83,13 +83,13 @@ Prerequisites for building the OpenDataPlane (ODP) API 3.3.1 Buil

Re: [lng-odp] [PATCH v3 2/2] test: pktio_ordered: add test script

2017-01-02 Thread Bill Fischofer
I see the same sort of behavior with l2fwd_simple, so I'm inclined to agree with you. I've verified that libpcap-dev is installed. What more should be needed to run these? On Mon, Jan 2, 2017 at 6:21 AM, Elo, Matias (Nokia - FI/Espoo) wrote: > >> pktio/socket_mmap.c:78:mmap_pkt_socket():socket(SO

[lng-odp] [API-NEXT PATCHv9 0/5] driver initialisation framework

2017-01-02 Thread Christophe Milard
Since V8: -fixed corrupt V8 -copyright updates: 2017 (BTW: Happy new year) Since V7: -changed include order in drv_driver.c (Anders) -correction of package name for Fedora install in DEPENDENCIES (Anders) -user config file changed from ./odp.conf to ~/.odp.conf: then the user config file a

[lng-odp] [API-NEXT PATCHv9 1/5] drv: adding driver registration interface (stub)

2017-01-02 Thread Christophe Milard
The enumerator class, enumerator instance, devio and driver registration functions prototypes (and a draft of their parameters) are defined, the goal being to define the registration framework only. Signed-off-by: Christophe Milard --- include/odp/drv/spec/driver.h | 293

[lng-odp] [API-NEXT PATCHv9 2/5] linux-gen: adding enum, devio and driver registration interface (stub)

2017-01-02 Thread Christophe Milard
The linux implementation for the enumerator class registration function, enumerator instance registration function, devio and driver registration functions (stub) Signed-off-by: Christophe Milard --- include/odp_drv.h | 1 + platform/linux-generic/Makefile.am

[lng-odp] [API-NEXT PATCHv9 4/5] test: preventing odp.conf loading for tests

2017-01-02 Thread Christophe Milard
The tests should not be affected by any system or user ODP configuration file. The ODP_SYSCONFIG_FILE environment variables is therefore set to "none" in TESTS_ENVIRONMENT. Tests which need specific a configuration file will have to overwrite this setting. Note that tests ran manually (not using ma

[lng-odp] [API-NEXT PATCHv9 3/5] linux-gen: init: adding configuration file parsing

2017-01-02 Thread Christophe Milard
The parsing of the odp.conf configuration file is added. The file is searched first in filename specified in the environment variable $ODP_SYSCONFIG_FILE (where the special string "none" prevent any file loading) The file is then searched in the user home directory (~) and then is the $prefix/etc d

[lng-odp] [API-NEXT PATCHv9 5/5] linux-gen: modules: adding initial file to load modules

2017-01-02 Thread Christophe Milard
The shared objects listed in the ODP configuration files are loaded at init time. The odp configuration file lists the shared objects to be loaded as shown in the following example: module = { modules = ["enumerator1.so", "driver1.so"]; }; Signed-off-by: Christophe Milard --- configure.a

Re: [lng-odp] api for small buffer allocations

2017-01-02 Thread Francois Ozog
Sorry for joining the discussion late... here are a few points: The more we defer taking into account NUMA node in memory related APIs, the more we'll suffer when we'll be forced to integrate it. I would strongly suggest we address this topic now. Petri mentioned that we could do allocations on

[lng-odp] [API-NEXT PATCHv4 0/6] small memory amount allocator for drv shm

2017-01-02 Thread Christophe Milard
Since V3: -copyright year changed Since V2: -comment and doxygen fixes (Petri) Since V1: -Common south pool (for all drivers) suppressed. (Petri) -function to create and destroy the pools exposed to the interface, so that each user create his own pools (Petri) -support for fixed size alloc

[lng-odp] [API-NEXT PATCHv4 3/6] linux-gen: drv: shm: adding pool allocator

2017-01-02 Thread Christophe Milard
Adding functions to create memory pools and allocate / free memory from the created pools. These functions calls their _ishm conterpart, of course. Signed-off-by: Christophe Milard --- platform/linux-generic/drv_shm.c | 44 1 file changed, 44 insertions(+

[lng-odp] [API-NEXT PATCHv4 2/6] drv: adding odpdrv_shm_pool functions

2017-01-02 Thread Christophe Milard
Adding functions to create and destroy memory pools (from which memory can be allocated and freed) are added. These functions enable the usage of small memory amount (compared to drvshm_reserve() whose granularity is the page size). The usage of this pool guatantees that allocated memory is sharabl

[lng-odp] [API-NEXT PATCHv4 4/6] test: drv: shm: adding basic buddy allocation tests

2017-01-02 Thread Christophe Milard
Basic tests for odpdrv_shm_pool are added here, creating a buddy pool and performing basic alloc/free on it Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 92 ++ .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files chan

[lng-odp] [API-NEXT PATCHv4 5/6] test: drv: shm: adding basic fixed size allocation tests

2017-01-02 Thread Christophe Milard
Basic tests for odpdrv_shm_pool are added here, creating a fixed size pool and performing basic alloc/free on it Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 86 ++ .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files

[lng-odp] [API-NEXT PATCHv4 1/6] linux-gen: _ishm: adding buddy and slab allocation

2017-01-02 Thread Christophe Milard
_ishm now provides functions to create/destroy pools for buddy/slab memory allocation, as well as functions to allocated/release memory from the created pools. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 2 + platform/linux-generic/_ishm.c

Re: [lng-odp] api for small buffer allocations

2017-01-02 Thread Christophe Milard
To start with: happy new year :-) Are you saying, Francois, that you want this to have support for Numa directely? In my opinion, having this as it is now enables building lists of things, which, in turn, enable proceeding on the driver work (enumerators...). do you think we should delay this to s

[lng-odp] Is odp_random odpthread safe?

2017-01-02 Thread Christophe Milard
Hi I have noticed that (rarely enough to be a pain to catch) odp_shm and odpdrv_shm sress test sigfaults. I saw it once last week, but that was enough to worry me as the common part between the two tests is really the new memory allocator, _ishm. So I ran a test over new year trying to catch the p

Re: [lng-odp] Is odp_random odpthread safe?

2017-01-02 Thread Bill Fischofer
On Mon, Jan 2, 2017 at 11:17 AM, Christophe Milard wrote: > Hi > > I have noticed that (rarely enough to be a pain to catch) odp_shm and > odpdrv_shm sress test sigfaults. > I saw it once last week, but that was enough to worry me as the common > part between the two tests is really the new memory

Re: [lng-odp] [API-NEXT PATCHv2 1/4] linux-gen: sched: solve ordered context inversion

2017-01-02 Thread Yi He
Hi, Maxim and team Can this be merged, any comments are welcome. thanks and best regards, Yi On 21 December 2016 at 08:13, Bill Fischofer wrote: > For this series: > > Reviewed-and-tested-by: Bill Fischofer > > On Fri, Dec 9, 2016 at 4:51 AM, Yi He wrote: > > For ordered queue, a thread cons

Re: [lng-odp] [PATCH v3 2/2] test: pktio_ordered: add test script

2017-01-02 Thread Elo, Matias (Nokia - FI/Espoo)
> I see the same sort of behavior with l2fwd_simple, so I'm inclined to > agree with you. I've verified that libpcap-dev is installed. What more > should be needed to run these? > Libpcap-dev should be enough to run these tests. Based on the error log I'm guessing shm is causing this. I would t

[lng-odp] [Bug 2798] New: ODP random and other crypto functions (possibly) not thread safe?

2017-01-02 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2798 Bug ID: 2798 Summary: ODP random and other crypto functions (possibly) not thread safe? Product: OpenDataPlane - linux- generic reference Version: unspecified Hardware: Other

Re: [lng-odp] Is odp_random odpthread safe?

2017-01-02 Thread Christophe Milard
Bug 2798 Christophe On 2 January 2017 at 22:02, Bill Fischofer wrote: > On Mon, Jan 2, 2017 at 11:17 AM, Christophe Milard > wrote: >> Hi >> >> I have noticed that (rarely enough to be a pain to catch) odp_shm and >> odpdrv_shm sress test sigfaults. >> I saw it once last week, but that was enou