Re: [lng-odp] [API-NEXT PATCHv6 1/6] linux-gen: _ishm: adding buddy and slab allocation

Just note that the pool stuff is only exposed to the south (DRV) interface so far, as I need it there. I actually raised the case (a long time ago) for having it on the north side with very little traction. As I mentioned, I think this will change if we start caring about the "process-mode" as I ex

Re: [lng-odp] [API-NEXT PATCHv6 1/6] linux-gen: _ishm: adding buddy and slab allocation

Thanks Christophe for the explanation Every ODP thread can individually creates ishmpools for small memory allocation, that's convenient. I'll read into platform/linux-generic/_ishm.c. as you suggested to understand the impl. Thanks and best regards, Yi On 12 January 2017 at 18:50, Christophe Mi

Re: [lng-odp] [API-NEXT PATCHv7 1/6] linux-gen: _ishm: adding buddy and slab allocation

For this patch series: Reviewed-and-tested-by: Yi He On 13 January 2017 at 15:55, Christophe Milard wrote: > _ishm now provides functions to create/destroy pools for buddy/slab > memory allocation, as well as functions to allocated/release memory > from the created pools. > > Signed-off-by:

[lng-odp] [API-NEXT PATCHv7 1/6] linux-gen: _ishm: adding buddy and slab allocation

_ishm now provides functions to create/destroy pools for buddy/slab memory allocation, as well as functions to allocated/release memory from the created pools. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 2 + platform/linux-generic/_ishm.c

[lng-odp] [API-NEXT PATCHv7 6/6] test: drv: shm: adding buddy allocation stress tests

Stress tests for the random size allocator (buddy allocator in linux-generic) are added here. Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 177 + .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files changed, 178 inse

[lng-odp] [API-NEXT PATCHv7 5/6] test: drv: shm: adding basic fixed size allocation tests

Basic tests for odpdrv_shm_pool are added here, creating a fixed size pool and performing basic alloc/free on it Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 86 ++ .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files

[lng-odp] [API-NEXT PATCHv7 4/6] test: drv: shm: adding basic buddy allocation tests

Basic tests for odpdrv_shm_pool are added here, creating a buddy pool and performing basic alloc/free on it Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 92 ++ .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files chan

[lng-odp] [API-NEXT PATCHv7 3/6] linux-gen: drv: shm: adding pool allocator

Adding functions to create memory pools and allocate / free memory from the created pools. These functions calls their _ishm conterpart, of course. Signed-off-by: Christophe Milard --- platform/linux-generic/drv_shm.c | 44 1 file changed, 44 insertions(+

[lng-odp] [API-NEXT PATCHv7 2/6] drv: adding odpdrv_shm_pool functions

Adding functions to create and destroy memory pools (from which memory can be allocated and freed) are added. These functions enable the usage of small memory amount (compared to drvshm_reserve() whose granularity is the page size). The usage of this pool guatantees that allocated memory is sharabl

[lng-odp] [API-NEXT PATCHv7 0/6] small memory amount allocator for drv shm

Since V6: -rebased Since V5: -title fix (Yi) -rebased -flag name fix (Christophe) Since V4: -fix for clang Since V3: -copyright year changed Since V2: -comment and doxygen fixes (Petri) Since V1: -Common south pool (for all drivers) suppressed. (Petri) -function to create and destroy

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: packet transformation follows RFCs

Reviewed-by: Balasubramanian Manoharan On 13 January 2017 at 11:58, Nikhil Agarwal wrote: > Reviewed-by: Nikhil Agarwal > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Thursday, January 12, 2017 8:16 PM > To: lng-

Re: [lng-odp] [API-NEXT PATCH 1/4] validation: crypto: fix hw cipher/auth algorithm check

Can we add sync/Async in capabilities and add similar check before running synchronous and asynchronous suites? Regards Nikhil -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Matias Elo Sent: Tuesday, January 10, 2017 5:39 PM To: lng-odp@lists.lina

Re: [lng-odp] [API-NEXT PATCH 4/4] validation: crypto: check auth options support before running tests

For the series: Reviewed-by: Nikhil Agarwal -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Matias Elo Sent: Tuesday, January 10, 2017 5:39 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH 4/4] validation: crypto: check auth optio

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: packet transformation follows RFCs

Reviewed-by: Nikhil Agarwal -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri Savolainen Sent: Thursday, January 12, 2017 8:16 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH] api: ipsec: packet transformation follows RFCs

Re: [lng-odp] [API-NEXT PATCH 1/2] linux-gen: ipsec: add capability function

For this series: Reviewed-and-tested-by: Bill Fischofer On Thu, Jan 12, 2017 at 7:21 AM, Matias Elo wrote: > Add IPsec capability function (groundwork for a proper IPsec > implementation). > > Signed-off-by: Matias Elo > --- > platform/linux-generic/Makefile.am | 1 + > platform/linux-generi

Re: [lng-odp] master release status

On Thu, Jan 12, 2017 at 2:43 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Hi, > > What's the status of upgrading master with latest api-next commits and > tagging it? I can see that next branch is now at ... > > commit 23e7745272bd405483da737824af25e2e18c8b21 > Author: Bill Fischofer > Date

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

I've posted patch http://patches.opendataplane.org/patch/7857/ as an initial step towards resolving this issue. Petri: can you make your test program available to me so I can try to reproduce your results locally. I don't have quite the scale or controlled environment that you do but this should sa

[lng-odp] [Bug 2816] Packet reference performance tuning needed

https://bugs.linaro.org/show_bug.cgi?id=2816 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever confirmed|0

[lng-odp] [API-NEXT PATCH] linux-generic: packet: tune alloc/free performance for non-reference paths

As reported in Bug https://bugs.linaro.org/show_bug.cgi?id=2816 packet alloc/free performance for non-references appears significantly degraded after the introduction of packet reference support. Add fastpaths for non-reference packet frees to optimize this. Signed-off-by: Bill Fischofer --- pla

[lng-odp] [Bug 2816] Packet reference performance tuning needed

https://bugs.linaro.org/show_bug.cgi?id=2816 --- Comment #1 from Bill Fischofer --- Initial problem report from Petri's measurements: This patch is now merged, although I had some doubts that it has bad impact on performance. Here are some performance results for couple of simple, single thread

[lng-odp] [Bug 2816] New: Packet reference performance tuning needed

https://bugs.linaro.org/show_bug.cgi?id=2816 Bug ID: 2816 Summary: Packet reference performance tuning needed Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux Status: UNC

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: packet transformation follows RFCs

On Thu, Jan 12, 2017 at 8:45 AM, Petri Savolainen wrote: > Add explicit requirement that IPSEC in-/outbound operations > transform packet headers according to the standards (RFCs). > > Signed-off-by: Petri Savolainen Reviewed-by: Bill Fischofer > --- > include/odp/api/spec/ipsec.h | 16 ++

[lng-odp] Next -> master point release differences

http://people.linaro.org/~mike.holmes/diff-abi/libodp-compat_report.html -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"

[lng-odp] [Bug 2782] LCOV: _odp_atomic_u64_cmp_xchg_strong_mm reported not tested

https://bugs.linaro.org/show_bug.cgi?id=2782 Mike Holmes changed: What|Removed |Added Resolution|--- |WONTFIX Status|CONFIRMED

[lng-odp] [API-NEXT PATCH] api: ipsec: packet transformation follows RFCs

Add explicit requirement that IPSEC in-/outbound operations transform packet headers according to the standards (RFCs). Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/include/odp/api/spec/ipse

[lng-odp] [Bug 2798] ODP random and other crypto functions (possibly) not thread safe?

https://bugs.linaro.org/show_bug.cgi?id=2798 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org --- Comment #4 from Mike

Re: [lng-odp] [API-NEXT PATCHv3 1/4] linux-gen: sched: solve ordered context inversion

Merged, Maxim. On 01/12/17 02:41, Bill Fischofer wrote: > For this series: > > Reviewed-and-tested-by: Bill Fischofer > > On Wed, Jan 11, 2017 at 1:50 AM, Yi He wrote: >> For ordered queue, a thread consumes events (dequeue) and >> acquires its unique sequential context in two steps, non >> at

[lng-odp] [Bug 2812] helper/test/process fails on a single core system

https://bugs.linaro.org/show_bug.cgi?id=2812 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [Bug 2814] Failure in classification test when run with --enable-debug

https://bugs.linaro.org/show_bug.cgi?id=2814 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org Resolution|---

Re: [lng-odp] [API-NEXT PATCHv3 3/4] linux-gen: add generic bitmaps and iterators

On 01/12/17 04:17, Yi He wrote: > Yes, ARRAY_SIZE is a kernel macro, I looked into the checkpatch.pl > and see no flag to enable/disable this check, > shall we comment it out or remove that piece of code? > > Best Regards, Yi yes, that warning is ok. Maxim. > > On 12 Ja

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

On Thu, Jan 12, 2017 at 6:58 AM, Bill Fischofer wrote: > On Thu, Jan 12, 2017 at 6:52 AM, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >>> >> > Huge performance degradation. Numbers are now many times worse than >>> >> before or after my optimizations. To me this shows that almost a >>> compl

[lng-odp] [API-NEXT PATCH 2/2] validation: ipsec: add test for odp_ipsec_capability()

Signed-off-by: Matias Elo --- test/common_plat/m4/configure.m4 | 1 + test/common_plat/validation/api/Makefile.am| 1 + test/common_plat/validation/api/ipsec/.gitignore | 1 + test/common_plat/validation/api/ipsec/Makefile.am | 10 + test/common_plat/validation

[lng-odp] [API-NEXT PATCH 1/2] linux-gen: ipsec: add capability function

Add IPsec capability function (groundwork for a proper IPsec implementation). Signed-off-by: Matias Elo --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/odp_ipsec.c | 16 2 files changed, 17 insertions(+) create mode 100644 platform/linux-generic/odp_ipsec.

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: remove erroneous assert

Merged, Maxim. On 01/12/17 15:27, Christophe Milard wrote: > On 12 January 2017 at 13:14, Bill Fischofer wrote: >> odp_packet_set_len() is only called from the classifier on paths for >> which a dummy header may be used. Rather than setting a dummy reference >> count to validate, it's simpler to

[lng-odp] [Bug 2814] Failure in classification test when run with --enable-debug

https://bugs.linaro.org/show_bug.cgi?id=2814 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever confirmed|0

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

On Thu, Jan 12, 2017 at 6:52 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> >> > Huge performance degradation. Numbers are now many times worse than >> >> before or after my optimizations. To me this shows that almost a >> complete >> >> rewrite (or revert) is needed. >> >> >> >> My guess is

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

> >> > Huge performance degradation. Numbers are now many times worse than > >> before or after my optimizations. To me this shows that almost a > complete > >> rewrite (or revert) is needed. > >> > >> My guess is this is due to the atomics needed for reference counting > >> not being properly inl

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

On Thu, Jan 12, 2017 at 6:27 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Thursday, January 12, 2017 2:22 PM >> To: Savolainen, Petri (Nokia - FI/Espoo) > labs.com> >> Cc: lng-odp@lists.linaro.

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, January 12, 2017 2:22 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: > implement

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: remove erroneous assert

On 12 January 2017 at 13:14, Bill Fischofer wrote: > odp_packet_set_len() is only called from the classifier on paths for > which a dummy header may be used. Rather than setting a dummy reference > count to validate, it's simpler to just delete the assert. This resolves > Bug https://bugs.linaro.o

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

On Thu, Jan 12, 2017 at 6:12 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > This patch is now merged, although I had some doubts that it has bad impact > on performance. Here are some performance results for couple of simple, > single thread packet alloc/free test cases. No references involve

Re: [lng-odp] API next SIGABRT on classification test?

OK. thanks for taking it from there :-) On 12 January 2017 at 13:15, Bill Fischofer wrote: > I just opened Bug https://bugs.linaro.org/show_bug.cgi?id=2814 for > this and posted a patch to fix it. Thanks. > > On Thu, Jan 12, 2017 at 6:13 AM, Christophe Milard > wrote: >> 22b3986 - Bill Fischof

Re: [lng-odp] API next SIGABRT on classification test?

I just opened Bug https://bugs.linaro.org/show_bug.cgi?id=2814 for this and posted a patch to fix it. Thanks. On Thu, Jan 12, 2017 at 6:13 AM, Christophe Milard wrote: > 22b3986 - Bill Fischofer : linux-generic: packet: implement reference > apis > > That is the one. > > No need to open a

[lng-odp] [API-NEXT PATCH] linux-generic: packet: remove erroneous assert

odp_packet_set_len() is only called from the classifier on paths for which a dummy header may be used. Rather than setting a dummy reference count to validate, it's simpler to just delete the assert. This resolves Bug https://bugs.linaro.org/show_bug.cgi?id=2814 Signed-off-by: Bill Fischofer ---

[lng-odp] [Bug 2494] Extend odp_pktio_capability_t to include minimal pool size required by pktio implementation.

https://bugs.linaro.org/show_bug.cgi?id=2494 --- Comment #14 from Bala Manoharan --- Further internal design discussions on how to avoid this scenario. If Maciej is fine this bug could be closed. -- You are receiving this mail because: You are on the CC list for the bug.

Re: [lng-odp] API next SIGABRT on classification test?

22b3986 - Bill Fischofer : linux-generic: packet: implement reference apis That is the one. No need to open a bug? On 12 January 2017 at 13:08, Bill Fischofer wrote: > On Thu, Jan 12, 2017 at 3:20 AM, Christophe Milard > wrote: >> Am I alone seeing that? > > You found a bug that only sur

[lng-odp] [Bug 2814] New: Failure in classification test when run with --enable-debug

https://bugs.linaro.org/show_bug.cgi?id=2814 Bug ID: 2814 Summary: Failure in classification test when run with --enable-debug Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

This patch is now merged, although I had some doubts that it has bad impact on performance. Here are some performance results for couple of simple, single thread packet alloc/free test cases. No references involved, just plain packets as before. Test results before and after "linux-generic: pac

Re: [lng-odp] API next SIGABRT on classification test?

On Thu, Jan 12, 2017 at 3:20 AM, Christophe Milard wrote: > Am I alone seeing that? You found a bug that only surfaces if you're running with --enable-debug. It's a one-line fix that I'll post shortly. Thanks. > > PASS: validation/api/pktio/pktio_run.sh > SKIP: validation/api/pktio/pktio_run_tap

Re: [lng-odp] API next SIGABRT on classification test?

Seems to be related to the usage of the "--enable-debug" option. Anyone building with it? e.g: ./bootstrap && ./configure --enable-debug --enable-test-vald && make -j 8 && make check Christophe. On 12 January 2017 at 10:20, Christophe Milard wrote: > Am I alone seeing that? > > PASS: valida

[lng-odp] [Bug 2812] New: helper/test/process fails on a single core system

https://bugs.linaro.org/show_bug.cgi?id=2812 Bug ID: 2812 Summary: helper/test/process fails on a single core system Product: OpenDataPlane - linux- generic reference Version: v1.12.0.0 Hardware: x86 OS: Linux Statu

[lng-odp] [API-NEXT PATCHv6 6/6] test: drv: shm: adding buddy allocation stress tests

Stress tests for the random size allocator (buddy allocator in linux-generic) are added here. Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 177 + .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files changed, 178 inse

[lng-odp] [API-NEXT PATCHv6 5/6] test: drv: shm: adding basic fixed size allocation tests

Basic tests for odpdrv_shm_pool are added here, creating a fixed size pool and performing basic alloc/free on it Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 86 ++ .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files

[lng-odp] [API-NEXT PATCHv6 4/6] test: drv: shm: adding basic buddy allocation tests

Basic tests for odpdrv_shm_pool are added here, creating a buddy pool and performing basic alloc/free on it Signed-off-by: Christophe Milard --- .../common_plat/validation/drv/drvshmem/drvshmem.c | 92 ++ .../common_plat/validation/drv/drvshmem/drvshmem.h | 1 + 2 files chan

[lng-odp] [API-NEXT PATCHv6 1/6] linux-gen: _ishm: adding buddy and slab allocation

_ishm now provides functions to create/destroy pools for buddy/slab memory allocation, as well as functions to allocated/release memory from the created pools. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 2 + platform/linux-generic/_ishm.c

[lng-odp] [API-NEXT PATCHv6 3/6] linux-gen: drv: shm: adding pool allocator

Adding functions to create memory pools and allocate / free memory from the created pools. These functions calls their _ishm conterpart, of course. Signed-off-by: Christophe Milard --- platform/linux-generic/drv_shm.c | 44 1 file changed, 44 insertions(+

[lng-odp] [API-NEXT PATCHv6 2/6] drv: adding odpdrv_shm_pool functions

Adding functions to create and destroy memory pools (from which memory can be allocated and freed) are added. These functions enable the usage of small memory amount (compared to drvshm_reserve() whose granularity is the page size). The usage of this pool guatantees that allocated memory is sharabl

[lng-odp] [API-NEXT PATCHv6 0/6] small memory amount allocator for drv shm

Since V5: -title fix (Yi) -rebased -flag name fix (Christophe) Since V4: -fix for clang Since V3: -copyright year changed Since V2: -comment and doxygen fixes (Petri) Since V1: -Common south pool (for all drivers) suppressed. (Petri) -function to create and destroy the pools exposed to

[lng-odp] API next SIGABRT on classification test?

Am I alone seeing that? PASS: validation/api/pktio/pktio_run.sh SKIP: validation/api/pktio/pktio_run_tap.sh PASS: validation/api/shmem/shmem_linux PASS: ../../test/common_plat/validation/api/atomic/atomic_main PASS: ../../test/common_plat/validation/api/barrier/barrier_main PASS: ../../test/common

[lng-odp] master release status

Hi, What's the status of upgrading master with latest api-next commits and tagging it? I can see that next branch is now at ... commit 23e7745272bd405483da737824af25e2e18c8b21 Author: Bill Fischofer Date: Tue Jan 10 09:59:40 2017 -0600 linux-generic: pool: defer ring allocation until poo

Re: [lng-odp] [API-NEXTv5 1/6] linux-gen: _ishm: adding buddy and slab allocation

On 12 January 2017 at 08:52, Yi He wrote: > Hi, Christophe, > > Q1: this patchset name seems a little problem: API-NEXTv5 -> API-NEXT > PATCHv5 oh god! Will fix in V6! > > Q2: the 1/6 patch cannot be applied to the api-next, I've tried to fix to > continue the test but did not work, need to re-