Re: [lng-odp] [PATCH] linux-gen: _ishm: checking fstat return value.

2017-01-21 Thread Bill Fischofer
Agree with Mike on adding the Bug to the commit log On Fri, Jan 20, 2017 at 9:53 AM, Mike Holmes wrote: > On 20 January 2017 at 11:40, Christophe Milard > wrote: >> Hence fixing CID 174663 > > Adding: > > Fixes

Re: [lng-odp] [PATCH] linux-gen: _ishm: fix normal page fallback

2017-01-21 Thread Bill Fischofer
This appears to be a bug fix. Bug fix patches should reference the bug being resolved in the commit log. I'm not sure I see this in bugzilla, so one should be opened for this. On Fri, Jan 20, 2017 at 3:19 AM, Christophe Milard wrote: > Fixing failure due to lack of

[lng-odp] [PATCH] travis: add netmap pktio tests

2017-01-21 Thread Maxim Uvarov
previusly we missed running tests under root, so we did not run pktio afpacket mmap and dpdk and tests based on veth. Netmap also requires root to bing up virtual interfaces. Signed-off-by: Maxim Uvarov --- This patch should go after Matias netmap update patches.

Re: [lng-odp] [API-NEXT PATCH 1/4] api: timer: add odp_timer_capability() api

2017-01-21 Thread Bill Fischofer
In general these look good, but still have some problems: 1. The are checkpatch formatting issues in parts 1, 2, and 3. Please run ./scripts/checkpatch on your patches before submitting and ensure that they are clean. 2. Each new revision of a patch should increment the version number. This one

Re: [lng-odp] [PATCH v2 1/8] abi: event: added the first ABI spec file

2017-01-21 Thread Bill Fischofer
On Fri, Jan 20, 2017 at 8:11 AM, Petri Savolainen wrote: > Used event API as the first example of an ABI spec file. Used > the same default architecture file initially for all > architectures. Default ABI files avoid multiple copies > of the same definition. > >