Re: [lng-odp] [PATCH] linux-gen: makefile: remove pass command

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Monday, February 20, 2017 5:43 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] linux-gen:

Re: [lng-odp] [API-NEXT PATCH 0/4] Packet references as copy

Based on recent discussions and plan to move forward, for this series: Reviewed-and-tested-by: Bill Fischofer On Mon, Feb 13, 2017 at 6:53 AM, Petri Savolainen < petri.savolai...@linaro.org> wrote: > Change packet references API specification to enable implementation

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

Hi, Comments below. Janne > -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Friday, February 17, 2017 10:39 PM > To: Peltonen, Janne (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp]

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: packet: avoid race condition in packet_free processing

Hi, I do not think this really fixes the problem. If we ignore memory ordering issues for now, I think this would fix the problem that unshared_len would be modified after the packet has been freed (since now the current thread keeps its own reference over the unshared_len modification).

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

I think proposed steps are: - revert Bills patch; - put implementation with copy to api-next, if it pass validation test then merge merge it to master; - then apply Bills patch again and later improvement patches to api-next; - write stress stress test for master which will appear in api-next

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

Fair enough. If Nokia would like to write the multi-threaded stress-test app to go with the benchmarking they are doing, I can restructure the implementation into a series of stages that are more easily "digested". What I don't want to have happen is this area get back-burnered with just a general

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

Thanks Petri, You accurately summarized what we said in arch call today. Bill, we'll cover the topic again on Wednesday. I have seen how it happened behind the scenes for DPDK: 1 year architectural discussion of implications (kind of background mode, coffee time), then little by little patch

Re: [lng-odp] [PATCHv2] configure: libatomic check

Hi, If these flags are required for compiling the examples, maybe, they should not be moved to the platform m4. But the problem is maybe more: Why do the examples (which are supposed to be compilable by all) requires this? So maybe this change is good, and will trigger the example question...

[lng-odp] [PATCH] linux-gen: makefile: remove pass command

pass is not bash command and can be not installed. Change it to dummy ":" bash function. Signed-off-by: Maxim Uvarov --- platform/linux-generic/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/Makefile.am

Re: [lng-odp] [PATCH] linux-gen: do not do double symlinks on make distcheck

On 02/20/17 18:17, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim >> Uvarov >> Sent: Saturday, February 18, 2017 9:13 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [PATCH]

Re: [lng-odp] [PATCH] linux-gen: do not do double symlinks on make distcheck

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Saturday, February 18, 2017 9:13 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] linux-gen: do not do double symlinks on make > distcheck > > Commit: >

Re: [lng-odp] Data corruption during TCP download

Good to hear you are making progress. I haven’t seen this problem in my test systems but I’m mainly using netmap and dpdk without virtual interfaces to access NIC queues directly skipping the kernel altogether. -Matias > On 20 Feb 2017, at 16:48, Oriol Arcas wrote:

Re: [lng-odp] [API-NEXT PATCHv7 2/5] linux-generic: packet: implement reference apis

Hi, We are already in the phase where code in master should be maintained for production quality. There is no hurry to merge in code that has questionable quality. Zero copy packet references is not a trivial feature to implement. We are in much better position to review, test and use the

Re: [lng-odp] Data corruption during TCP download

Small update: currently, we are having issues without ODP, just using the netmap example bridges. For kernel 4.1 it exhibits errors, for 4.9 it doesn't. We are trying to find a minimal working kernel. So our current hypothesis is that there is some kind of bug that appears under concurrent

Re: [lng-odp] [PATCH v3] validation: A wrapper script to run test isolated.

On 02/18/17 23:07, Ravineet Singh wrote: > Looks like you have cset shield active on the system, unclear to me why. > Could you just retry after a ' cset shield -r' , i.e. reset the shield. > root:17:22 /opt/Linaro/odp3.git (master)$cset shield -r cset: --> deactivating/reseting shielding cset:

[lng-odp] [Linaro/odp] 3d6cbd: linux-gen: do not do double symlinks on make distc...

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 3d6cbd2e2881c1e18922b26c7fd4a2ec9464becd https://github.com/Linaro/odp/commit/3d6cbd2e2881c1e18922b26c7fd4a2ec9464becd Author: Maxim Uvarov Date: 2017-02-20 (Mon, 20 Feb 2017)

Re: [lng-odp] [API-NEXT PATCH 1/2] api: pktio: add parser configuration

> > +/** > > * Packet IO configuration options > > * > > * Packet IO interface level configuration options. Use > odp_pktio_capability() > > @@ -363,6 +396,9 @@ typedef struct odp_pktio_config_t { > > * Default value for all bits is zero. */ > > odp_pktout_config_opt_t

Re: [lng-odp] Data corruption during TCP download

version from .travis file. On 20 February 2017 at 13:05, Oriol Arcas wrote: > Hi, > > Thank you for your feedback Matias and Maxim, we really appreciate it. > > We are trying netmap, but sometimes it doesn't solve the problem. Could > you share what versions (ODP,

Re: [lng-odp] Data corruption during TCP download

Hi, Thank you for your feedback Matias and Maxim, we really appreciate it. We are trying netmap, but sometimes it doesn't solve the problem. Could you share what versions (ODP, netmap, Linux) are you using and are working fine? This would help us having a control group for our tests... -- Oriol