Re: [lng-odp] [API-NEXT PATCH 4/4] validation: crypto: add stubs for sha-1 and sha-512 tests

> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Wednesday, February 22, 2017 6:37 PM > To: Petri Savolainen ; lng- > o...@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 4/4] validation:

[lng-odp] odp_buffer_t usage

Hi I was looking into odp_buffer_t to understand its use case from Application stand point. While it is clear for odp_packet_t description that it can be segmented/non-segmented contiguous / non-contiguous memory and APIs are provided to query and hop across segments to access data, but It is

Re: [lng-odp] [API-NEXT PATCHv4 2/4] linux-generic: timer: implement odp_timer_capability()

Hi Petri, Any more comments? I suggest we should push this patchset firstly. If we have any new requirements, we can create a new ticket to trace it. What's your thought? 2017-02-20 10:37 GMT+08:00 Kevin Wang : > We don't know how many threads/locks the application will

Re: [lng-odp] [API-NEXT PATCH 00/21] driver items registration and probing

This series compiles and runs/tests fine using gcc and clang on both 64 and 32 bit systems. Many comments, mostly cosmetic, however some missing field initializations are noted as well as some suggestions for handling type conversions. On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard <

Re: [lng-odp] [API-NEXT PATCH 17/21] linux-gen: driver registration and probing

On Wed, Feb 22, 2017 at 6:56 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Driver registration and probing is implemented for linux-gen ODP. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/drv_driver.c | 348

Re: [lng-odp] [API-NEXT PATCH 16/21] drv: complement parameters to the driver probe() function

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Of course, when probing a driver, the latter should be given the devio > handle to be used. This is what this patch adds. It also adds the index > of the devio, hence telling the driver which of the

Re: [lng-odp] [API-NEXT PATCH 15/21] drv: adding driver remove function

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > The remove function, as for other driver items (such as enumeratos...) is > Typo: enumerators > called before the driver is to be removed, i.e. after all devices have been > been unboud from the driver.

Re: [lng-odp] [API-NEXT PATCH 13/21] linux-gen: drv: devio registration

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > devios (dev IO) provide a interface for drivers to access a device: > Devices enumerated by enumerators may be accessed in by different > mechanisms (depending on iommu presence or other factors). This

Re: [lng-odp] [API-NEXT PATCH 10/21] linux-gen: drv: driver: adding device querry function

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Implementation of the device query function for the linux-gen ODP. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/drv_driver.c | 37

Re: [lng-odp] [API-NEXT PATCH 08/21] linux-gen: drv: device creation and deletion

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Functions to create and remove devices are populated to do > more proper things. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/drv_driver.c | 172

Re: [lng-odp] [API-NEXT PATCH 07/21] drv: driver: add callback function for device destruction

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > When a device is destroyed by an enumerator, odpdrv_device_destroy() is > called. > However, the complete device destruction may require waiting for IO to be > completed: the device destruction is

Re: [lng-odp] [API-NEXT PATCH 06/21] drv: driver: change drv unbind function name and pass correct parameter

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > The driver removal function expects a device, of course... > Also unbind seems a better name to disconnect from a device > since remove has been used for removing the object itself for > enumerators. >

Re: [lng-odp] [API-NEXT PATCH 05/21] test: drv: enumerator registration tests

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > making sure that enumerators are probed. > > Signed-off-by: Christophe Milard > --- > .../validation/drv/drvdriver/.gitignore| 1 + >

Re: [lng-odp] [API-NEXT PATCH 04/21] linux-gen: drv: enumerator registration

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > The enumerator registration functions for the linux-gen ODP implementation. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/drv_driver.c | 135

[lng-odp] [Linaro/odp] d56c77: linux-gen: fix odp_schedule.m4

Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: d56c7755dce115f3c1692fa358e58b1b46cf2234 https://github.com/Linaro/odp/commit/d56c7755dce115f3c1692fa358e58b1b46cf2234 Author: Yi He Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths:

[lng-odp] [Linaro/odp] 724db2: linux-generic: cosmetic changes on byteorder files

Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: 724db2bdabcafb5438fe02d01e8f4b60a1ab37e1 https://github.com/Linaro/odp/commit/724db2bdabcafb5438fe02d01e8f4b60a1ab37e1 Author: Christophe Milard Date: 2017-02-23 (Thu, 23 Feb

[lng-odp] [Linaro/odp] ca58e1: doc: userguide: add section on application portabi...

Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: ca58e1a62911ed25abddf2a899a1bee678f6d305 https://github.com/Linaro/odp/commit/ca58e1a62911ed25abddf2a899a1bee678f6d305 Author: Bill Fischofer Date: 2017-02-23 (Thu, 23 Feb 2017)

[lng-odp] [Linaro/odp] a19875: doc: userguide: add user documentation for packet ...

Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: a19875674436996ec38e83371fb0a91427dfe3e0 https://github.com/Linaro/odp/commit/a19875674436996ec38e83371fb0a91427dfe3e0 Author: Bill Fischofer Date: 2017-02-23 (Thu, 23 Feb 2017)

Re: [lng-odp] [API-NEXT PATCH 03/21] test: drv: enumerator_class registration tests

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Testing that enumerators classes can register properly. > Saddly restricted to statically linked enumerators classes, as testing with > modules in autotools seems to be an issue so far. > > Signed-off-by:

[lng-odp] [Linaro/odp] 63a39f: codecov: lower expectations from codecov

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 63a39fabe4924d142d2df041d817f732eb4fdafb https://github.com/Linaro/odp/commit/63a39fabe4924d142d2df041d817f732eb4fdafb Author: Maxim Uvarov Date: 2017-02-22 (Wed, 22 Feb 2017)

[lng-odp] [Linaro/odp] 31498a: linux-gen: sched: solve ordered context inversion

Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: 31498a7a8bd19de593f6b862cb39d484b99c9bf8 https://github.com/Linaro/odp/commit/31498a7a8bd19de593f6b862cb39d484b99c9bf8 Author: Yi He Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths:

Re: [lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > The functions to register and probe enumerator classes are added. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/Makefile.am | 1 + >

[lng-odp] [Linaro/odp] 53d71e: linux-gen: sched: fix SP scheduler hang in process...

Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: 53d71e1a9e543e8da738fbf4b9d028e750939147 https://github.com/Linaro/odp/commit/53d71e1a9e543e8da738fbf4b9d028e750939147 Author: Yi He Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths:

[lng-odp] [Linaro/odp] 5cd91a: api: packet: add support for packet references

Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: 5cd91a6e3bf76edc0045bc379dd18fa75f65ccd2 https://github.com/Linaro/odp/commit/5cd91a6e3bf76edc0045bc379dd18fa75f65ccd2 Author: Petri Savolainen Date: 2017-02-22 (Wed, 22 Feb 2017)

[lng-odp] [Linaro/odp]

Branch: refs/heads/next Home: https://github.com/Linaro/odp

Re: [lng-odp] Data corruption during TCP download

On Tue, Feb 21, 2017 at 6:50 PM, Bill Fischofer wrote: > > > On Tue, Feb 21, 2017 at 11:35 AM, Oriol Arcas > wrote: > >> Hi, >> >> We have observed the problem with ODP and/or Netmap, with kernels 3.16, >> 4.1, 4.4 and 4.9. In this sense,

Re: [lng-odp] [API-NEXT PATCH 4/4] validation: crypto: add stubs for sha-1 and sha-512 tests

On 22.02.2017 18:08, Petri Savolainen wrote: > API enumerations are tested but functional tests are missing still. If nobody steps up, I will take a look onto implementing funcionality and tests. I have several issues with the current code anyway. > > Signed-off-by: Petri Savolainen

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: packet: avoid race condition in packet_free processing

Thanks. I've revamped the whole approach to dealing with unshared_len so that this variable is only updated by the owner of the odp_packet_t that contains it. This should be faster in non-reference paths and should also eliminate all race conditions since no two threads can own the same

[lng-odp] [API-NEXT PATCH 4/4] validation: crypto: add stubs for sha-1 and sha-512 tests

API enumerations are tested but functional tests are missing still. Signed-off-by: Petri Savolainen --- test/common_plat/validation/api/crypto/crypto.h| 2 ++ .../validation/api/crypto/odp_crypto_test_inp.c| 32 ++ 2 files changed, 34

[lng-odp] [API-NEXT PATCH 2/4] api: crypto: add sha-1 and sha-512 enumerations

Added enumerations for HMAC-SHA-1 and HMAC-SHA-256 authentication algorithms. Signed-off-by: Petri Savolainen --- include/odp/api/spec/crypto.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/odp/api/spec/crypto.h

[lng-odp] [API-NEXT PATCH 1/4] abi: event: add ODP_EVENT_IPSEC_RESULT

Update ABI spec with the new IPSEC event type. Signed-off-by: Petri Savolainen Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/arch/default/api/abi/event.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[lng-odp] [API-NEXT PATCH 3/4] linux-gen: crypto: sha-1 and sha-512 not implemented yet

Explicitly set capabilities to zero. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index b53b0fc..fcbabd1

[lng-odp] [API-NEXT PATCH 0/4] Add sha-1 and sha-512

Add new algorithm enumerations so that vendor IPSEC implementations and IPSEC test applications can proceed. Odp-linux crypto implementation and validation tests follow later. Petri Savolainen (4): abi: event: add ODP_EVENT_IPSEC_RESULT api: crypto: add sha-1 and sha-512 enumerations

[lng-odp] [Linaro/odp] 63a39f: codecov: lower expectations from codecov

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 63a39fabe4924d142d2df041d817f732eb4fdafb https://github.com/Linaro/odp/commit/63a39fabe4924d142d2df041d817f732eb4fdafb Author: Maxim Uvarov Date: 2017-02-22 (Wed, 22 Feb 2017)

Re: [lng-odp] [PATCH] codecov: lower expectations from codecov

Ok, thanks. I agree. We can adjust after we complete the move to GitHub. Reviewed-by: Bill Fischofer On Wed, Feb 22, 2017 at 2:02 AM, Maxim Uvarov wrote: > > > On 22 February 2017 at 00:32, Bill Fischofer > wrote:

[lng-odp] [API-NEXT PATCH 21/21] test: drv: test for setting and retrieving driver's data

trivial tests for function odpdrv_device_set_data() and odpdrv_device_get_data(). Signed-off-by: Christophe Milard --- test/common_plat/validation/drv/drvdriver/drvdriver_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH 19/21] drv: driver: adding functions to attach driver's data to the device

Driver will need to attach their data to devices when bound. The patch introduce a data setter and a data getter function to do so. Signed-off-by: Christophe Milard --- include/odp/drv/spec/driver.h | 21 + 1 file changed, 21 insertions(+) diff

[lng-odp] [API-NEXT PATCH 18/21] test: drv: driver registration and probing

Register driver, devios, enumerators, create devices, and check that probing occurs correctely. Signed-off-by: Christophe Milard --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 +

[lng-odp] [API-NEXT PATCH 17/21] linux-gen: driver registration and probing

Driver registration and probing is implemented for linux-gen ODP. Signed-off-by: Christophe Milard --- platform/linux-generic/drv_driver.c | 348 ++-- 1 file changed, 335 insertions(+), 13 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH 13/21] linux-gen: drv: devio registration

devios (dev IO) provide a interface for drivers to access a device: Devices enumerated by enumerators may be accessed in by different mechanisms (depending on iommu presence or other factors). This extra abstraction is provided by devios, which provide a sets of methods to access the devices of a

[lng-odp] [API-NEXT PATCH 15/21] drv: adding driver remove function

The remove function, as for other driver items (such as enumeratos...) is called before the driver is to be removed, i.e. after all devices have been been unboud from the driver. remove() should release any resource held by the driver. Signed-off-by: Christophe Milard

[lng-odp] [API-NEXT PATCH 12/21] drv: driver: adding a probe and remove callback for devio

Needed to delete the resources needed for the devio. That is possibly the memory allocated for its "ops" part if it was allocated. May be NULL if nothing needs to be done at devio deletion time. Signed-off-by: Christophe Milard --- include/odp/drv/spec/driver.h |

[lng-odp] [API-NEXT PATCH 11/21] test: drv: device creation and destruction

Testing that devices can be created and removed from ODP. Signed-off-by: Christophe Milard --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 ++ .../validation/drv/drvdriver/drvdriver_device.c

[lng-odp] [API-NEXT PATCH 10/21] linux-gen: drv: driver: adding device querry function

Implementation of the device query function for the linux-gen ODP. Signed-off-by: Christophe Milard --- platform/linux-generic/drv_driver.c | 37 + 1 file changed, 37 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH 08/21] linux-gen: drv: device creation and deletion

Functions to create and remove devices are populated to do more proper things. Signed-off-by: Christophe Milard --- platform/linux-generic/drv_driver.c | 172 ++-- 1 file changed, 164 insertions(+), 8 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH 09/21] drv: driver: adding device query function

Adding a function for querying a list of devices: this function may be used by enumerators to query for the list of their registered devices or for a subset of them. Note that this function returns a malloc'd list of devices which is to be freed by the caller. Signed-off-by: Christophe Milard

[lng-odp] [API-NEXT PATCH 05/21] test: drv: enumerator registration tests

making sure that enumerators are probed. Signed-off-by: Christophe Milard --- .../validation/drv/drvdriver/.gitignore| 1 + .../validation/drv/drvdriver/Makefile.am | 11 + .../validation/drv/drvdriver/drvdriver_enumr.c | 303

[lng-odp] [API-NEXT PATCH 07/21] drv: driver: add callback function for device destruction

When a device is destroyed by an enumerator, odpdrv_device_destroy() is called. However, the complete device destruction may require waiting for IO to be completed: the device destruction is therefore divided in 2 steps: odpdrv_device_destroy() starts the device destruction, and the provided

[lng-odp] [API-NEXT PATCH 06/21] drv: driver: change drv unbind function name and pass correct parameter

The driver removal function expects a device, of course... Also unbind seems a better name to disconnect from a device since remove has been used for removing the object itself for enumerators. Some extra parameters to allow for graceful unbinding are also added. Signed-off-by: Christophe Milard

[lng-odp] [API-NEXT PATCH 04/21] linux-gen: drv: enumerator registration

The enumerator registration functions for the linux-gen ODP implementation. Signed-off-by: Christophe Milard --- platform/linux-generic/drv_driver.c | 135 +++- 1 file changed, 132 insertions(+), 3 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH 03/21] test: drv: enumerator_class registration tests

Testing that enumerators classes can register properly. Saddly restricted to statically linked enumerators classes, as testing with modules in autotools seems to be an issue so far. Signed-off-by: Christophe Milard --- test/common_plat/m4/configure.m4

[lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

The functions to register and probe enumerator classes are added. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/_modules.c | 4 + platform/linux-generic/drv_driver.c

[lng-odp] [API-NEXT PATCH 01/21] drv: making parameter strings dynamically computable

Declaring strings as const in the driver API prevents dynamic calculation of these strings, which is a drawback. For instance, the device addresses (string) are typically calculated by enumerators, and should therefore not be const... Other strings may also be the result of a computation. This

[lng-odp] [API-NEXT PATCH 00/21] driver items registration and probing

This patch series implements the driver interface, i.e. enumerator class, enumerator, devio and drivers registration and probing. This interface is depicted in: https://docs.google.com/document/d/1eCKPJF6uSlOllXi_sKDvRwUD2BXm-ZzxZoKT0nVEsl4/edit The associated tests are testing these mechanisms.

Re: [lng-odp] [PATCH 4/4] api: crypto: add definitions for SHA-1 HMAC authentication

From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Wednesday, February 22, 2017 10:05 AM To: Bill Fischofer Cc: Dmitry Eremin-Solenikov ; Petri Savolainen ; lng-odp-forward

Re: [lng-odp] [PATCHv2] example:ipsec_offload: Adding ipsec_offload example

please do not define internal defines with ODP_ prefixes. We use that prefixes for API calls. Maxim. On 22 February 2017 at 15:27, Nikhil Agarwal wrote: > Signed-off-by: Nikhil Agarwal > --- > example/Makefile.am

Re: [lng-odp] [PATCH 4/4] api: crypto: add definitions for SHA-1 HMAC authentication

patch prefix has to be API-NEXT also. Maxim. On 22 February 2017 at 02:46, Bill Fischofer wrote: > API change needs Petri's review. > > On Tue, Feb 21, 2017 at 4:41 PM, Dmitry Eremin-Solenikov < > dmitry.ereminsoleni...@linaro.org> wrote: > > > Signed-off-by: Dmitry

Re: [lng-odp] [PATCH] codecov: lower expectations from codecov

On 22 February 2017 at 00:32, Bill Fischofer wrote: > > On Tue, Feb 21, 2017 at 3:09 PM, Maxim Uvarov > wrote: > >> On main page for each commit Codecov does tests. This >> patch lowers expectations for 'codecov/project' to make >> it pass and