[lng-odp] Linking problem with --disable-abi-compat

2017-03-08 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, I have hard time getting the following fine ODP application linked against the shared ODP library when ODP has been configured with --disable-abi-compat. It seems to me that the problem is in the 'local' binding of the _odp_packet_inline symbol in the .so, caused by the -fvisibility=hidden

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Dmitry Eremin-Solenikov
On 08.03.2017 17:13, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Are you saying that in your shell this works (echoes foobar): > if false ; then : else echo foobar ; fi Does not work here (bash 4.4.11(1)-release). -- With best wishes Dmitry

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Peltonen, Janne (Nokia - FI/Espoo)
> > install-data-hook: > > if [ -h $(prefix)/include/odp/api/abi ]; then \ > > - : \ > > + : ; \ > > else \ > > $(LN_S) -rf $(prefix)/include/odp/arch/@ARCH_ABI@/odp/api/abi \ > > $(prefix)/include/odp/api/abi; \ > > Which bash are you

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Dmitry Eremin-Solenikov
On 08.03.2017 16:57, Maxim Uvarov wrote: > On 03/08/2017 04:47 PM, Dmitry Eremin-Solenikov wrote: >> On 08.03.2017 16:44, Maxim Uvarov wrote: >>> On 03/07/2017 12:16 PM, Janne Peltonen wrote: Fix the ABI symlink creation that went broken in 3d6cbd2. Signed-off-by: Janne Peltonen

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Maxim Uvarov
On 03/08/2017 04:47 PM, Dmitry Eremin-Solenikov wrote: On 08.03.2017 16:44, Maxim Uvarov wrote: On 03/07/2017 12:16 PM, Janne Peltonen wrote: Fix the ABI symlink creation that went broken in 3d6cbd2. Signed-off-by: Janne Peltonen ---

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Dmitry Eremin-Solenikov
On 08.03.2017 16:44, Maxim Uvarov wrote: > On 03/07/2017 12:16 PM, Janne Peltonen wrote: >> Fix the ABI symlink creation that went broken in 3d6cbd2. >> >> Signed-off-by: Janne Peltonen >> --- >> platform/linux-generic/Makefile.am | 2 +- >> 1 file changed, 1

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

2017-03-08 Thread Maxim Uvarov
On 03/07/2017 12:16 PM, Janne Peltonen wrote: Fix the ABI symlink creation that went broken in 3d6cbd2. Signed-off-by: Janne Peltonen --- platform/linux-generic/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [lng-odp] [PATCHv2] example:ipsec_offload: Adding ipsec_offload example

2017-03-08 Thread Dmitry Eremin-Solenikov
Let's get some final changes, so that we can hopefully merge this patch On 22.02.2017 15:27, Nikhil Agarwal wrote: > Signed-off-by: Nikhil Agarwal > --- [skipped] > + /* Read the source MAC address for this interface */ > + ret = odp_pktio_mac_addr(pktio,

[lng-odp] [API-NEXT 5/8] linux-generic: crypto: unify auth code

2017-03-08 Thread Dmitry Eremin-Solenikov
Authentication code contains similar functions. Instead of replicating them further (e.g. for SHA-1 or SHA-3) factor out common code blocks, moving all difference to session data. Signed-off-by: Dmitry Eremin-Solenikov ---

[lng-odp] [API-NEXT 8/8] linux-generic: crypto: add HMAC-SHA-512 authentication support

2017-03-08 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index ef79d6f6..0f2a227f

[lng-odp] [API-NEXT 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

2017-03-08 Thread Dmitry Eremin-Solenikov
Switch AES-CBC and 3DES-CBC to use generic (EVP) interface instad of low level interface (as recommended by OpenSSL documentation). This allows to use the same code path for all non-AEAD ciphers. The only AEAD cipher (AES-GCM) already uses EVP interface. Generalization of that code can happen if

[lng-odp] [API-NEXT 7/8] linux-generic: crypto: add SHA-1 authentication support

2017-03-08 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 5078a3b1..ef79d6f6

[lng-odp] [API-NEXT 4/8] validation: crypto: add HMAC-SHA-512 test cases

2017-03-08 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- .../validation/api/crypto/odp_crypto_test_inp.c| 97 +- .../validation/api/crypto/test_vectors.h | 50 +++ .../validation/api/crypto/test_vectors_len.h | 6 ++ 3 files

[lng-odp] [API-NEXT 2/8] validation: crypto: correct comment for HMAC-SHA-256 tests

2017-03-08 Thread Dmitry Eremin-Solenikov
Comment for HMAC-SHA-256 tests talks about HMAC-MD5 and respective lengths. Correct it to mention SHA-256 and proper digest lengths. Signed-off-by: Dmitry Eremin-Solenikov --- test/common_plat/validation/api/crypto/odp_crypto_test_inp.c | 4 ++-- 1 file

[lng-odp] [API-NEXT 1/8] validation: crypto: add tests for checking message digests

2017-03-08 Thread Dmitry Eremin-Solenikov
Currently ODP testsuite only verifies generation of digests. Let's also verify that checking the digest actually works. Test that check function will accept valid digest and that it will reject wrong digests. Signed-off-by: Dmitry Eremin-Solenikov ---

[lng-odp] [API-NEXT 0/8] crypto rework and support for SHA-1/-512

2017-03-08 Thread Dmitry Eremin-Solenikov
This patchset concentrates on updating crypto framework in linux-generic: - merge auth code to use common code paths for all HMAC auth algos; - rework cipher code to use EVP API and common code for non-AEAD cipher algos; - implement HMAC-SHA-1 and HMAC-SHA-512 auth algos. This patchset targets