[lng-odp] [PATCH 4/4] linux-generic: crypto: switch to EVP interface for cipher algorithms

Switch AES-CBC and 3DES-CBC to use generic (EVP) interface instad of low level interface (as recommended by OpenSSL documentation). This allows to use the same code path for all non-AEAD ciphers. The only AEAD cipher (AES-GCM) already uses EVP interface. Generalization of that code can happen if

[lng-odp] [PATCH 3/4] linux-generic: crypto: unify auth code

Authentication code contains similar functions. Instead of replicating them further (e.g. for SHA-1 or SHA-3) factor out common code blocks, moving all difference to session data. Signed-off-by: Dmitry Eremin-Solenikov ---

[lng-odp] [PATCH 2/4] validation: crypto: correct comment for HMAC-SHA-256 tests

Comment for HMAC-SHA-256 tests talks about HMAC-MD5 and respective lengths. Correct it to mention SHA-256 and proper digest lengths. Signed-off-by: Dmitry Eremin-Solenikov --- test/common_plat/validation/api/crypto/odp_crypto_test_inp.c | 4 ++-- 1 file

[lng-odp] [PATCH 1/4] validation: crypto: add tests for checking message digests

Currently ODP testsuite only verifies generation of digests. Let's also verify that checking the digest actually works. Test that check function will accept valid digest and that it will reject wrong digests. Signed-off-by: Dmitry Eremin-Solenikov ---

[lng-odp] [PATCH 0/4] crypto: rework implementation of encryption and auth code

This is a copy of patchset at https://github.com/Linaro/odp/pull/11 . The main goal of this patchset is to ease adding encryption and authentication algorithms in future. Instead of using algorithm-specific OpenSSL API this patchset switches odp_crypto.c to use generic EVP_* API for both enc/dec

Re: [lng-odp] [PATCH v4] linux-generic: crypto: properly handle errors in packet copy

Reviewed-by: Balasubramanian Manoharan > On 25-Apr-2017, at 4:56 AM, Bill Fischofer wrote: > > On Mon, Apr 24, 2017 at 9:46 AM, Dmitry Eremin-Solenikov < > dmitry.ereminsoleni...@linaro.org> wrote: > >> Add proper handling for errors

Re: [lng-odp] [PATCH v4] linux-generic: crypto: properly handle errors in packet copy

On Mon, Apr 24, 2017 at 9:46 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > Add proper handling for errors returned by odp_packet_copy_from_pkt(). > > Signed-off-by: Dmitry Eremin-Solenikov > Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCH] test: odp_sched_latency: robust draining of queues

On Mon, Apr 24, 2017 at 5:26 PM, Ola Liljedahl wrote: > (Responding from PoC Outlook) > > From: Bill Fischofer > Date: Tuesday, 25 April 2017 at 00:00 > To: Brian Brooks > Cc: lng-odp-forward

Re: [lng-odp] [PATCH] test: odp_sched_latency: robust draining of queues

(Responding from PoC Outlook) From: Bill Fischofer Date: Tuesday, 25 April 2017 at 00:00 To: Brian Brooks Cc: lng-odp-forward , Ola Liljedahl Subject: Re: [lng-odp] [PATCH] test:

Re: [lng-odp] [PATCH] test: odp_sched_latency: robust draining of queues

On Mon, Apr 24, 2017 at 3:58 PM, Brian Brooks wrote: > From: Ola Liljedahl > > In order to robustly drain all queues when the benchmark has > ended, we enqueue a special event on every queue and invoke > the scheduler until all such events have been

Re: [lng-odp] [PATCHv2] bug: linux-generic: add syntax to allow newer clang to compile odp

Ping. Needs review to enable clang usage under Ubuntu 17.04. On Fri, Apr 21, 2017 at 3:03 PM, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2942 by adding > casts needed to avoid compilation failures when using clang 4.0.0 > included in

[lng-odp] [PATCH] test: odp_sched_latency: robust draining of queues

From: Ola Liljedahl In order to robustly drain all queues when the benchmark has ended, we enqueue a special event on every queue and invoke the scheduler until all such events have been received. Signed-off-by: Ola Liljedahl Reviewed-by: Brian

Re: [lng-odp] [API-NEXT PATCH v2 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

On Mon, Apr 24, 2017 at 2:36 PM, Maxim Uvarov wrote: > ERROR: Macros with complex values should be enclosed in parentheses > #239: FILE: platform/linux-generic/arch/x86/cpu_flags.c:172: > +#define FEAT_DEF(name, leaf, subleaf, reg, bit) \ > + [RTE_CPUFLAG_##name] =

Re: [lng-odp] [API-NEXT PATCH v2 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

ERROR: Macros with complex values should be enclosed in parentheses #239: FILE: platform/linux-generic/arch/x86/cpu_flags.c:172: +#define FEAT_DEF(name, leaf, subleaf, reg, bit) \ + [RTE_CPUFLAG_##name] = {leaf, subleaf, reg, bit, #name }, CHECK: architecture specific defines should be

Re: [lng-odp] [PATCH] test: tm: use script instead of binary when calling traffic manager test

That was merged, Maxim. On 20.04.2017 19:09, Bill Fischofer wrote: > On Wed, Apr 19, 2017 at 7:00 PM, Github ODP bot wrote: > >> From: Dmitry Eremin-Solenikov >> >> Since 51e3b8776b78180741fa57a621f9d13b9ae8bbfb tm test received wrapper >>

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #13 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/758bec9d721e3cba97d1a8abbe252f4abbd1e2d9 2017-04-24T16:39:02+03:00 Bill Fischofer bill.fischo...@linaro.org linux-generic: types: add additional

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #14 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/9393c7ab63c79de0037e0b63443107c0f5462654 2017-04-24T16:39:08+03:00 Bill Fischofer bill.fischo...@linaro.org helper: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #12 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/492973829259043135528e2313a8012412e09a3b 2017-04-24T16:38:56+03:00 Bill Fischofer bill.fischo...@linaro.org api: tm: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #11 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/432ff281b9c9b534f413cdd78b8c616fff310878 2017-04-24T16:38:50+03:00 Bill Fischofer bill.fischo...@linaro.org api: pool: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #10 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/2da3adc6e475a336ddb81bf4bdb495f039dca9a9 2017-04-24T16:38:43+03:00 Bill Fischofer bill.fischo...@linaro.org api: ipsec: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #9 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/c29707f5604dd365412fd6c39987c9956590447b 2017-04-24T16:38:25+03:00 Bill Fischofer bill.fischo...@linaro.org api: classification: add additional doxygen

[lng-odp] [Linaro/odp] c29707: api: classification: add additional doxygen docume...

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: c29707f5604dd365412fd6c39987c9956590447b https://github.com/Linaro/odp/commit/c29707f5604dd365412fd6c39987c9956590447b Author: Bill Fischofer Date: 2017-04-24 (Mon, 24 Apr 2017)

Re: [lng-odp] [API-NEXT PATCH v2 0/8] Use HW time counter

For this series: Reviewed-and-tested-by: Bill Fischofer On Mon, Apr 24, 2017 at 5:49 AM, Petri Savolainen < petri.savolai...@linaro.org> wrote: > This patch set modifies time implementation to use TSC when running on a > x86 > CPU that has invarint TSC CPU flag set.

[lng-odp] [PATCH v4] linux-generic: crypto: properly handle errors in packet copy

Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #8 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/9393c7ab63c79de0037e0b63443107c0f5462654 2017-04-24T16:39:08+03:00 Bill Fischofer bill.fischo...@linaro.org helper: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #7 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/758bec9d721e3cba97d1a8abbe252f4abbd1e2d9 2017-04-24T16:39:02+03:00 Bill Fischofer bill.fischo...@linaro.org linux-generic: types: add additional

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #6 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/492973829259043135528e2313a8012412e09a3b 2017-04-24T16:38:56+03:00 Bill Fischofer bill.fischo...@linaro.org api: tm: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #5 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/432ff281b9c9b534f413cdd78b8c616fff310878 2017-04-24T16:38:50+03:00 Bill Fischofer bill.fischo...@linaro.org api: pool: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #4 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/2da3adc6e475a336ddb81bf4bdb495f039dca9a9 2017-04-24T16:38:43+03:00 Bill Fischofer bill.fischo...@linaro.org api: ipsec: add additional doxygen

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #3 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/c29707f5604dd365412fd6c39987c9956590447b 2017-04-24T16:38:25+03:00 Bill Fischofer bill.fischo...@linaro.org api: classification: add additional doxygen

Re: [lng-odp] [API-NEXT PATCH 3/8] linux-gen: system: implement system info print

On 24.04.2017 10:06, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> + >>> +void odp_sys_info_print(void) >>> +{ >>> + printf("\n" >>> + "ODP system info\n" >>> + "---\n" >>> + "ODP API version: %s\n" >>> + "ODP impl name:

[lng-odp] [Linaro/odp] f28f05: api: ipsec: factor out definitions for feature sup...

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: f28f05a4df320c6a7ba8be858bdc3d8d6b91c0b2 https://github.com/Linaro/odp/commit/f28f05a4df320c6a7ba8be858bdc3d8d6b91c0b2 Author: Dmitry Eremin-Solenikov Date: 2017-04-24

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

Hi, > > There is connected interesting question, which should be though wrt. all > 'packet-consuming' functions. Should such functions always consume and > free incoming packet? IOW: > > - odp_crypto_operation() returned -1. Should the app free inbound > packet afterwards? The API spec is not

Re: [lng-odp] [API-NEXT v5] api: ipsec: factor out definitions for feature support levels

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Dmitry Eremin-Solenikov > Sent: Wednesday, April 19, 2017 4:41 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT v5]

Re: [lng-odp] [API-NEXT PATCHv3 1/6] api: classification: add additional doxygen documentation

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Friday, April 21, 2017 5:25 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv3 1/6] api:

Re: [lng-odp] [PATCH 3/3] linux-gen: sched: optimize group scheduling

Ping. > -Original Message- > From: Wallen, Carl (Nokia - FI/Espoo) > Sent: Thursday, April 20, 2017 3:11 PM > To: lng-odp@lists.linaro.org > Cc: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Subject: RE: [lng-odp] [PATCH 3/3] linux-gen: sched: optimize

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

Ping. Review needed. Are we ready to merge? This should work fine with distros as explained two weeks ago. -Petri > -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, April 13, 2017 6:02 PM > To: Savolainen, Petri (Nokia - FI/Espoo)

[lng-odp] [API-NEXT PATCH v2 8/8] linux-gen: time: use hw time counter when available

Use 64 bit HW time counter when available. It is used on x86 when invariant TSC CPU flag indicates that TSC frequency is constant. Otherwise, the system time is used as before. Direct HW time counter usage avoids system call, and related latency and performance issues. Signed-off-by: Petri

[lng-odp] [API-NEXT PATCH v2 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

When building on x86 CPU flags can be used to determine which CPU features are supported. CPU flag definitions and the code to read the flags is from DPDK. Signed-off-by: Petri Savolainen --- configure.ac| 1 + platform/Makefile.inc

[lng-odp] [API-NEXT PATCH v2 3/8] linux-gen: system: implement system info print

Print API, impl name, CPU model/freq, cache line size and CPU count by default. Print CPU flags in case of x86. Signed-off-by: Petri Savolainen --- .../linux-generic/arch/arm/odp_sysinfo_parse.c | 4 +++ .../linux-generic/arch/default/odp_sysinfo_parse.c | 4

[lng-odp] [API-NEXT PATCH v2 7/8] test: validation: add time accuracy test

Test ODP time keeping accuracy against system time. Signed-off-by: Petri Savolainen --- test/common_plat/validation/api/time/time.c | 72 +++-- 1 file changed, 57 insertions(+), 15 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v2 0/8] Use HW time counter

This patch set modifies time implementation to use TSC when running on a x86 CPU that has invarint TSC CPU flag set. Otherwise, the same Linux system time is used as before. TSC is much more efficient both in performance and latency/jitter wise than Linux system call. This can be seen also with

[lng-odp] [API-NEXT PATCH v2 6/8] test: validation: rename time test header file

Header file name time.h is ambiguos since C has a library header file with the same name. Signed-off-by: Petri Savolainen --- test/common_plat/validation/api/time/Makefile.am | 2 +- test/common_plat/validation/api/time/time.c | 2 +-

[lng-odp] [API-NEXT PATCH v2 5/8] test: sched_latency: use sys_info_print

Use the new system info print function. Signed-off-by: Petri Savolainen --- test/common_plat/performance/odp_sched_latency.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/test/common_plat/performance/odp_sched_latency.c

[lng-odp] [API-NEXT PATCH v2 4/8] test: validation: add odp_sys_info_print test

Added validation test for the new system info print call. Signed-off-by: Petri Savolainen --- test/common_plat/validation/api/system/system.c | 8 test/common_plat/validation/api/system/system.h | 1 + 2 files changed, 9 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH v2 1/8] api: system: added system info print

This information specifies the system where ODP application is running for debugging purposes. Signed-off-by: Petri Savolainen --- include/odp/api/spec/system_info.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/odp/api/spec/system_info.h

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> > diff --git a/platform/linux-generic/arch/x86/odp_cpu_arch.c > b/platform/linux-generic/arch/x86/odp_cpu_arch.c > > index c8cf27b6..9ba601a3 100644 > > --- a/platform/linux-generic/arch/x86/odp_cpu_arch.c > > +++ b/platform/linux-generic/arch/x86/odp_cpu_arch.c > > @@ -3,7 +3,14 @@ > > * > >

Re: [lng-odp] [API-NEXT PATCH 4/8] test: validation: add odp_sys_info_print test

> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Friday, April 21, 2017 7:58 PM > To: Petri Savolainen > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 4/8] test: validation: add > odp_sys_info_print test

Re: [lng-odp] [API-NEXT PATCH 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Friday, April 21, 2017 7:51 PM > To: Petri Savolainen > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 2/8] linux-gen: cpu_flags: added > x86 cpu flag read

Re: [lng-odp] [API-NEXT PATCH 3/8] linux-gen: system: implement system info print

> > + > > +void odp_sys_info_print(void) > > +{ > > + printf("\n" > > + "ODP system info\n" > > + "---\n" > > + "ODP API version: %s\n" > > + "ODP impl name: %s\n" > > + "CPU model: %s\n" > > +

Re: [lng-odp] [API-NEXT PATCH 1/8] api: system: added system info print

> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Friday, April 21, 2017 7:42 PM > To: Petri Savolainen > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 1/8] api: system: added system info > print > > On