Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

Ping. Review needed. Packet range patch needs this. We have deprecation in place already. This patch set makes deprecation more explicit than it's today. With this deprecation is off by default, and user can turn it on. Today, deprecation is on by default and there's no way to turn it off. It'

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Wednesday, April 19, 2017 9:37 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: Honnappa Nagarahalli ; lng- > o...@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw tim

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Wednesday, April 19, 2017 9:46 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time > counter when available

Re: [lng-odp] [PATCH 1/2] test: tm: add paths to find tm binary

Petri, is that fixes your problem? Can you provide review to I can apply it? Thank you, Maxim. On 26 April 2017 at 12:00, Github ODP bot wrote: > From: Maxim Uvarov > > Use the same algorithm as pktio_run.sh to find paths in > different cases (in tree build, out of tree build, distcheck > and

Re: [lng-odp] [API-NEXT PATCH v2 4/4] api: crypto: enforce deprecated API status

On 30.03.2017 16:58, Petri Savolainen wrote: > diff --git a/platform/linux-generic/odp_crypto.c > b/platform/linux-generic/odp_crypto.c > index 2ba504b..228e598 100644 > --- a/platform/linux-generic/odp_crypto.c > +++ b/platform/linux-generic/odp_crypto.c > @@ -644,12 +644,13 @@ int odp_crypto_cap

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Wednesday, April 19, 2017 10:05 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time > counter when available

Re: [lng-odp] [API-NEXT PATCH 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Wednesday, April 19, 2017 10:16 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 2/8] linux-gen: cpu_flags: added > x86 cpu flag read funct

[lng-odp] [Bug 2976] New: IP headers checksum functions are incorrect

https://bugs.linaro.org/show_bug.cgi?id=2976 Bug ID: 2976 Summary: IP headers checksum functions are incorrect Product: OpenDataPlane - linux- generic reference Version: master Hardware: Other OS: Linux Status: UNCO

[lng-odp] [Bug 2976] IP headers checksum functions are incorrect

https://bugs.linaro.org/show_bug.cgi?id=2976 --- Comment #1 from Dmitry Eremin-Solenikov --- - odph_checksum assumes that ip header is aligned to two bytes. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

[lng-odp] [PATCH] linux-gen: pktio: fix valgrind warnings

Fix valgrind warnings about syscall params pointing to uninitialised bytes. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/ethtool.c | 1 + platform/linux-generic/pktio/socket.c | 1 + 2 files changed, 2 insertions(+) diff --git a/platform/linux-generic/pktio/ethtool.c b/platform/

[lng-odp] [[RFCv2] 1/4] api: ipsec: mark odp_ipsec_sa_create argument as constant

odp_ipsec_sa_create() should not change its argument. Thus mark it as a constant. Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 2 +- platform/linux-generic/odp_ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/odp/api/spec/i

[lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

- Move packets from the event instead of copying them. This simplifies event handling/freeing code, which now does not have to track, which packets were copied from the event and which packets should be freed. - Do not require to free the event before processing packets. This allows one

[lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

If an application has passed invalid SA in async mode, there is no way to report it back to application except using default queue (which does not exist at this moment). Signed-off-by: Dmitry Eremin-Solenikov --- include/odp/api/spec/ipsec.h | 7 +++ 1 file changed, 7 insertions(+) diff --g

[lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No zeroing of mutable IPv4 options for AH ICV calculation - No replay protection - No ESN support Signed-off-by: Dmitry Eremin-Solenikov --- .../include/odp/api/p

Re: [lng-odp] [PATCH 1/2] test: tm: add paths to find tm binary

This patch fixes the validation test failure. Couple minor comments below. -Matias > > From: Maxim Uvarov > > Use the same algorithm as pktio_run.sh to find paths in > different cases (in tree build, out of tree build, distcheck > and etc). > Fixes: > https://bugs.linaro.org/show_bug.cgi?id=29

Re: [lng-odp] [PATCH] linux-gen: pktio: fix valgrind warnings

On Thu, Apr 27, 2017 at 6:29 AM, Matias Elo wrote: > Fix valgrind warnings about syscall params pointing to uninitialised bytes. > > Signed-off-by: Matias Elo > Reviewed-by: Bill Fischofer > --- > platform/linux-generic/pktio/ethtool.c | 1 + > platform/linux-generic/pktio/socket.c | 1 + >

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

https://bugs.linaro.org/show_bug.cgi?id=2952 Bill Fischofer changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

[lng-odp] [Bug 2911] unchecked return value may result in out of bounds access

https://bugs.linaro.org/show_bug.cgi?id=2911 Bill Fischofer changed: What|Removed |Added CC||josep.puigdem...@linaro.org --- Comment #3 fr

Re: [lng-odp] [API-NEXT PATCH 1/4] api: pool: add maximum packet counts to pool info

>> - /** The number of packets that the pool must provide >> - that are packet length 'len' bytes or smaller. >> - The maximum value is defined by pool capability >> - pkt.max_num. */ >> +

[lng-odp] [Bug 2969] TM validation test does find traffic_mngr_main

https://bugs.linaro.org/show_bug.cgi?id=2969 Bill Fischofer changed: What|Removed |Added CC||bill.fischo...@linaro.org Status|

[lng-odp] [Bug 2976] IP headers checksum functions are incorrect

https://bugs.linaro.org/show_bug.cgi?id=2976 Bill Fischofer changed: What|Removed |Added CC||bill.fischo...@linaro.org Assignee|

[lng-odp] [Bug 2911] unchecked return value may result in out of bounds access

https://bugs.linaro.org/show_bug.cgi?id=2911 --- Comment #4 from Matias Elo --- This is an invalid bug. The code never gets into the for loop if packet_alloc_multi() returns a negative value. -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 2974] odp_rwlock_read_trylock() fails if lock is already held for read access

https://bugs.linaro.org/show_bug.cgi?id=2974 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever confirmed|0

[lng-odp] [Bug 2951] Traffic manager test fails during make distcheck

https://bugs.linaro.org/show_bug.cgi?id=2951 Bill Fischofer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED

[lng-odp] [Bug 2969] TM validation test does find traffic_mngr_main

https://bugs.linaro.org/show_bug.cgi?id=2969 Bill Fischofer changed: What|Removed |Added CC||dmitry.ereminsolenikov@lina

[lng-odp] [Bug 2945] Potentially high (unbound) latency when threads are grouped into multiple schedule groups

https://bugs.linaro.org/show_bug.cgi?id=2945 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[lng-odp] [Bug 2933] Miss to call unlock if there are some errors happen in loopback_send() function.

https://bugs.linaro.org/show_bug.cgi?id=2933 Bill Fischofer changed: What|Removed |Added CC||bill.fischo...@linaro.org Resolution|

[lng-odp] [Bug 2911] unchecked return value may result in out of bounds access

https://bugs.linaro.org/show_bug.cgi?id=2911 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[lng-odp] [Bug 2903] validation: add test case for PMR LD_VNI

https://bugs.linaro.org/show_bug.cgi?id=2903 Bill Fischofer changed: What|Removed |Added CC||bala.manoha...@linaro.org,

[lng-odp] [Bug 2895] odp_crypto_operation() does not work with multi-segment packets

https://bugs.linaro.org/show_bug.cgi?id=2895 Bill Fischofer changed: What|Removed |Added CC||nikhil.agar...@linaro.org --- Comment #2 from

[lng-odp] [Bug 2881] load sensitive tests fail on CI

https://bugs.linaro.org/show_bug.cgi?id=2881 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[lng-odp] [Bug 2872] odp_pktio_ordered_run.sh: line 34: [: : integer expression expected

https://bugs.linaro.org/show_bug.cgi?id=2872 Bill Fischofer changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[lng-odp] [PATCHv2 1/2] test: tm: add paths to find tm binary

Use the same algorithm as pktio_run.sh to find paths in different cases (in tree build, out of tree build, distcheck and etc). Fixes: https://bugs.linaro.org/show_bug.cgi?id=2969 Signed-off-by: Maxim Uvarov --- v2: fix Matias comments .../validation/api/traffic_mngr/traffic_mngr.sh| 22 +++

[lng-odp] [PATCHv2 2/2] test: pktio_run: exit if binary was not found

No need to continue run if binary was not found in paths. Signed-off-by: Maxim Uvarov --- test/linux-generic/validation/api/pktio/pktio_run.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/linux-generic/validation/api/pktio/pktio_run.sh b/test/linux-generic/validation/api/pktio/pktio

[lng-odp] [Linaro/odp] 6028f9: validation: crypto: add tests for checking message...

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 6028f9d4b9ec4c770d8fc5c09f1ccbb33b22f8b2 https://github.com/Linaro/odp/commit/6028f9d4b9ec4c770d8fc5c09f1ccbb33b22f8b2 Author: Dmitry Eremin-Solenikov Date: 2017-04-27 (Thu, 27 Apr 2017) Changed paths:

[lng-odp] Regarding how ODP closes scheduled PKTIOs

Hello, I have some questions regarding how scheduled PKTIOs are closed. Please correct me if I am wrong... In ODP 1.11 Monarch (I think 1.14 as well) scheduled PKTIOs cannot be closed before they are stopped and unscheduled. This is why there are the transitional states PKTIO_STATE_STOP_PENDING a

Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

I realize this is still an RFC, but FYI, this has some compilation issues: CC odp_ipsec.lo odp_ipsec.c: In function ‘odp_ipsec_in’: odp_ipsec.c:1219:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] while (in_pkt < input->num_pkt && out_pkt < ou

[lng-odp] [Linaro/odp] cf4a81: test: tm: add paths to find tm binary

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: cf4a8144d8a8fcbbc3a9d6d43cbaa479f5e2dbfb https://github.com/Linaro/odp/commit/cf4a8144d8a8fcbbc3a9d6d43cbaa479f5e2dbfb Author: Maxim Uvarov Date: 2017-04-27 (Thu, 27 Apr 2017) Changed paths: M test/co

[lng-odp] [Bug 2969] TM validation test does find traffic_mngr_main

https://bugs.linaro.org/show_bug.cgi?id=2969 --- Comment #2 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/cf4a8144d8a8fcbbc3a9d6d43cbaa479f5e2dbfb 2017-04-27T21:48:01+03:00 Maxim Uvarov maxim.uva...@linaro.org test: tm: add paths to find tm binary Use the same algorithm as pktio_run

[lng-odp] [Linaro/odp] 8df1b6: test: tm: add paths to find tm binary

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 8df1b60560ac49b403bfb044c04595b831bc393b https://github.com/Linaro/odp/commit/8df1b60560ac49b403bfb044c04595b831bc393b Author: Maxim Uvarov Date: 2017-04-27 (Thu, 27 Apr 2017) Changed paths: M test/

[lng-odp] [Bug 2969] TM validation test does find traffic_mngr_main

https://bugs.linaro.org/show_bug.cgi?id=2969 --- Comment #3 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/8df1b60560ac49b403bfb044c04595b831bc393b 2017-04-27T21:52:31+03:00 Maxim Uvarov maxim.uva...@linaro.org test: tm: add paths to find tm binary Use the same algorithm as pktio_run

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/27 10:02:24, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: Brian Brooks [mailto:brian.bro...@arm.com] > > Sent: Wednesday, April 19, 2017 10:05 PM > > To: Savolainen, Petri (Nokia - FI/Espoo) > > Cc: lng-odp@lists.linaro.org > > Subject: Re: [lng-

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/27 08:21:34, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: Brian Brooks [mailto:brian.bro...@arm.com] > > Sent: Wednesday, April 19, 2017 9:46 PM > > To: Savolainen, Petri (Nokia - FI/Espoo) > > Cc: lng-odp@lists.linaro.org > > Subject: Re: [lng-o

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > If an application has passed invalid SA in async mode, there is no way > to report it back to application except using default queue (which does > not exist at this moment). > > Signed-off-by: Dm

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > - Move packets from the event instead of copying them. This simplifies >event handling/freeing code, which now does not have to track, which >packets were copied from the event and which

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 01:46, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > > wrote: > > - Move packets from the event instead of copying them. This simplifies >event handling/freeing code, which now does not

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 01:23, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > > wrote: > > If an application has passed invalid SA in async mode, there is no way > to report it back to application except using defau

Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

Bill, Thank you for your review! On 27.04.2017 20:34, Bill Fischofer wrote: > I realize this is still an RFC, but FYI, this has some compilation issues: > > CC odp_ipsec.lo > odp_ipsec.c: In function ‘odp_ipsec_in’: > odp_ipsec.c:1219:16: error: comparison between signed and unsigned > i

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On Thu, Apr 27, 2017 at 6:19 PM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 28.04.2017 01:23, Bill Fischofer wrote: > > > > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > > > > wrote: > > > > If an applica

Re: [lng-odp] [[RFCv2] 2/4] api: ipsec: add default queue for outbound events

On 28.04.2017 03:33, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 6:19 PM, Dmitry Eremin-Solenikov > > wrote: > > On 28.04.2017 01:23, Bill Fischofer wrote: > > > > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov >

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On Thu, Apr 27, 2017 at 5:49 PM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 28.04.2017 01:46, Bill Fischofer wrote: > > > > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov > > > > wrote: > > > > - Move packe

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On 28.04.2017 03:45, Bill Fischofer wrote: > > > On Thu, Apr 27, 2017 at 5:49 PM, Dmitry Eremin-Solenikov > > wrote: > > On 28.04.2017 01:46, Bill Fischofer wrote: > > > > > > On Thu, Apr 27, 2017 at 6:51 AM, Dmitry Eremin-Solenikov >

Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

On Thu, Apr 27, 2017 at 6:34 PM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > Bill, > > Thank you for your review! > > On 27.04.2017 20:34, Bill Fischofer wrote: > > I realize this is still an RFC, but FYI, this has some compilation > issues: > > > > CC odp_ipsec.l

Re: [lng-odp] [[RFCv2] 3/4] api: ipsec: change semantics of odp_ipsec_result function

On Thu, Apr 27, 2017 at 7:50 PM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 28.04.2017 03:45, Bill Fischofer wrote: > > > > > > On Thu, Apr 27, 2017 at 5:49 PM, Dmitry Eremin-Solenikov > > > > wrote: > > > > On 28.04.2017

[lng-odp] [API_NEXT v2] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

Signed-off-by: Nikhil Agarwal --- include/odp/api/spec/ipsec.h | 62 +--- include/odp/api/spec/packet_io.h | 10 +++ 2 files changed, 36 insertions(+), 36 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index e8349