Re: [lng-odp] Summary of Expiration Discussion

2017-05-24 Thread Bogdan Pricope
This ‘status_queue’ looks fine to me. /Bogdan On 24 May 2017 at 02:20, Bill Fischofer wrote: > This is a quick summary of the expiration discussion held during > Monday's ARCH call. > > The current odp_ipsec_capability_t defines two fields: > > /** Soft expiry limit in seconds support > * > * 0

[lng-odp] Release needed

2017-05-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, It's already two months since 1.14 release. We have again missed the target of a release per month. Additionally, we have bunch of stuff in api-next that could move to master, and thus to the next release. From api-next these API spec files (or parts) are OK to move into master: * entire cl

Re: [lng-odp] Release needed

2017-05-24 Thread Maxim Uvarov
Ok, thanks for details. I will try to prepare release according to your list on this week. On 24 May 2017 at 10:38, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > It's already two months since 1.14 release. We have again missed the > target of a release per mo

Re: [lng-odp] [PATCH] test: generator: replace gettimeofday() with ODP API calls

2017-05-24 Thread Bogdan Pricope
Ping. On 3 May 2017 at 11:45, Bogdan Pricope wrote: > Hi Yi, > > I disagree: bytes sent in Data field of Echo request are opaque and > have no meaning for any other entity then ‘me’ (the sender of echo > request / receiver of echo reply). > > The only obligation of the receiver of echo request,

Re: [lng-odp] [RFCv4] dpdk: enable hardware checksum support

2017-05-24 Thread Elo, Matias (Nokia - FI/Espoo)
Hi Bogdan, I ran a quick test run with the patch and the overhead seems to be surprisingly small at least on a Xeon cpu (E5-2697v3). However, I would still suggest making some changes to the code. More below. -Matias > > @@ -605,9 +663,11 @@ static inline int mbuf_to_pkt(pktio_entry_t *pktio

Re: [lng-odp] [API-NEXT PATCH v6 1/6] test: odp_sched_latency: misc improvements

2017-05-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Wednesday, May 24, 2017 6:56 AM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: Brian Brooks ; lng-odp@lists.linaro.org; Ola > Liljedahl > Subject: Re: [lng-odp] [API-NEXT PATCH v6 1/6] t

Re: [lng-odp] [PATCH] test: generator: replace gettimeofday() with ODP API calls

2017-05-24 Thread Yi He
O, sorry Bogdan missed your reply, I saw the time value in ICMP message was filled(sending) by "memcpy(tval_d, ..., sizeof(uint64_t));" and processed(receiving) as "memcpy(&tsend, ..., sizeof(uint64_t));" If the sending peer is little endian and the receiving peer is big endian I think it will c

Re: [lng-odp] [PATCH] test: generator: replace gettimeofday() with ODP API calls

2017-05-24 Thread Bogdan Pricope
Hi Yi, As I said in my reply, the sender is also the interpreter of the data. The peer must only send the payload unmodified in echo reply - it is not relevant if it understands or not the payload (it is opaque data for peer): you can ping la Ubuntu or FreeBSD machine... don't expect them to under

Re: [lng-odp] [RFCv4] dpdk: enable hardware checksum support

2017-05-24 Thread Bogdan Pricope
Hi Matias, Using ptypes reported by dpdk in parser was intended for another patch (next work after csum). I guess your test is a degradation test (due to new ifs) and you did not enabled csum offloads/ set flags on packets. What will be interesting to see: - in a generation or termination test

Re: [lng-odp] [PATCH] test: generator: replace gettimeofday() with ODP API calls

2017-05-24 Thread Yi He
O, yes, I see, it is the same entity to process both ICMP request/reply and can piggyback opaque payload, sorry for the misunderstanding, this still applied to the master branch and: Reviewed-and-tested-by: Yi He On 24 May 2017 at 16:12, Bogdan Pricope wrote: > Hi Yi, > > As I said in my re

Re: [lng-odp] APIs for dealing with compact handles

2017-05-24 Thread Sachin Saxena
Thanks Bill for initiating the thread. Please checkout some more details*(**i**nline)* on the requirements & proposal. On 5/17/2017 8:50 PM, Bill Fischofer wrote: This thread is to discuss ideas and proposed solutions to two issues that have been raised by Sachin relating to VPP needs, as we

Re: [lng-odp] APIs for dealing with compact handles

2017-05-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Sachin Saxena > Sent: Wednesday, May 24, 2017 12:43 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] APIs for dealing with compact handles > > Thanks Bill for initiating the thread. >

Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files

2017-05-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Wednesday, May 24, 2017 6:59 AM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: Brian Brooks ; lng-odp@lists.linaro.org; Ola > Liljedahl > Subject: Re: [lng-odp] [API-NEXT PATCH v6 3/6] A

Re: [lng-odp] [RFCv4] dpdk: enable hardware checksum support

2017-05-24 Thread Elo, Matias (Nokia - FI/Espoo)
> On 24 May 2017, at 11:32, Bogdan Pricope wrote: > > Hi Matias, > > Using ptypes reported by dpdk in parser was intended for another patch > (next work after csum). > Good, so we are on the same page. When implementing packet parsing you have to move/reimplement this checksum code anyway, so

Re: [lng-odp] APIs for dealing with compact handles

2017-05-24 Thread Bill Fischofer
I've added this topic to the agenda for today's ARCH call. I agree with Petri that any changes should be based on measurements, and preferably real application measurements rather than microbenchmarks. On Wed, May 24, 2017 at 6:46 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Origin

Re: [lng-odp] Summary of Expiration Discussion

2017-05-24 Thread Peltonen, Janne (Nokia - FI/Espoo)
Bill Fischofer wrote: > > The following data items MUST be in the SAD: But that does not necessarily mean that they need to be in the ODP SA. > With this background, it's clear that should we choose to remove > time-based expiration from the ODP IPsec API spec we would have an > incomplete IPsec

[lng-odp] [Linaro/odp] 60b9dd: linux-gen: sched: fix ordered enqueue to pktout qu...

2017-05-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 60b9dd435bf1be55794e5be6ee24714d28a5b587 https://github.com/Linaro/odp/commit/60b9dd435bf1be55794e5be6ee24714d28a5b587 Author: Matias Elo Date: 2017-05-23 (Tue, 23 May 2017) Changed paths: M platform/

[lng-odp] [Bug 3002] Packet order lost when enqueuing to pktout queue

2017-05-24 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=3002 --- Comment #1 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/60b9dd435bf1be55794e5be6ee24714d28a5b587 2017-05-23T23:14:36+03:00 Matias Elo matias@nokia.com linux-gen: sched: fix ordered enqueue to pktout queue Make sure packet order i

[lng-odp] [PATCH 0/3] Fix pktio with single segment packet pool

2017-05-24 Thread Matias Elo
This patch set enables using packet pool in single segment mode (CONFIG_PACKET_MAX_SEGS = 1). Matias Elo (3): linux-gen: packet: fix odp_packet_free_multi() with single segment pool linux-gen: packet: fix gcc errors with single segment pool test: pktio: use capability to set test pool pa

[lng-odp] [PATCH 1/3] linux-gen: packet: fix odp_packet_free_multi() with single segment pool

2017-05-24 Thread Matias Elo
Previously the implementation would use wrong handles and crash if CONFIG_PACKET_MAX_SEGS was set to one. Signed-off-by: Matias Elo --- platform/linux-generic/odp_packet.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platf

[lng-odp] [PATCH 2/3] linux-gen: packet: fix gcc errors with single segment pool

2017-05-24 Thread Matias Elo
Fix (invalid) gcc errors when CONFIG_PACKET_MAX_SEGS is set to one. Signed-off-by: Matias Elo --- platform/linux-generic/odp_packet.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 3e7c07a.

[lng-odp] [PATCH 3/3] test: pktio: use capability to set test pool packet length

2017-05-24 Thread Matias Elo
Test used to fail if odp_pool_capability_t.pkt.max_len < PKT_BUF_SIZE. Signed-off-by: Matias Elo --- test/common_plat/validation/api/pktio/pktio.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/common_plat/validation/api/pktio/pktio.c b/test/common_plat/validati

Re: [lng-odp] [PATCH 0/3] Fix pktio with single segment packet pool

2017-05-24 Thread Maxim Uvarov
if it is useful case let's add this test to .travis.yaml Maxim. On 24 May 2017 at 17:35, Matias Elo wrote: > This patch set enables using packet pool in single segment mode > (CONFIG_PACKET_MAX_SEGS = 1). > > Matias Elo (3): > linux-gen: packet: fix odp_packet_free_multi() with single segment

[lng-odp] [Linaro/odp] ea134f: test: generator: replace gettimeofday with ODP API...

2017-05-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: ea134fe159c0d249e4bed12b7269e8236afa0262 https://github.com/Linaro/odp/commit/ea134fe159c0d249e4bed12b7269e8236afa0262 Author: Bogdan Pricope Date: 2017-05-24 (Wed, 24 May 2017) Changed paths: M examp

[lng-odp] [PATCH API-NEXT v1 0/1] api: crypto: make odp_crypto_session_create return odp_crypto_session_t

2017-05-24 Thread Github ODP bot
Currently odp_crypto_session_create() (unlike other creation functions) returns int result with session being returned through pointer argument. Instead it is simpler to directly return a session (or ODP_CRYPTO_SESSION_INVALID in case of an error). Signed-off-by: Dmitry Eremin-Solenikov dmitry.erem

[lng-odp] [PATCH API-NEXT v1 1/1] api: crypto: make odp_crypto_session_create return odp_crypto_session_t

2017-05-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Currently odp_crypto_session_create() (unlike other creation functions) returns int result with session being returned through pointer argument. Instead it is simpler to directly return a session (or ODP_CRYPTO_SESSION_INVALID in case of an error). Signed-off-by: Dm

Re: [lng-odp] APIs for dealing with compact handles

2017-05-24 Thread Bill Fischofer
Given the assumptions that VPP makes on packet / pool organization, perhaps another approach would be to add a request bit to the odp_pool_param_t struct to request that this pool support linear organization. Something like: typedef struct odp_pool_param_t { /** Pool type */ int ty

[lng-odp] [PATCH v1 0/1] travis: use pkg-config to discover ODP flags

2017-05-24 Thread Github ODP bot
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org github /** Email created from pull request 38 (lumag:fix-link) ** https://github.com/Linaro/odp/pull/38 ** Patch: https://github.com/Linaro/odp/pull/38.patch ** Base sha: ea134fe159c

[lng-odp] [PATCH v1 1/1] travis: use pkg-config to discover ODP flags

2017-05-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 38 (lumag:fix-link) ** https://github.com/Linaro/odp/pull/38 ** Patch: https://github.com/Linaro/odp/pull/38.patch ** Base sha: ea134fe159c0d249e4bed12b7269e8236afa0262 ** Merge commi

[lng-odp] [PATCH v2 0/1] travis: use pkg-config to discover ODP flags

2017-05-24 Thread Github ODP bot
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org github /** Email created from pull request 38 (lumag:fix-link) ** https://github.com/Linaro/odp/pull/38 ** Patch: https://github.com/Linaro/odp/pull/38.patch ** Base sha: ea134fe159c

[lng-odp] [PATCH v2 1/1] travis: use pkg-config to discover ODP flags

2017-05-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 38 (lumag:fix-link) ** https://github.com/Linaro/odp/pull/38 ** Patch: https://github.com/Linaro/odp/pull/38.patch ** Base sha: ea134fe159c0d249e4bed12b7269e8236afa0262 ** Merge commi

Re: [lng-odp] [PATCH v2 1/1] travis: use pkg-config to discover ODP flags

2017-05-24 Thread Maxim Uvarov
something like --- a/pkgconfig/libodp-linux.pc.in +++ b/pkgconfig/libodp-linux.pc.in @@ -6,6 +6,6 @@ includedir=@includedir@ Name: libodp-linux Description: The ODP packet processing engine Version: @PKGCONFIG_VERSION@ -Libs: -L${libdir} -lodp-linux +Libs: -L${libdir} -lodp-linux @LIBS@ Libs.p

[lng-odp] [Linaro/odp] 39f85b: helper: linux: add common linux helper file

2017-05-24 Thread GitHub
Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: 39f85bc6cab329b4ae41ba2ec922370c24254325 https://github.com/Linaro/odp/commit/39f85bc6cab329b4ae41ba2ec922370c24254325 Author: Petri Savolainen Date: 2017-03-02 (Thu, 02 Mar 2017) Changed paths: M helpe

[lng-odp] [Bug 2826] CID 174664: Unchecked return in pool.c

2017-05-24 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2826 --- Comment #3 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/88dbb00623102878f2e0e1dd720a942fdd980ca3 2017-03-02T18:00:12+03:00 Bill Fischofer bill.fischo...@linaro.org linux-generic: pool: add odp_pool_capability() rc check Resolve Bug h

[lng-odp] [Linaro/odp] c951ba: api: classification: add additional doxygen docume...

2017-05-24 Thread GitHub
Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: c951ba0386581a87675477456e3df0010f2eac66 https://github.com/Linaro/odp/commit/c951ba0386581a87675477456e3df0010f2eac66 Author: Bill Fischofer Date: 2017-05-24 (Wed, 24 May 2017) Changed paths: M include

[lng-odp] [Bug 2952] doxygen errors and travis does not catch them

2017-05-24 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2952 --- Comment #16 from Maxim Uvarov --- https://github.com/Linaro/odp/commit/c951ba0386581a87675477456e3df0010f2eac66 2017-05-24T22:29:07+03:00 Bill Fischofer bill.fischo...@linaro.org api: classification: add additional doxygen documentation Resolve Bu

[lng-odp] [Linaro/odp] 4d6197: api: crypto: add sha-1 and sha-512 enumerations

2017-05-24 Thread GitHub
Branch: refs/heads/next Home: https://github.com/Linaro/odp Commit: 4d619768d75e4e1c15bb1be7fe282dff532f166b https://github.com/Linaro/odp/commit/4d619768d75e4e1c15bb1be7fe282dff532f166b Author: Petri Savolainen Date: 2017-05-24 (Wed, 24 May 2017) Changed paths: M inclu

[lng-odp] [Bug 3013] New: Various failures if CONFIG_PACKET_MAX_SEGS is set to 1

2017-05-24 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=3013 Bug ID: 3013 Summary: Various failures if CONFIG_PACKET_MAX_SEGS is set to 1 Product: OpenDataPlane - linux- generic reference Version: v1.14.0.0 Hardware: Other OS: Linux

[lng-odp] [Bug 3013] Various failures if CONFIG_PACKET_MAX_SEGS is set to 1

2017-05-24 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=3013 Bill Fischofer changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

Re: [lng-odp] [PATCH 0/3] Fix pktio with single segment packet pool

2017-05-24 Thread Bill Fischofer
Good bug catch. I've opened Bug https://bugs.linaro.org/show_bug.cgi?id=3013 to track this and assigned it to Matias and noted that he's posted a patch to address this. Maxim: Can we please reference this Bug in the merge commit? For this series: Reviewed-and-tested-by: Bill Fischofer On Wed,

[lng-odp] [PATCH API-NEXT v1 0/1] travis: add linking with libconfig

2017-05-24 Thread Github ODP bot
libconfig is needed for api-next branch to compile the app. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org -- Dmitry works to make pktconfig work but that is quick fix for api next to fix linking. After master merge it's needed to add -lconfig to make app compile in api-next branch. This pat

[lng-odp] [PATCH API-NEXT v1 1/1] travis: add linking with libconfig

2017-05-24 Thread Github ODP bot
From: Maxim Uvarov libconfig is needed for api-next branch to compile the app. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 39 (muvarov:api-next) ** https://github.com/Linaro/odp/pull/39 ** Patch: https://github.com/Linaro/odp/pull/39.patch ** Base sha: f20dee9db3da942

[lng-odp] [PATCH v1 0/1] travis: split build into separate stages

2017-05-24 Thread Github ODP bot
Introduce separate parallel builds for checkpatch, doxygen, distcheck and plain checks. Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org github /** Email created from pull request 40 (lumag:stages) ** https://github.com/Linaro/odp/pu

[lng-odp] [PATCH v1 1/1] travis: split build into separate stages

2017-05-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Introduce separate parallel builds for checkpatch, doxygen, distcheck and plain checks. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 40 (lumag:stages) ** https://github.com/Linaro/odp/pull/40 ** Patch: https://github.com/Linaro/o

[lng-odp] [PATCH v1 1/1] test: linux-generic: stop dropping other ODP files in pktio_ips test

2017-05-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Prevent pktio_ipc test from removing sockets and SHM files used by other applications. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 41 (lumag:patch-1) ** https://github.com/Linaro/odp/pull/41 ** Patch: https://github.com/Linaro/o

[lng-odp] [PATCH v1 0/1] test: linux-generic: stop dropping other ODP files in pktio_ips test

2017-05-24 Thread Github ODP bot
Prevent pktio_ipc test from removing sockets and SHM files used by other applications. github /** Email created from pull request 41 (lumag:patch-1) ** https://github.com/Linaro/odp/pull/41 ** Patch: https://github.com/Linaro/odp/pull/41.patch ** Base sh