Hi,
This doc contains some thoughts on DDF design. Please take a look and
share your comments.
https://docs.google.com/a/linaro.org/document/d/1OJg1Ouj0Fktg_Ng93DqJgNwuWA_d8xyLBQ2izd3GuD8/edit?usp=sharing
/B
Honnappa Nagarahalli wrote:
> On 12 June 2017 at 06:11, Petri Savolainen
> wrote:
> > Clean up function and parameter naming after modular interface
> > patch. Queue_t type is referred as "queue internal": queue_int or
> > q_int. Term "handle" is reserved for API level handles (e.g.
> > odp_queu
On 15.06.2017 14:21, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> index d71f4464af48..3cd4a73cbefb 100644
>> --- a/platform/linux-generic/odp_event.c
>> +++ b/platform/linux-generic/odp_event.c
>> @@ -19,6 +19,11 @@ odp_event_type_t odp_event_type(odp_event_t event)
>> return _odp_buffer_
Applies on top of [API-NEXT PATCH v2 0/3] IPSEC packet event
These patches provide event subtype implementation and tests. Ideally they
should be merged together with event subtypes API definitions.
Changes since v1:
- Implement odp_event_types()
- Update event subtype properly in odp_crypto.c
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/include/odp_buffer_inlines.h | 2 ++
platform/linux-generic/include/odp_buffer_internal.h | 3 +++
platform/linux-generic/odp_crypto.c | 14 --
platform/linux-generic/odp_event.c |
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/validation/api/buffer/buffer.c | 37 +++--
test/common_plat/validation/api/packet/packet.c | 5
test/common_plat/validation/api/timer/timer.c | 14 --
3 files changed, 39 insertions(+), 17 deletions(-)
> >>switch (odp_event_type(event)) {
> >> diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-
> >> generic/odp_packet.c
> >> index eb66af2d3b9c..3789feca45f9 100644
> >> --- a/platform/linux-generic/odp_packet.c
> >> +++ b/platform/linux-generic/odp_packet.c
> >> @@ -268,6 +268,7
Reviewed-by: Petri Savolainen
Tests for odp_event_types() and subtype for crypto_compl are missing. Those can
be added on top of this or as v3.
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Dmitry Eremin-Solenikov
> Sent: Friday, June 1
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Github ODP bot
> Sent: Thursday, June 15, 2017 11:00 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH API-NEXT v1 1/1] api: schedule: add thread
> removal correction
>
> From: Honna
On 16.06.2017 12:37, Savolainen, Petri (Nokia - FI/Espoo) wrote:
switch (odp_event_type(event)) {
diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-
generic/odp_packet.c
index eb66af2d3b9c..3789feca45f9 100644
--- a/platform/linux-generic/odp_packet.c
>>>
>> void *buf_hdr[], int num, int
>> *ret);
>> typedef int (*schedule_init_global_fn_t)(void);
>> typedef int (*schedule_term_global_fn_t)(void);
>> diff --git a/platform/linux-generic/odp_queue.c
>> b/platform/linux-generic/odp_queue.c
>> index 3e18f578.
> On 16 Jun 2017, at 11:03, Peltonen, Janne (Nokia - FI/Espoo)
> wrote:
>
>
> Honnappa Nagarahalli wrote:
>> On 12 June 2017 at 06:11, Petri Savolainen
>> wrote:
>>> Clean up function and parameter naming after modular interface
>>> patch. Queue_t type is referred as "queue internal": queue_
Disable event is guaranteed to be the last event for the SA,
so that application can use it for SA destroy synchronization.
Signed-off-by: Petri Savolainen
---
include/odp/api/spec/ipsec.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/odp/api/spec/ipsec.h b/incl
Applies on top of: "[API-NEXT PATCH v2 0/2] IPsec API update"
Input and output of IPSEC operations are packets. Parameter and
result structures are cleaner when packet arrays are direct
parameters to functions. Also API is more flexible for
application or API pipelining when output is packets with
Event subtype gives more detailed information about the event.
Two subtypes (basic and IPSEC packet) are introduced initially.
Later on, other packet producing APIs (crypto, comp, etc) may
also produce packet events with additional subtypes.
Signed-off-by: Petri Savolainen
---
include/odp/api/sp
Input and output of IPSEC operations are packets. Parameter and
result structures are cleaner when packet arrays are direct
parameters to functions. Also API is more flexible for
application and API pipelining when output is packets with
additional metadata. Application or API pipeline stages which
Adds api to release an existing ordered lock and acquire a new lock.
Signed-off-by: Balasubramanian Manoharan
---
include/odp/api/spec/schedule.h | 20
1 file changed, 20 insertions(+)
diff --git a/include/odp/api/spec/schedule.h b/include/odp/api/spec/schedule.h
index 82
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/include/odp_buffer_inlines.h | 2 ++
platform/linux-generic/include/odp_buffer_internal.h | 3 +++
platform/linux-generic/odp_crypto.c | 15 +--
platform/linux-generic/odp_event.c |
Applies on top of [API-NEXT PATCH v2 0/3] IPSEC packet event
These patches provide event subtype implementation and tests. Ideally they
should be merged together with event subtypes API definitions.
Changes since v2:
- Validate odp_event_types() implementation
- Validate CRYPTO_COMPL event type
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/validation/api/buffer/buffer.c| 50 --
.../validation/api/crypto/odp_crypto_test_inp.c| 14 ++
test/common_plat/validation/api/packet/packet.c| 21 -
test/common_plat/validation/api/timer/timer
On Fri, Jun 16, 2017 at 5:16 AM, Savolainen, Petri (Nokia - FI/Espoo)
wrote:
>
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
>> Github ODP bot
>> Sent: Thursday, June 15, 2017 11:00 PM
>> To: lng-odp@lists.linaro.org
>> Subject: [lng-odp] [
On Fri, Jun 16, 2017 at 5:21 AM, Dmitry Eremin-Solenikov
wrote:
> On 16.06.2017 12:37, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>switch (odp_event_type(event)) {
> diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-
> generic/odp_packet.c
> index eb66af2d3b9c.
On Fri, Jun 16, 2017 at 5:49 AM, Petri Savolainen
wrote:
> Event subtype gives more detailed information about the event.
> Two subtypes (basic and IPSEC packet) are introduced initially.
> Later on, other packet producing APIs (crypto, comp, etc) may
> also produce packet events with additional s
> > diff --git a/include/odp/api/spec/event.h b/include/odp/api/spec/event.h
> > index f22efce5..2ad3ce84 100644
> > --- a/include/odp/api/spec/event.h
> > +++ b/include/odp/api/spec/event.h
> > @@ -37,21 +37,91 @@ extern "C" {
> >
> > /**
> > * @typedef odp_event_type_t
> > - * ODP event types:
On Fri, Jun 16, 2017 at 8:04 AM, Savolainen, Petri (Nokia - FI/Espoo)
wrote:
>> > diff --git a/include/odp/api/spec/event.h b/include/odp/api/spec/event.h
>> > index f22efce5..2ad3ce84 100644
>> > --- a/include/odp/api/spec/event.h
>> > +++ b/include/odp/api/spec/event.h
>> > @@ -37,21 +37,91 @@ e
On Fri, Jun 16, 2017 at 6:42 PM, Bill Fischofer
wrote:
> On Fri, Jun 16, 2017 at 8:04 AM, Savolainen, Petri (Nokia - FI/Espoo)
> wrote:
>>> > diff --git a/include/odp/api/spec/event.h b/include/odp/api/spec/event.h
>>> > index f22efce5..2ad3ce84 100644
>>> > --- a/include/odp/api/spec/event.h
>>>
On Fri, Jun 16, 2017 at 8:33 AM, shally verma
wrote:
> On Fri, Jun 16, 2017 at 6:42 PM, Bill Fischofer
> wrote:
>> On Fri, Jun 16, 2017 at 8:04 AM, Savolainen, Petri (Nokia - FI/Espoo)
>> wrote:
> diff --git a/include/odp/api/spec/event.h b/include/odp/api/spec/event.h
> index f22efce5
Branch: refs/heads/next
Home: https://github.com/Linaro/odp
Commit: b8de7dfbadb10da65a0a675db5f588cc3998508a
https://github.com/Linaro/odp/commit/b8de7dfbadb10da65a0a675db5f588cc3998508a
Author: Bill Fischofer
Date: 2017-06-16 (Fri, 16 Jun 2017)
Changed paths:
M include
On Fri, Jun 16, 2017 at 6:21 AM, Balasubramanian Manoharan
wrote:
> Adds api to release an existing ordered lock and acquire a new lock.
>
> Signed-off-by: Balasubramanian Manoharan
> ---
> include/odp/api/spec/schedule.h | 20
> 1 file changed, 20 insertions(+)
>
> diff -
Branch: refs/heads/master
Home: https://github.com/Linaro/odp
Commit: b8de7dfbadb10da65a0a675db5f588cc3998508a
https://github.com/Linaro/odp/commit/b8de7dfbadb10da65a0a675db5f588cc3998508a
Author: Bill Fischofer
Date: 2017-06-16 (Fri, 16 Jun 2017)
Changed paths:
M inclu
https://bugs.linaro.org/show_bug.cgi?id=2952
--- Comment #30 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/b8de7dfbadb10da65a0a675db5f588cc3998508a
refs/heads/master
2017-06-16T16:51:09+03:00
Bill Fischofer bill.fischo...@linaro.org
api: classification: add additional doxygen documen
https://bugs.linaro.org/show_bug.cgi?id=2952
--- Comment #31 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/583dbc9adab460c926339353cc882095594b5b60
refs/heads/master
2017-06-16T16:51:10+03:00
Bill Fischofer bill.fischo...@linaro.org
api: pool: add additional doxygen documentation
Re
https://bugs.linaro.org/show_bug.cgi?id=2952
--- Comment #32 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/b9676fc5ba51d0f26a9c8c40f0b65a003113f1b5
refs/heads/master
2017-06-16T16:51:10+03:00
Bill Fischofer bill.fischo...@linaro.org
api: tm: add additional doxygen documentation
Reso
https://bugs.linaro.org/show_bug.cgi?id=2952
--- Comment #33 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/af05215e26c99693c000981fddfaf3cdd2225e3f
refs/heads/master
2017-06-16T16:51:10+03:00
Bill Fischofer bill.fischo...@linaro.org
linux-generic: types: add additional doxygen docume
https://bugs.linaro.org/show_bug.cgi?id=2952
--- Comment #34 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/629be2dd2d166ed1246b8c1982af3a55a7035657
refs/heads/master
2017-06-16T16:51:10+03:00
Bill Fischofer bill.fischo...@linaro.org
helper: add additional doxygen documentation
Resol
https://bugs.linaro.org/show_bug.cgi?id=3003
--- Comment #5 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/697c3be9b2155379dee458d66335442375a9354d
refs/heads/master
2017-06-16T16:51:11+03:00
Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org
linux: crypto: fix checking of GCM
https://bugs.linaro.org/show_bug.cgi?id=3039
--- Comment #3 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/79ed8c746ba13233c111a61d2d4f17e360dd8023
refs/heads/master
2017-06-16T17:01:11+03:00
Bill Fischofer bill.fischo...@linaro.org
changelog: add bug 3039 to list of bug fixes for v1.
https://bugs.linaro.org/show_bug.cgi?id=2938
--- Comment #1 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/0b5e8c6870b959ad9db426aa067326f4baad5d58
refs/heads/master
2017-06-16T17:01:11+03:00
Maxim Uvarov maxim.uva...@linaro.org
build: fix order of test execution
l2fwd perf test requ
Can you please explain the use case for this API?
We already have odp_schedule_order_unlock and odp_schedule_order_lock.
These APIs can be used to do the same operation.
On 16 June 2017 at 09:12, Bill Fischofer wrote:
> On Fri, Jun 16, 2017 at 6:21 AM, Balasubramanian Manoharan
> wrote:
>> Adds
Reviewed-by: Honnappa Nagarahalli
On 14 June 2017 at 14:34, Brian Brooks wrote:
> Run timer pool processing on worker cores if the application hints
> that the scheduler will be used. This reduces the latency and jitter
> of the point at which timer pool processing begins. See [1] for details.
>
On 16 June 2017 at 03:03, Peltonen, Janne (Nokia - FI/Espoo)
wrote:
>
> Honnappa Nagarahalli wrote:
>> On 12 June 2017 at 06:11, Petri Savolainen
>> wrote:
>> > Clean up function and parameter naming after modular interface
>> > patch. Queue_t type is referred as "queue internal": queue_int or
>
On 16 June 2017 at 05:25, Elo, Matias (Nokia - FI/Espoo)
wrote:
>
>>> void *buf_hdr[], int num, int
>>> *ret);
>>> typedef int (*schedule_init_global_fn_t)(void);
>>> typedef int (*schedule_term_global_fn_t)(void);
>>> diff --git a/platform/linux-generic/
Regards,
Bala
On 16 June 2017 at 19:42, Bill Fischofer wrote:
> On Fri, Jun 16, 2017 at 6:21 AM, Balasubramanian Manoharan
> wrote:
> > Adds api to release an existing ordered lock and acquire a new lock.
> >
> > Signed-off-by: Balasubramanian Manoharan
> > ---
> > include/odp/api/spec/schedu
On 16 June 2017 at 21:14, Honnappa Nagarahalli <
honnappa.nagaraha...@linaro.org> wrote:
> Can you please explain the use case for this API?
>
> We already have odp_schedule_order_unlock and odp_schedule_order_lock.
> These APIs can be used to do the same operation.
>
Yes. This API can be interna
https://bugs.linaro.org/show_bug.cgi?id=3051
Bug ID: 3051
Summary: ./configure has to fail on not recognized option
Product: OpenDataPlane - linux- generic reference
Version: v1.14.0.0
Hardware: Other
OS: Linux
Stat
On 06/14/17 04:21, Brian Brooks wrote:
> Brian Brooks (5):
> test: odp_pktio_ordered: add queue size
> Add arch/ files
> Add a bitset
> Add a concurrent queue
> Add scalable scheduler
Please rename commits with existence commit style. Has to be:
linux-gen: sched scalable: addr arch files
https://bugs.linaro.org/show_bug.cgi?id=3052
Bug ID: 3052
Summary: api-next out of tree build broken
Product: OpenDataPlane - linux- generic reference
Version: v1.14.0.0
Hardware: Other
OS: Linux
Status: UNCONFIRMED
https://bugs.linaro.org/show_bug.cgi?id=3052
Maxim Uvarov changed:
What|Removed |Added
Assignee|bala.manoha...@linaro.org |maxim.uva...@linaro.org
Component|Clas
https://bugs.linaro.org/show_bug.cgi?id=3052
Maxim Uvarov changed:
What|Removed |Added
Assignee|maxim.uva...@linaro.org |petri.savolai...@linaro.org
--
You are receivi
https://bugs.linaro.org/show_bug.cgi?id=3052
--- Comment #1 from Maxim Uvarov ---
Assign to Petri as feature creator of deprecated.h
--
You are receiving this mail because:
You are on the CC list for the bug.
This should still be reviewed by Bala and Nikhil with respect to their
HW, but these changes resolve all of the concerns I had with the
original version. For his series:
Reviewed-by: Bill Fischofer
On Fri, Jun 16, 2017 at 5:49 AM, Petri Savolainen
wrote:
> Applies on top of: "[API-NEXT PATCH v2
51 matches
Mail list logo
