Re: [lng-odp] [PATCH CLOUD-DEV v2 0/3] odp: add modular framework

2017-07-24 Thread Yi He
Hi, Bill, Maxim and community For the checkpatch.pl warnings and errors reported for this PR, I comment each in below to see if they are acceptable, we can discuss in today's call: thanks and best regards, Yi On 24 July 2017 at 14:00, Github ODP bot wrote: > odp: add modular framework > Add mo

Re: [lng-odp] [API-NEXT PATCHv7 1/4] api: timer: add odp_timer_capability() api

2017-07-24 Thread Bill Fischofer
On Wed, Jul 19, 2017 at 10:43 PM, Kevin Wang wrote: > Currently, user needs to decide the timer resolution before creating > a timer pool. But sometimes it will cause timer overrun as the system > can't support such high resolution. > So a new API is required to expose the timer capability to the

Re: [lng-odp] [API-NEXTv4 1/3] api: classification: add support for packet hashing in classification

2017-07-24 Thread Bill Fischofer
BTW, we'll also need extensions to the classifier validation test suite to cover these new APIs as well as User Guide updates. These can be separate patches if desired. On Mon, Jul 24, 2017 at 8:21 PM, Bill Fischofer wrote: > > > On Wed, Jul 19, 2017 at 9:37 PM, Balasubramanian Manoharan < > bal

Re: [lng-odp] [API-NEXTv4 1/3] api: classification: add support for packet hashing in classification

2017-07-24 Thread Bill Fischofer
On Wed, Jul 19, 2017 at 9:37 PM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Enable packet hashing per CoS to be able to distribute incoming packets to > multiple queues linked with a CoS. > > Signed-off-by: Balasubramanian Manoharan > --- > v4: incorporates review comments fr

Re: [lng-odp] [PATCH] doc: userguide: add portability and usage info for odp time apis

2017-07-24 Thread Maxim Uvarov
Merged as discussed today. Maxim. On 06/30/17 00:07, Bill Fischofer wrote: > On Thu, Jun 22, 2017 at 4:50 PM, Brian Brooks wrote: >> On 06/29 16:21:47, Maxim Uvarov wrote: >>> Hello Bill, >>> >>> patch is good. Please see my notes bellow which I think reasonable. >>> >>> >>> On 02/14/17 01:47, B

[lng-odp] [Linaro/odp] f4f767: doc: userguide: add portability and usage info for...

2017-07-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: f4f7679d16917d9a7c1b2220e351fd27733ee96b https://github.com/Linaro/odp/commit/f4f7679d16917d9a7c1b2220e351fd27733ee96b Author: Bill Fischofer Date: 2017-07-24 (Mon, 24 Jul 2017) Changed paths: M doc/u

[lng-odp] [Linaro/odp] 759b6d: changelog: document changes for v1.11.0.1 service ...

2017-07-24 Thread GitHub
Branch: refs/heads/monarch_lts Home: https://github.com/Linaro/odp Commit: 759b6d5da6617af244765983d0b8bfbb26f41890 https://github.com/Linaro/odp/commit/759b6d5da6617af244765983d0b8bfbb26f41890 Author: Bill Fischofer Date: 2017-07-24 (Mon, 24 Jul 2017) Changed paths: M

[lng-odp] [PATCH API-NEXT v5 9/9] fixup! test: validation: add IPsec API testsuite

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.patch ** Base sha: db7cc41aeb559dd296f3a6d8570aa10326a31d5e **

[lng-odp] [PATCH API-NEXT v5 5/9] test: validation: add IPsec API testsuite

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add several basic tests for IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.patch ** Base sha: db7cc

[lng-odp] [PATCH API-NEXT v5 8/9] linux-generic: ipsec: draft IPsec implementation

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov For now it's only a preview with the following limitation: - Only IPv4 support - No pipeline_cls and outer header retaining support - No zeroing of mutable IPv4 options for AH ICV calculation - No replay protection - No ESN support - No UDP encapsulation suppor

[lng-odp] [PATCH API-NEXT v5 7/9] linux-generic: ipsec: implement IPsec SAD

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Implement SA database and SA handling. - only IPv4 is supported for now - no support for time-based limits Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** P

[lng-odp] [PATCH API-NEXT v5 6/9] linux-generic: ipsec: implement events handling

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add functions implementing IPsec events support. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.patch ** Base

[lng-odp] [PATCH API-NEXT v5 4/9] linux-gen: packet: add support for IP-in-IP (RFC 2003) encap

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Don't barf on IP-in-IP packets parsing, just ignore L4 (=L3) header. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pul

[lng-odp] [PATCH API-NEXT v5 1/9] linux-gen: pktio: loop: support IPsec outbound inline

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add support for outbound inline IPsec packet processing on loop interface. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/o

[lng-odp] [PATCH API-NEXT v5 3/9] linux-gen: packet: factor out L2 header parsing

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Function parse_packet_common() now becomes just a multiplexer calling other low-level parsing functions. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patc

[lng-odp] [PATCH API-NEXT v5 2/9] linux-gen: pktio: loop: support IPsec inbound inline

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add support for inbound inline IPsec packet processing on loop interface. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/od

[lng-odp] [PATCH API-NEXT v5 0/9] IPsec implementation based on packet interface

2017-07-24 Thread Github ODP bot
This PR replaces #28 by providing new IPsec implementation based on latest API additions. github /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.pa

[lng-odp] Change in lng/odp[master]: pkg/debian: build depend on libcunit1-dev

2017-07-24 Thread Riku Voipio (Code Review)
Riku Voipio has abandoned this change. ( https://review.linaro.org/11249 ) Change subject: pkg/debian: build depend on libcunit1-dev .. Abandoned Conflict and no interest -- To view, visit https://review.linaro.org/11249 To uns

[lng-odp] [PATCH API-NEXT v4 4/7] test: validation: add IPsec API testsuite

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add several basic tests for IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.patch ** Base sha: db7cc

[lng-odp] [PATCH API-NEXT v4 7/7] linux-generic: ipsec: draft IPsec implementation

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov For now it's only a preview with the following limitation: - Only IPv4 support - No pipeline_cls and outer header retaining support - No zeroing of mutable IPv4 options for AH ICV calculation - No replay protection - No ESN support - No UDP encapsulation suppor

[lng-odp] [PATCH API-NEXT v4 5/7] linux-generic: ipsec: implement events handling

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add functions implementing IPsec events support. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.patch ** Base

[lng-odp] [PATCH API-NEXT v4 6/7] linux-generic: ipsec: implement IPsec SAD

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Implement SA database and SA handling. - only IPv4 is supported for now - no support for time-based limits Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** P

[lng-odp] [PATCH API-NEXT v4 1/7] linux-gen: pktio: loop: support IPsec outbound inline

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add support for outbound inline IPsec packet processing on loop interface. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/o

[lng-odp] [PATCH API-NEXT v4 3/7] linux-gen: packet: factor out L2 header parsing

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Function parse_packet_common() now becomes just a multiplexer calling other low-level parsing functions. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patc

[lng-odp] [PATCH API-NEXT v4 2/7] linux-gen: pktio: loop: support IPsec inbound inline

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add support for inbound inline IPsec packet processing on loop interface. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/od

[lng-odp] [PATCH API-NEXT v1 0/1] api: crypto: clarify compl_queue queue in crypto_session_param

2017-07-24 Thread Github ODP bot
Properly mention odp_crypto_operation() in the compl_queue param description. Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org github /** Email created from pull request 85 (lumag:crypto-fix) ** https://github.com/Linaro/odp/pull/85

[lng-odp] [PATCH API-NEXT v4 0/7] IPsec implementation based on packet interface

2017-07-24 Thread Github ODP bot
This PR replaces #28 by providing new IPsec implementation based on latest API additions. github /** Email created from pull request 81 (lumag:ipsec-packet-impl-2) ** https://github.com/Linaro/odp/pull/81 ** Patch: https://github.com/Linaro/odp/pull/81.pa

[lng-odp] [PATCH API-NEXT v1 1/1] api: crypto: clarify compl_queue queue in crypto_session_param

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Properly mention odp_crypto_operation() in the compl_queue param description. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 85 (lumag:crypto-fix) ** https://github.com/Linaro/odp/pull/85 ** Patch: https://github.com/Linaro/odp/pul

[lng-odp] [API-NEXTv4 3/3] linux-generic: classification implement packet hashing

2017-07-24 Thread Balasubramanian Manoharan
implementation for packet hashing on classification Signed-off-by: Balasubramanian Manoharan --- .../include/odp_classification_datamodel.h | 32 +++- .../include/odp_classification_internal.h | 7 + platform/linux-generic/odp_classification.c| 198 ++-

[lng-odp] [API-NEXTv4 2/3] linux-generic: add toeplitz hash algorithm

2017-07-24 Thread Balasubramanian Manoharan
Adds toeplitz hash algorithm implementation for RSS hashing Signed-off-by: Balasubramanian Manoharan --- platform/linux-generic/include/protocols/thash.h | 108 +++ 1 file changed, 108 insertions(+) create mode 100644 platform/linux-generic/include/protocols/thash.h diff --

[lng-odp] [API-NEXTv4 1/3] api: classification: add support for packet hashing in classification

2017-07-24 Thread Balasubramanian Manoharan
Enable packet hashing per CoS to be able to distribute incoming packets to multiple queues linked with a CoS. Signed-off-by: Balasubramanian Manoharan --- v4: incorporates review comments from Petri include/odp/api/spec/classification.h | 83 --- 1 file changed,

Re: [lng-odp] [API-NEXT PATCHv7 1/4] api: timer: add odp_timer_capability() api

2017-07-24 Thread Brian Brooks
Reviewed-by: Brian Brooks On Wed, Jul 19, 2017 at 10:43 PM, Kevin Wang wrote: > Currently, user needs to decide the timer resolution before creating > a timer pool. But sometimes it will cause timer overrun as the system > can't support such high resolution. > So a new API is required to expose

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

2017-07-24 Thread Dmitry Eremin-Solenikov
On 24/07/17 15:28, shally verma wrote: > On Mon, Jul 24, 2017 at 5:55 PM, Dmitry Eremin-Solenikov > wrote: >> On 24/07/17 15:12, shally verma wrote: >>> On Mon, Jul 24, 2017 at 5:27 PM, Dmitry Eremin-Solenikov >>> wrote: On 24/07/17 14:11, shally verma wrote: > On Tue, Jul 11, 2017 at 7:

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

2017-07-24 Thread shally verma
On Mon, Jul 24, 2017 at 5:55 PM, Dmitry Eremin-Solenikov wrote: > On 24/07/17 15:12, shally verma wrote: >> On Mon, Jul 24, 2017 at 5:27 PM, Dmitry Eremin-Solenikov >> wrote: >>> On 24/07/17 14:11, shally verma wrote: On Tue, Jul 11, 2017 at 7:30 PM, Github ODP bot wrote: > From: Dmitry

Re: [lng-odp] regarding packet pool creation

2017-07-24 Thread shally verma
On Mon, Jul 24, 2017 at 5:44 PM, Bill Fischofer wrote: > I should also point out that the pool min_seg_len does not mean that this is > the minimum segment size that an application can see. You mean pool_capa.pkt.min_seg_len param? There are lots of ways > for segments to wind up smaller than th

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

2017-07-24 Thread Dmitry Eremin-Solenikov
On 24/07/17 15:12, shally verma wrote: > On Mon, Jul 24, 2017 at 5:27 PM, Dmitry Eremin-Solenikov > wrote: >> On 24/07/17 14:11, shally verma wrote: >>> On Tue, Jul 11, 2017 at 7:30 PM, Github ODP bot wrote: From: Dmitry Eremin-Solenikov >> @@ -311,16 +315,15 @@ typedef struct odp_cryp

Re: [lng-odp] regarding packet pool creation

2017-07-24 Thread Bill Fischofer
I should also point out that the pool min_seg_len does not mean that this is the minimum segment size that an application can see. There are lots of ways for segments to wind up smaller than this, but mostly as a result of application actions (e.g., splitting a packet, creating references with shor

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

2017-07-24 Thread shally verma
On Mon, Jul 24, 2017 at 5:27 PM, Dmitry Eremin-Solenikov wrote: > On 24/07/17 14:11, shally verma wrote: >> On Tue, Jul 11, 2017 at 7:30 PM, Github ODP bot wrote: >>> From: Dmitry Eremin-Solenikov > >>> @@ -311,16 +315,15 @@ typedef struct odp_crypto_session_param_t { >>> >>> /** Async m

Re: [lng-odp] regarding packet pool creation

2017-07-24 Thread Bill Fischofer
An application cannot require that an ODP implementation segment packets. Segmentation is a feature of some implementations and the ODP concepts surrounding segments are there to permit application portability across different implementations that use segmentation. >From an application standpoint,

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

2017-07-24 Thread Dmitry Eremin-Solenikov
On 24/07/17 14:11, shally verma wrote: > On Tue, Jul 11, 2017 at 7:30 PM, Github ODP bot wrote: >> From: Dmitry Eremin-Solenikov >> @@ -311,16 +315,15 @@ typedef struct odp_crypto_session_param_t { >> >> /** Async mode completion event queue >> * >> -* When odp_crypto_o

Re: [lng-odp] regarding packet pool creation

2017-07-24 Thread shally verma
Resending. On Mon, Jul 24, 2017 at 5:01 PM, shally verma wrote: > Have a question regarding packet pool creation and params. As it says in > pool.h > > len = minimum length of pakcet > seg_len = minimum length of 1st segment to hold packet data bytes > > Since it says minimum, so actual segment

[lng-odp] regarding packet pool creation

2017-07-24 Thread shally verma
Have a question regarding packet pool creation and params. As it says in pool.h len = minimum length of pakcet seg_len = minimum length of 1st segment to hold packet data bytes Since it says minimum, so actual segment size used to hold packet data size may be more than this. So if I want to crea

Re: [lng-odp] [PATCH API-NEXT v9 6/10] api: crypto: add crypto packet operation interface

2017-07-24 Thread shally verma
On Tue, Jul 11, 2017 at 7:30 PM, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > Input and output of crypto operations are packets. API is more flexible > for application and API pipelining when output is packet with additional > metadata. Application or API pipeline stages which do not

[lng-odp] [PATCH API-NEXT v11 1/1] test: validation: add IPsec API testsuite

2017-07-24 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Add several basic tests for IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 ** Patch: https://github.com/Linaro/odp/pull/70.patch ** Base sha: db7cc41

[lng-odp] [PATCH API-NEXT v11 0/1] test: validation: add IPsec API testsuite

2017-07-24 Thread Github ODP bot
Add several basic tests for IPsec API. This PR incorporates #69 and event subtypes implementation on which it depends. github /** Email created from pull request 70 (lumag:ipsec-testsuite-2) ** https://github.com/Linaro/odp/pull/70 ** Patch: https://githu