Re: [lng-odp] [PATCH API-NEXT v1] API: pool: Return address range for pool objects

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: include/odp/api/spec/pool.h line 11 @@ -172,7 +172,20 @@ int odp_pool_capability(odp_pool_capability_t *capa); typedef struct odp_pool_param_t { /** Pool type */ int type; - + /** Flag to indicate whether

Re: [lng-odp] [PATCH API-NEXT v1] API: pool: Return address range for pool objects

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: include/odp/api/spec/pool.h line 16 @@ -172,7 +172,20 @@ int odp_pool_capability(odp_pool_capability_t *capa); typedef struct odp_pool_param_t { /** Pool type */ int type; - + /** Flag to indicate whether

Re: [lng-odp] generic core + HW specific drivers

The approach taken by Vulkan project: https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/blob/master/loader/LoaderAndLayerInterface.md On Tue, Oct 3, 2017 at 6:52 PM, Dmitry Eremin-Solenikov wrote: > On 03/10/17 11:12, Savolainen, Petri (Nokia -

Re: [lng-odp] [PATCH API-NEXT v1] API: pool: Return address range for pool objects

Dmitry Eremin-Solenikov(lumag) replied on github web page: include/odp/api/spec/pool.h line 11 @@ -172,7 +172,20 @@ int odp_pool_capability(odp_pool_capability_t *capa); typedef struct odp_pool_param_t { /** Pool type */ int type; - + /** Flag to indicate whether user is

Re: [lng-odp] [PATCH API-NEXT v1] API: pool: Return address range for pool objects

Dmitry Eremin-Solenikov(lumag) replied on github web page: include/odp/api/spec/pool.h line 16 @@ -172,7 +172,20 @@ int odp_pool_capability(odp_pool_capability_t *capa); typedef struct odp_pool_param_t { /** Pool type */ int type; - + /** Flag to indicate whether user is

Re: [lng-odp] generic core + HW specific drivers

On 03/10/17 11:12, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Ola >> Liljedahl >> Sent: Friday, September 29, 2017 8:47 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] generic core + HW

Re: [lng-odp] [PATCH v1] timer cleanup

brbrooks replied on github web page: platform/linux-generic/include/odp/api/plat/timer_types.h line 5 @@ -24,9 +24,9 @@ extern "C" { * @{ **/ -struct odp_timer_pool_s; /**< Forward declaration */ +struct _timer_pool_s; /**< Forward declaration */ Comment: I recommend we modify the Coding

Re: [lng-odp] [PATCH v1] timer cleanup

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp/api/plat/timer_types.h line 5 @@ -24,9 +24,9 @@ extern "C" { * @{ **/ -struct odp_timer_pool_s; /**< Forward declaration */ +struct _timer_pool_s; /**< Forward declaration */ Comment: The

Re: [lng-odp] generic core + HW specific drivers

I would leave it tu SoC vendors that can define a reliable and sustainable method... Le mar. 3 oct. 2017 à 22:26, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> a écrit : > On 3 October 2017 at 08:51, Francois Ozog > wrote: > > Hi Maxim, > > > > Modularization

Re: [lng-odp] generic core + HW specific drivers

On 3 October 2017 at 08:51, Francois Ozog wrote: > Hi Maxim, > > Modularization is configurable so that the produced output can be either: > - runtime selection of modules based on whatever discovery mechanism is > available > - fixed compilation of a set of modules > >

Re: [lng-odp] generic core + HW specific drivers

On 3 October 2017 at 07:59, Bill Fischofer wrote: > Good summary. The key is that RedHat and others want: > > 1. They build the distribution from source we provide, we don't get to > provide any binaries > 2. There is a single distribution they will support per-ISA

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

Hi, See comments inline -Original Message- From: Bala Manoharan [mailto:bala.manoha...@linaro.org] Sent: Tuesday, October 03, 2017 21:13 To: Bill Fischofer Cc: Liron Himi ; lng-odp@lists.linaro.org Subject: Re: [EXT] Re: [lng-odp]

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

Yes. This is an implementation bug. Will fix the bug. Minor correction, when classifier_enabled is set the current design is to create all the queues in a single shot rather than as needed since it will create network jitter if queues are created at random. Regards, Bala On 3 October 2017 at

Re: [lng-odp] generic core + HW specific drivers

Great questions, Maxim. What we mean by discovery is anything that isn't known or preconfigured at compile time. In the case of embedded applications they can typically be compiled for a specific target platform that has known characteristics. Moving to another platform means recompiling the

[lng-odp] [PATCH v1 3/4] linux-gen: timer: drop odp prefix from odp_timer_pool_s

From: Maxim Uvarov internal structure should not be named with odp_. Also make code a little bit more consistent to pass type instead of struct to 2 more functions. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 205

[lng-odp] [PATCH v1 4/4] linux-gen: timer: drop odp prefix from odp_timer_s

From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 205 (muvarov:master_timer_cleanup) ** https://github.com/Linaro/odp/pull/205 ** Patch: https://github.com/Linaro/odp/pull/205.patch ** Base sha:

[lng-odp] [PATCH v1 2/4] linux-gen: timer: drop odp prefix from odp_timer_pool

From: Maxim Uvarov internal data type should not be named with odp api prefix. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 205 (muvarov:master_timer_cleanup) ** https://github.com/Linaro/odp/pull/205 ** Patch:

[lng-odp] [PATCH v1 1/4] linux-gen: timer: drop odp prefix from odp_timer_pool_new

From: Maxim Uvarov Internal static function does not need odp_ prefix. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 205 (muvarov:master_timer_cleanup) ** https://github.com/Linaro/odp/pull/205 ** Patch:

[lng-odp] [PATCH v1 0/4] timer cleanup

No functional changes just clean up naming. This file also needs some rework, which can be done as separate patches. github /** Email created from pull request 205 (muvarov:master_timer_cleanup) ** https://github.com/Linaro/odp/pull/205 ** Patch:

Re: [lng-odp] generic core + HW specific drivers

Hey, Please see below. On 03.10.2017 10:12, Savolainen, Petri (Nokia - FI/Espoo) wrote: So, we should be able to deliver ODP as a set of HW independent and HW specific packages (libraries). For example, minimal install would include only odp, odp-linux and odp-test-suite, but when on arm64

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

Thanks Liron, I've checked the code and that seems to be another issue. The intent is that when classifier_enable is set the ODP classifier creates queues as needed. +cc Bala for additional commentary. On Tue, Oct 3, 2017 at 8:48 AM, Liron Himi wrote: > Hi Bill, > > > > I

Re: [lng-odp] generic core + HW specific drivers

Hi Maxim, Modularization is configurable so that the produced output can be either: - runtime selection of modules based on whatever discovery mechanism is available - fixed compilation of a set of modules As per the discovery, I would favor a similar approach to packetio: give an opportunity to

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

Hi Bill, I opened ‘https://bugs.linaro.org/show_bug.cgi?id=3289’ for this issue. I think there is another issue related to this topic in case PKTIO was configure in schedule mode. The ‘start’ function assumes ‘num_in_queue’ is bigger than ‘0’ but in the classifier_enable case it is ‘0’ so

[lng-odp] [Bug 3289] New: [PKTIO] 'num_queues' isn't ignored when ''classifier_enable' is enabled

https://bugs.linaro.org/show_bug.cgi?id=3289 Bug ID: 3289 Summary: [PKTIO] 'num_queues' isn't ignored when ''classifier_enable' is enabled Product: OpenDataPlane - linux- generic reference Version: v1.15.0.0 Hardware: All

Re: [lng-odp] generic core + HW specific drivers

On 3 October 2017 at 15:59, Bill Fischofer wrote: > Good summary. The key is that RedHat and others want: > > 1. They build the distribution from source we provide, we don't get to > provide any binaries > 2. There is a single distribution they will support per-ISA

Re: [lng-odp] generic core + HW specific drivers

Good summary. The key is that RedHat and others want: 1. They build the distribution from source we provide, we don't get to provide any binaries 2. There is a single distribution they will support per-ISA (e.g., AArch64) The modular framework is designed to accommodate these requirements by

Re: [lng-odp] [PATCH v1] linux-gen: User /proc/cpuinfo, if sysfs is not available.

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/odp_system_info.c line 13 @@ -378,14 +378,57 @@ int odp_system_info_term(void) return 0; } +static uint64_t get_cpuspeed(int id) +{ + char str[1024]; + char *pos; + FILE *file =

Re: [lng-odp] Code review and discussion on mailing list only

On 3 October 2017 at 14:20, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Tuesday, October 03, 2017 12:50 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: lng-odp-forward

Re: [lng-odp] Code review and discussion on mailing list only

From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Tuesday, October 03, 2017 12:50 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: lng-odp-forward Subject: Re: [lng-odp] Code review and discussion on mailing list only On 2

Re: [lng-odp] generic core + HW specific drivers

Thanks Ola and Petri. Let's talk about use cases first. Go to market for ODP applications may be: - A product composed of software and hardware (typically a NEP approach such as Nokia) - A software to be installed by a system administrator of an enterprise - A "service" to be part

[lng-odp] [Linaro/odp] 0ff786: linux-gen: split arm into arm and aarch64

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 0ff7861b8a958b5e23adc5b13783aeeff0629e03 https://github.com/Linaro/odp/commit/0ff7861b8a958b5e23adc5b13783aeeff0629e03 Author: Dmitry Eremin-Solenikov Date: 2017-10-03

Re: [lng-odp] [PATCH v1 1/1] linux-gen: User /proc/cpuinfo, if sysfs is not available. Fixes https://bugs.linaro.org/show_bug.cgi?id=3249

if you will send v2 please refer to original commit from which you restored that function (or which reverted it.) On 3 October 2017 at 12:37, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp

[lng-odp] [Linaro/odp] 0ff786: linux-gen: split arm into arm and aarch64

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 0ff7861b8a958b5e23adc5b13783aeeff0629e03 https://github.com/Linaro/odp/commit/0ff7861b8a958b5e23adc5b13783aeeff0629e03 Author: Dmitry Eremin-Solenikov Date: 2017-10-03

Re: [lng-odp] Code review and discussion on mailing list only

On 2 October 2017 at 17:53, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > Let's stop using Github for code review and design discussions. Mailing > list is far more flexible and robust for human-to-human interaction than a > web-based tool. We can continue to

Re: [lng-odp] [PATCH v1 1/1] linux-gen: User /proc/cpuinfo, if sysfs is not available. Fixes https://bugs.linaro.org/show_bug.cgi?id=3249

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Tuesday, October 03, 2017 11:00 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH v1 1/1] linux-gen: User /proc/cpuinfo, if sysfs > is not available. Fixes

Re: [lng-odp] generic core + HW specific drivers

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Ola > Liljedahl > Sent: Friday, September 29, 2017 8:47 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] generic core + HW specific drivers > > olli@vubuntu:~$ dpkg --get-selections | grep

[lng-odp] [PATCH v1 1/1] linux-gen: User /proc/cpuinfo, if sysfs is not available. Fixes https://bugs.linaro.org/show_bug.cgi?id=3249

From: Ilias Apalodimas Signed-off-by: Ilias Apalodimas --- /** Email created from pull request 204 (apalos:bug_3249) ** https://github.com/Linaro/odp/pull/204 ** Patch: https://github.com/Linaro/odp/pull/204.patch ** Base sha:

[lng-odp] [PATCH v1 0/1] linux-gen: User /proc/cpuinfo, if sysfs is not available.

Fixes https://bugs.linaro.org/show_bug.cgi?id=3249 Signed-off-by: Ilias Apalodimas ilias.apalodi...@linaro.org github /** Email created from pull request 204 (apalos:bug_3249) ** https://github.com/Linaro/odp/pull/204 ** Patch: