Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
include/odp/api/spec/classification.h
line 38
@@ -107,6 +108,55 @@ typedef union odp_cls_pmr_terms_t {
uint64_t all_bits;
} odp_cls_pmr_terms_t;
+/** Random Early Detection (RED)
+ * Random Early Detection is enabled to i
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/include/odp/api/plat/packet_inlines.h
line 5
@@ -21,6 +21,9 @@
/** @internal Inline function offsets */
extern const _odp_packet_inline_offset_t _odp_packet_inline;
+/** @internal Pool inline function offs
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/include/odp/api/plat/pool_types.h
line 16
@@ -48,6 +48,19 @@ typedef enum odp_pool_type_t {
#endif
+/** @internal Pool field accessor */
+#define _odp_pool_get(pool, cast, field) \
+ (*(cast *)(uint
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/include/odp_buffer_internal.h
line 4
@@ -104,17 +104,10 @@ struct odp_buffer_hdr_t {
/* User area pointer */
void*uarea_addr;
- /* User area size */
Comment:
2.0 is based on api-n
On Mon, Nov 13, 2017 at 9:26 AM, Honnappa Nagarahalli <
honnappa.nagaraha...@linaro.org> wrote:
> On 10 November 2017 at 05:35, Dmitry Eremin-Solenikov
> wrote:
> > Hello,
> >
> > Historically ODP helper provided protocol-related headers with
> > linux-generic ODP implementation using modified pr
muvarov replied on github web page:
helper/include/odp/helper/chksum.h
line 21
@@ -44,21 +44,7 @@ typedef enum {
*/
static inline odp_u16sum_t odph_chksum(void *buffer, int len)
{
- uint16_t *buf = (uint16_t *)buffer;
- uint32_t sum = 0;
- uint16_t result;
-
- for (sum
I have seen this issue. But, I have not characterized any performance
impact of this. But most of the memory required is for packets
(depends on application as well) which comes from DPDK.
Feel free to submit a PR to fix the issue.
Thanks,
Honnappa
On 13 November 2017 at 03:37, gyanesh patra wr
On 10 November 2017 at 04:38, Dmitry Eremin-Solenikov
wrote:
> 10 нояб. 2017 г. 13:22 пользователь "Maxim Uvarov"
> написал:
>
> I see that dpdk started to support abi versions in following ways
>
> I.e. they describe in .map file which functions to expert and what ABI/API
> level they are.
> We
I would prefer to follow this approach to support deprecated features
(for few more releases providing the opportunity for the application
to change) between different versions of ODP rather than having
--enable-deprecated. This feature will allow for structure definitions
also to differ.
On 10 No
On 10 November 2017 at 05:35, Dmitry Eremin-Solenikov
wrote:
> Hello,
>
> Historically ODP helper provided protocol-related headers with
> linux-generic ODP implementation using modified private copy of them.
> The main reason for that was, if I remember correctly, that ODP should
> not provide pr
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/threshold.h
@@ -0,0 +1,89 @@
+/* Copyright (c) 2017, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+/**
+ * @file
+ *
+ * ODP threshold descriptor
+ */
+
+#ifndef ODP_API_TH
JannePeltonen replied on github web page:
doc/images/ipsec_fsm.gv
line 1
@@ -0,0 +1,32 @@
+digraph ipsec_state_machine {
Comment:
I do not quite understand the SA state machine picture, maybe because I think
it tries to include different kind of states (global IPsec subsystem state,
IPsec SA s
Balasubramanian Manoharan(bala-manoharan) replied on github web page:
include/odp/api/spec/std_types.h
line 9
@@ -32,6 +32,13 @@ extern "C" {
*/
/**
+ * @typedef odp_percent_t
+ * Use odp_percent_t for specifying fields that are percentages. It is a fixed
+ * point integer whose units are exp
muvarov replied on github web page:
include/odp/api/ipsec.h
line 7
@@ -10,22 +10,14 @@
* ODP IPSEC API - platform specific header
*/
-#ifndef ODP_PLAT_IPSEC_H_
-#define ODP_PLAT_IPSEC_H_
+#ifndef ODP_API_IPSEC_H_
+#define ODP_API_IPSEC_H_
Comment:
it will be good to name defines without OD
Dmitry Eremin-Solenikov(lumag) replied on github web page:
include/odp/api/ipsec.h
line 7
@@ -10,22 +10,14 @@
* ODP IPSEC API - platform specific header
*/
-#ifndef ODP_PLAT_IPSEC_H_
-#define ODP_PLAT_IPSEC_H_
+#ifndef ODP_API_IPSEC_H_
+#define ODP_API_IPSEC_H_
Comment:
Hmm. They are part
Balasubramanian Manoharan(bala-manoharan) replied on github web page:
include/odp/api/spec/classification.h
line 38
@@ -107,6 +108,55 @@ typedef union odp_cls_pmr_terms_t {
uint64_t all_bits;
} odp_cls_pmr_terms_t;
+/** Random Early Detection (RED)
+ * Random Early Detection is enabled
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/classification.h
line 38
@@ -107,6 +108,55 @@ typedef union odp_cls_pmr_terms_t {
uint64_t all_bits;
} odp_cls_pmr_terms_t;
+/** Random Early Detection (RED)
+ * Random Early Detection is enabled to initiate a dro
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/threshold.h
@@ -0,0 +1,89 @@
+/* Copyright (c) 2017, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+/**
+ * @file
+ *
+ * ODP threshold descriptor
+ */
+
+#ifndef ODP_API_TH
Dmitry Eremin-Solenikov(lumag) replied on github web page:
helper/include/odp/helper/chksum.h
line 21
@@ -44,21 +44,7 @@ typedef enum {
*/
static inline odp_u16sum_t odph_chksum(void *buffer, int len)
{
- uint16_t *buf = (uint16_t *)buffer;
- uint32_t sum = 0;
- uint16_t resu
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
From: Dmitry Eremin-Solenikov
Some paths during odp_ipsec_sa_create() can lead to SA leakage. Fix
them by always releasing SA in error case.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
From: Dmitry Eremin-Solenikov
Add support for encrypting packets with AES-CTR cipher.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.patch
From: Dmitry Eremin-Solenikov
Generated outer header should have frag_offset = 0, MF = 0. Change code
accordingly.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.
From: Dmitry Eremin-Solenikov
Add new ipsec_err error flag, which is set by IPsec code if there was an
error during IPsec packet processing. This allow application code to
quickly check packets using odp_packet_has_error() function and use fast
path if there was none.
Signed-off-by: Dmitry Eremi
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
From: Dmitry Eremin-Solenikov
Check that IP packet length from the header is not bogus.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.pat
From: Dmitry Eremin-Solenikov
Verify that odp_packet_has_error() returns true for IPsec packets with
error status in result.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
From: Dmitry Eremin-Solenikov
Split count expiration check into two phases:
- optional precheck, run before crypto, which fails only if hard limit
is already breached
- update, run after crypto in INBOUND case, so that limits will not be
updated for packets failing ICV check.
Signed-off-
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
From: Dmitry Eremin-Solenikov
Verify inline_mode flag being set for inbound inline packets.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243
security fix for GCM mode: proper IV generation
implementation of 32-bit replay window support
implementation of PIPELINE_CLS support
github
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Pa
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://github.com/Linaro/odp/pull/243.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
From: Dmitry Eremin-Solenikov
Set IPsec inline_mode_flag for inbound inline packets according to the
API specification.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://github.com/Linaro/odp/pull/243
** Patch: https://gi
From: Dmitry Eremin-Solenikov
Reusing IV block with GCM results in disastrous consequences. Use
counter instead of random-generated IV to remove possibility for IV
reuse.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 243 (lumag:ipsec-packet-impl-3)
** https://g
From: Dmitry Eremin-Solenikov
session->auth.bytes duplicates session->p.auth_digest_len, so let's drop
first field.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp
From: Dmitry Eremin-Solenikov
Implement AES-GMAC authentication support for AH.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288.patch
** Base sha: a908a4
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
** Merge commit
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288.patch
** Base sha: a908a4dead95321e84d6a8a23de060051dcd8969
** Merge commit
From: Dmitry Eremin-Solenikov
Add check through auth capabilities, verifying that key length is
supported.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288
From: Dmitry Eremin-Solenikov
Add AES-GMAC-ESP testcase based on draft-mcgrew-gcm-test-01.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288.patch
** Base
From: Dmitry Eremin-Solenikov
Implement AES-GMAC-ESP support.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288.patch
** Base sha: a908a4dead95321e84d6a8a2
From: Dmitry Eremin-Solenikov
Implement AES-GMAC on top of OpenSSL AES-GCM with all text going into
AAD part.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/
From: Dmitry Eremin-Solenikov
Add AES-GMAC test vector based on draft-mcgrew-gcm-test-01.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288.patch
** Base s
From: Dmitry Eremin-Solenikov
Add AES-GMAC declarations to support RFC4543.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: https://github.com/Linaro/odp/pull/288.patch
** Base sha: a908a4dead
From: Dmitry Eremin-Solenikov
Some paths during odp_ipsec_sa_create() can lead to SA leakage. Fix
them by always releasing SA in error case.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch: http
From: Dmitry Eremin-Solenikov
Reusing IV block with GCM results in disastrous consequences. Use
counter instead of random-generated IV to remove possibility for IV
reuse.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linar
This is an example of AES-GMAC(-ESP) implementation. Plaintext is passed as
normal packet, IV/salt are passed according to the rest of API. This
incorporates one commit from #243.
github
/** Email created from pull request 288 (lumag:gmac)
** https://gith
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/std_types.h
line 9
@@ -32,6 +32,13 @@ extern "C" {
*/
/**
+ * @typedef odp_percent_t
+ * Use odp_percent_t for specifying fields that are percentages. It is a fixed
+ * point integer whose units are expressed as one-hun
muvarov replied on github web page:
helper/include/odp/helper/chksum.h
line 21
@@ -44,21 +44,7 @@ typedef enum {
*/
static inline odp_u16sum_t odph_chksum(void *buffer, int len)
{
- uint16_t *buf = (uint16_t *)buffer;
- uint32_t sum = 0;
- uint16_t result;
-
- for (sum
Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 70
@@ -1372,10 +1382,10 @@ static int dpdk_recv(pktio_entry_t *pktio_entry, int
index,
if (!pkt_dpdk->lockless_rx)
odp_ticketlock_lock(&pkt_dpdk->rx_lock[index]);
/**
-
Hi,
I have noticed that ODP application always check for hugepages and fails
though hugepage is configured in the system. And it runs normally using
normal pages. I am not sure it affects the performance or not. But if it
does, how can i make sure that ODP application uses the hugepages???
I am ad
From: Bogdan Pricope
Add checksum insertion override functionality to dpdk pktio.
Override is applied based on L3/L4 checksum insert override output flags
from the packet.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 245 (bogdanPricope:api_next_ovr_csum_ref_pr)
** http
From: Bogdan Pricope
The functions set L3/L4 checksum override output flags on the packet.
Checksum calculation, if requested, is perfromed at packet output time,
depending on interface capabilities.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 245 (bogdanPricope:api_ne
Implement checksum insertion override generic functions and processing for dpdk
pktio.
github
/** Email created from pull request 245 (bogdanPricope:api_next_ovr_csum_ref_pr)
** https://github.com/Linaro/odp/pull/245
** Patch: https://github.com/Linaro/od
56 matches
Mail list logo
