From: Bill Fischofer
Replace the FSMs used to describe SA state transitions and IPsec
operations with a Message Sequence Diagram (MSC) that shows the
same information in an easier to follow form.
Update User Guide to reflect these changes as well.
Signed-off-by: Bill
Replace the FSMs used to describe SA state transitions and IPsec
operations with a Message Sequence Diagram (MSC) that shows the
same information in an easier to follow form.
Update User Guide to reflect these changes as well.
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=3517
--- Comment #1 from Dmitry Eremin-Solenikov
---
Got the same issue with Shippable:
https://app.shippable.com/github/Linaro/odp/runs/325/1/console
--
You are receiving this mail because:
You are on the CC list for
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Support checking MTU after IPsec transformation.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
Test vectors from draft-mcgrew-gcm-test-01 contain invalid next_header
field in ESP trailers (0x01 = ICMP instead of 0x04 = IPv4). Correct test
vectors. Test 12 is disabled till NoNH packets are properly supported in
a defined way.
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Pass checksum and protocol parsing flags to packet parsing code.
Checksum checks are not yet implemented by odp_packet_parse, it will be
done later.
Signed-off-by: Dmitry Eremin-Solenikov
---
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
pkt_out can be NULL if we expect an error. IPsec outbound inline needs
proper outer header to function. Pass L2 header from inbound packet if
outbound packet is NULL.
Signed-off-by: Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Implement support for handling IPv6 packets and IPv6 tunnels.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
To ease adding IPv6/IPcomp/etc modularize IPsec implementation,
refactoring out functions handling ESP/AH and header parsing/tunneling.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email
From: Dmitry Eremin-Solenikov
In preparation to add IPv6 support, add ipv4 everywhere (to test packets
and to test names).
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Such include adds unnecessary build dependencies. Just include
, which is enough.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
This adds support for handling of IPv6 packets and IPv6 tunnels.
github
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch: https://github.com/Linaro/odp/pull/304.patch
** Base sha:
From: Dmitry Eremin-Solenikov
Usign odp_proto_layer_t for parse layer spec is more logical, as it is
the same enum that is used for the reset of packet parsing API.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email
From: Dmitry Eremin-Solenikov
Use odp_proto_layer_t to specify outer header retention level. Drop
separate odp_ipsec_proto_layer_t.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 336
From: Dmitry Eremin-Solenikov
Validation tests examine API thoroughly. Compile and execute them before
performance and misc tests.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 337
github
/** Email created from pull request 336 (lumag:ipsec-proto-layer)
** https://github.com/Linaro/odp/pull/336
** Patch: https://github.com/Linaro/odp/pull/336.patch
** Base sha: d96a8207591fbcaac25b79286d7d72a537354c1f
** Merge commit sha:
Validation tests examine API thoroughly. Compile and execute them before
performance and misc tests.
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsoleni...@linaro.org
github
/** Email created from pull request 337 (lumag:tests-vald)
**
https://bugs.linaro.org/show_bug.cgi?id=3465
--- Comment #2 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/ffcd7991e44109464fb8a71f9ee10546ea5b84b0
refs/heads/master
2017-12-12T23:13:49+03:00
Bill Fischofer bill.fischo...@linaro.org
linux-generic: pool:
Branch: refs/heads/master
Home: https://github.com/Linaro/odp
Commit: ffcd7991e44109464fb8a71f9ee10546ea5b84b0
https://github.com/Linaro/odp/commit/ffcd7991e44109464fb8a71f9ee10546ea5b84b0
Author: Bill Fischofer
Date: 2017-12-12 (Tue, 12 Dec 2017)
Branch: refs/heads/devel/caterpillar
Home: https://github.com/Linaro/odp
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 21ed0fc8045e32e3263f5782401dbfe860152965
https://github.com/Linaro/odp/commit/21ed0fc8045e32e3263f5782401dbfe860152965
Author: Petri Savolainen
Date: 2017-12-12 (Tue, 12 Dec
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 87d47c93d93ed934af9502937d2aceaec59d229a
https://github.com/Linaro/odp/commit/87d47c93d93ed934af9502937d2aceaec59d229a
Author: Petri Savolainen
Date: 2017-12-12 (Tue, 12 Dec
Dmitry Eremin-Solenikov(lumag) replied on github web page:
test/m4/validation.m4
line 14
@@ -31,3 +31,14 @@ AM_CONDITIONAL([test_vald], [test "x$test_vald" = "xyes"])
AC_SUBST([CUNIT_CFLAGS])
AC_SUBST([CUNIT_LIBS])
+
+AC_ARG_ENABLE([cunit_out_xml],
+
Dmitry Eremin-Solenikov(lumag) replied on github web page:
test/common/odp_cunit_common.h
line 10
@@ -15,8 +15,11 @@
#include
#include
-#include "CUnit/Basic.h"
-#include "CUnit/TestDB.h"
+#include
+#include
+#if TEST_CUNIT_XML
+#include
+#endif
Comment:
No need to hide it under `#if`
Dmitry Eremin-Solenikov(lumag) replied on github web page:
test/common/odp_cunit_common.c
@@ -291,13 +294,30 @@ static int cunit_update_suite(odp_suiteinfo_t
*updated_sinfo)
int odp_cunit_run(void)
{
int ret;
+#ifdef TEST_CUNIT_XML
+ char name[255];
+#endif
Dmitry Eremin-Solenikov(lumag) replied on github web page:
test/m4/validation.m4
line 9
@@ -31,3 +31,14 @@ AM_CONDITIONAL([test_vald], [test "x$test_vald" = "xyes"])
AC_SUBST([CUNIT_CFLAGS])
AC_SUBST([CUNIT_LIBS])
+
+AC_ARG_ENABLE([cunit_out_xml],
+
semihalf-mazur-michal replied on github web page:
include/odp/api/spec/packet.h
@@ -1333,6 +1333,17 @@ void odp_packet_user_ptr_set(odp_packet_t pkt, const
void *ctx);
*/
void *odp_packet_user_area(odp_packet_t pkt);
+/**
+ * Packet header from user area pointer
+ *
+ * Return address of
semihalf-mazur-michal replied on github web page:
include/odp/api/spec/packet.h
@@ -1333,6 +1333,17 @@ void odp_packet_user_ptr_set(odp_packet_t pkt, const
void *ctx);
*/
void *odp_packet_user_area(odp_packet_t pkt);
+/**
+ * Packet header from user area pointer
+ *
+ * Return address of
semihalf-mazur-michal replied on github web page:
include/odp/api/spec/packet.h
@@ -1333,6 +1333,17 @@ void odp_packet_user_ptr_set(odp_packet_t pkt, const
void *ctx);
*/
void *odp_packet_user_area(odp_packet_t pkt);
+/**
+ * Packet header from user area pointer
Comment:
corrected in v2
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Pass checksum and protocol parsing flags to packet parsing code.
Checksum checks are not yet implemented by odp_packet_parse, it will be
done later.
Signed-off-by: Dmitry Eremin-Solenikov
---
From: Dmitry Eremin-Solenikov
pkt_out can be NULL if we expect an error. IPsec outbound inline needs
proper outer header to function. Pass L2 header from inbound packet if
outbound packet is NULL.
Signed-off-by: Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Support checking MTU after IPsec transformation.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
There is no point in filling artificial AAD struct for AH just for the
sake of sequence number checking. Instead use AAD just for ESP and
provide separate seq_no field.
Signed-off-by: Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov
Implement support for handling IPv6 packets and IPv6 tunnels.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
To ease adding IPv6/IPcomp/etc modularize IPsec implementation,
refactoring out functions handling ESP/AH and header parsing/tunneling.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email
From: Dmitry Eremin-Solenikov
In preparation to add IPv6 support, add ipv4 everywhere (to test packets
and to test names).
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304
From: Dmitry Eremin-Solenikov
Such include adds unnecessary build dependencies. Just include
, which is enough.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
Test vectors from draft-mcgrew-gcm-test-01 contain invalid next_header
field in ESP trailers (0x01 = ICMP instead of 0x04 = IPv4). Correct test
vectors. Test 12 is disabled till NoNH packets are properly supported in
a defined way.
This adds support for handling of IPv6 packets and IPv6 tunnels.
github
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch: https://github.com/Linaro/odp/pull/304.patch
** Base sha:
From: Dmitry Eremin-Solenikov
Usign odp_proto_layer_t for parse layer spec is more logical, as it is
the same enum that is used for the reset of packet parsing API.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email
From: Dmitry Eremin-Solenikov
Use odp_proto_layer_t to specify outer header retention level. Drop
separate odp_ipsec_proto_layer_t.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 336
github
/** Email created from pull request 336 (lumag:ipsec-proto-layer)
** https://github.com/Linaro/odp/pull/336
** Patch: https://github.com/Linaro/odp/pull/336.patch
** Base sha: 65d690fbcf03c6a4d5eb3f01bde36807833feaaa
** Merge commit sha:
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 76997bb4087981751966df0fa1d0897486a3da1d
https://github.com/Linaro/odp/commit/76997bb4087981751966df0fa1d0897486a3da1d
Author: Petri Savolainen
Date: 2017-12-12 (Tue, 12 Dec
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
pkt_out can be NULL if we expect an error. IPsec outbound inline needs
proper outer header to function. Pass L2 header from inbound packet if
outbound packet is NULL.
Signed-off-by: Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov
Pass checksum and protocol parsing flags to packet parsing code.
Checksum checks are not yet implemented by odp_packet_parse, it will be
done later.
Signed-off-by: Dmitry Eremin-Solenikov
---
From: Dmitry Eremin-Solenikov
Support checking MTU after IPsec transformation.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
There is no point in filling artificial AAD struct for AH just for the
sake of sequence number checking. Instead use AAD just for ESP and
provide separate seq_no field.
Signed-off-by: Dmitry Eremin-Solenikov
From: Dmitry Eremin-Solenikov
Implement support for handling IPv6 packets and IPv6 tunnels.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
Such include adds unnecessary build dependencies. Just include
, which is enough.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
**
From: Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch:
From: Dmitry Eremin-Solenikov
Test vectors from draft-mcgrew-gcm-test-01 contain invalid next_header
field in ESP trailers (0x01 = ICMP instead of 0x04 = IPv4). Correct test
vectors. Test 12 is disabled till NoNH packets are properly supported in
a defined way.
From: Dmitry Eremin-Solenikov
To ease adding IPv6/IPcomp/etc modularize IPsec implementation,
refactoring out functions handling ESP/AH and header parsing/tunneling.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email
From: Dmitry Eremin-Solenikov
In preparation to add IPv6 support, add ipv4 everywhere (to test packets
and to test names).
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 304
This adds support for handling of IPv6 packets and IPv6 tunnels.
github
/** Email created from pull request 304 (lumag:ipsec-ipv6-2)
** https://github.com/Linaro/odp/pull/304
** Patch: https://github.com/Linaro/odp/pull/304.patch
** Base sha:
From: Michal Mazur
This new API function will take a pointer to user area and return
ODP packet handle associated with that user area.
It is needed when application wants to send buffers back to ODP and
has only a pointer to its private type. ODP implementations in which
user
This new API function will take a pointer to user area and calculate
pointer to ODP buffer's header associated with it.
It is needed when application wants to send buffers back to ODP and
has only a pointer to its private type. Some implementation (like
ODP-DPDK) can implement this API using
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 015674f10e67c319e6299fe99332787c491d59c2
https://github.com/Linaro/odp/commit/015674f10e67c319e6299fe99332787c491d59c2
Author: Petri Savolainen
Date: 2017-12-12 (Tue, 12 Dec
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 87ec9465899591ddc2125740d19a395d4b8b9608
https://github.com/Linaro/odp/commit/87ec9465899591ddc2125740d19a395d4b8b9608
Author: Dmitry Eremin-Solenikov
Date: 2017-12-12
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 072b0d72318cfb5b847300404a2bd2130e5130c1
https://github.com/Linaro/odp/commit/072b0d72318cfb5b847300404a2bd2130e5130c1
Author: Matias Elo
Date: 2017-12-12 (Tue, 12 Dec 2017)
Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] wrote:
> On 12 December 2017 at 14:00, Peltonen, Janne (Nokia - FI/Espoo)
> wrote:
> >> Also note that this will break explicit IV support.
> >
> > Why so? The iv is set in every operation.
>
> Sorry, I
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 811281a22b6274b7f41b926a9cfbe09e48a366bd
https://github.com/Linaro/odp/commit/811281a22b6274b7f41b926a9cfbe09e48a366bd
Author: Matias Elo
Date: 2017-12-04 (Mon, 04 Dec 2017)
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/ipsec.h
line 4
@@ -1207,6 +1207,7 @@ typedef struct odp_ipsec_status_t {
*
* Each input packet must have a valid value for these metadata (other metadata
* is ignored):
+ * - IPv4 or IPv6 flag: Set packet flag
Dmitry Eremin-Solenikov(lumag) replied on github web page:
include/odp/api/spec/ipsec.h
line 4
@@ -1207,6 +1207,7 @@ typedef struct odp_ipsec_status_t {
*
* Each input packet must have a valid value for these metadata (other metadata
* is ignored):
+ * - IPv4 or IPv6 flag: Set packet flag
From: Dmitry Eremin-Solenikov
Separate union controlling different checksum checks. It will be used by
IPsec API.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 314 (lumag:ipsec-chksum)
**
Separate checksumming flags into separate type to be used by both packet parse
and IPsec functions.
github
/** Email created from pull request 314 (lumag:ipsec-chksum)
** https://github.com/Linaro/odp/pull/314
** Patch:
From: Dmitry Eremin-Solenikov
Reuse odp_packet_parse_chksum_t from packet API to ease passing checksum
flags to packet parsing functions.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 314
On 12 December 2017 at 14:00, Peltonen, Janne (Nokia - FI/Espoo)
wrote:
>> Also note that this will break explicit IV support.
>
> Why so? The iv is set in every operation.
Sorry, I meant implicit IV, when there is no override_iv_ptr, but IV
is 'kept' inside session.
> Also note that this will break explicit IV support.
Why so? The iv is set in every operation.
Janne
> -Original Message-
> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org]
> Sent: Tuesday, December 12, 2017 12:36 PM
> To: Peltonen, Janne (Nokia -
From: Dmitry Eremin-Solenikov
Separate union controlling different checksum checks. It will be used by
IPsec API.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 314 (lumag:ipsec-chksum)
**
From: Dmitry Eremin-Solenikov
Reuse odp_packet_parse_chksum_t from packet API to ease passing checksum
flags to packet parsing functions.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 314
Separate checksumming flags into separate type to be used by both packet parse
and IPsec functions.
github
/** Email created from pull request 314 (lumag:ipsec-chksum)
** https://github.com/Linaro/odp/pull/314
** Patch:
> So, I'd suggest to preallocate Open SSL (per thread) context memory in
> global_init(). I
> guess context allocation depends on algorithm, etc config, but we could e.g.
> pre-allocate
> the most obvious ones (e.g. AES+SHA1, or AES-GCM) and leave all others as
> they are today.
> A balance
91 matches
Mail list logo