Re: [lng-odp] [API-NEXT PATCH v4 1/2] helper: table: add impl of ip lookup table

3 AM, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > >> Bill, >> >> I'm able to apply it with just: >> git am -s -3 /tmp/1/*.eml >> patch -p1 < /opt/Linaro/odp3.git/.git/rebase-apply/patch >> git add -A >> git am --continue >> >&g

Re: [lng-odp] [API-NEXT PATCH v4 1/2] helper: table: add impl of ip lookup table

Ping? > 在 2016年6月23日，下午4:05，HePeng <xnhp0...@icloud.com> 写道： > > Hello，is there anyone who is reviewing this patch? >> 在 2016年6月17日，下午2:01，HePeng <xnhp0...@icloud.com> 写道： >> >> Ping? >>> 在 2016年6月14日，上午9:30，HePeng <xnhp0...@icloud

Re: [lng-odp] [API-NEXT PATCH v4 1/2] helper: table: add impl of ip lookup table

Ping? > 在 2016年6月14日，上午9:30，HePeng <xnhp0...@icloud.com> 写道： > > Hi, bill > this patch is based on the current API-NEXT … > >> 在 2016年6月14日，上午6:24，Bill Fischofer <bill.fischo...@linaro.org> 写道： >> >> v4 of this patch still doesn't apply for me:

Re: [lng-odp] [API-NEXT PATCH v3 1/2] helper: table: add impl of ip lookup table

Yes, we would like to have a discussion on these two patches. But I cannot add it myself, I do not have the account. > 在 2016年6月13日，下午8:19，Mike Holmes <mike.hol...@linaro.org> 写道： > > Hi HePeng > > If you would like to try to stir up interest you could raise it at the w

Re: [lng-odp] [API-NEXT PATCH v4 1/2] helper: table: add impl of ip lookup table

Hi, bill this patch is based on the current API-NEXT … > 在 2016年6月14日，上午6:24，Bill Fischofer 写道： > > v4 of this patch still doesn't apply for me: > > bill@Ubuntu15:~/linaro/review$ git am --reject ~/Mail/Incoming/Ru/5 > Applying: helper: table: add impl of ip lookup

Re: [lng-odp] [API-NEXT PATCH v3 1/2] helper: table: add impl of ip lookup table

to review/test this patch but fail > to apply it. > Please update to current master and send v4. > > Maxim. > > On 06/02/16 06:25, HePeng wrote: >> Ping. >> >>> 在 2016年5月23日，下午12:26，Ru Jia <ji...@ict.ac.cn> 写道： >>> >>> This is an

Re: [lng-odp] [API-NEXT PATCH v3 2/2] helper: test: add validation test of ip lookup table

Ping > 在 2016年5月23日，下午12:26，Ru Jia 写道： > > Signed-off-by: Ru Jia > --- > helper/test/Makefile.am | 4 +- > helper/test/iplookuptable.c | 173 > 2 files changed, 176 insertions(+), 1 deletion(-) > create mode

Re: [lng-odp] [API-NEXT PATCH v3 1/2] helper: table: add impl of ip lookup table

Ping. > 在 2016年5月23日，下午12:26，Ru Jia 写道： > > This is an implementation of the 16,8,8 ip lookup > (longest prefix matching) algorithm. The key of the > table is 32-bit IPv4 address. > > Signed-off-by: Ru Jia > --- > helper/Makefile.am | 4 +- >

Re: [lng-odp] [API-NEXT 1/2] helper: table: add impl of ip lookup table

Hi, This patch aims to provide a trie implementation to Table APIs. The functions declared in .h file will not be exposed to users. Just like odph_hashtable.h resides in the same dir as its .c file. > 在 2016年5月16日，下午1:43，Jia Ru 写道： > > The functions of this IP

Re: [lng-odp] [API-NEXT PATCH v3 1/2] helper: table: add impl of cuckoo hash table

Hi, We appreciate more comments on the patch. Thanks. > 在 2016年4月27日，下午7:35，Raj Murali 写道： > > Agree with Bill. > The original copyright statement should be retained and we need to add our's > over and above it. > > Raj Murali > > > Raj Murali > Director -

Re: [lng-odp] [API-NEXT PATCH v2 1/2] helper: table: add impl of cuckoo hash table

Hi, We have changed the cuckoo hash code into the ODP/helper where we find a table pipeline infrastructure. We think maybe it is a better idea to make cuckoo hash as one of alternative table. > 在 2016年4月18日，下午1:26，Jia Ru 写道： > > According to the comments, I modified

Re: [lng-odp] LPM Algorithm APIs in ODP

t; > Thank You > P Gyanesh K. Patra > University of Campinas (Unicamp) > > > > >> On Apr 17, 2016, at 22:55, HePeng <xnhp0...@icloud.com >> <mailto:xnhp0...@icloud.com>> wrote: >> >> Hi, >>We are in the progress of releasing the LPM c

Re: [lng-odp] LPM Algorithm APIs in ODP

Hi, We are in the progress of releasing the LPM code, but currently we are busy submitting the cuckoo hash code into ODP helper. About the LPM code we have already a 16-8-8 implementation. Now we are working on the code to fit it into ODP architecture. But we have not submitted any code

Re: [lng-odp] [API-NEXT PATCH 1/3] api: add cuckoo hash api

Ping Any comments? or should we put the code into helper/? > 在 2016年4月8日，上午9:19，he peng 写道： > > Perhaps a generic hash table APIs (not cuckoo hash) could be put in the main > APIs? > > >> 在 2016年4月6日，下午10:18，Ru Jia > 写道： >> >> Last

Re: [lng-odp] Contribute IP lookup code to ODP

> to see if it fits: > - multicore, hopefully lockless > - the front-end should be available in ODP shared memory > - an API between Front-End and Back-End, so that we can have it as SPMC > on the shared memory. > - ... > > Can you share more light

[lng-odp] Contribute IP lookup code to ODP

Hi, I plan to submit an IP lookup code to ODP. However, this code is a little bit complex. So I am here asking for some suggestions. (Please view this email using the monospaced font.) The code is actually an IP lookup architecture, including a “backend” of all IP lookup algorithms

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

> 在 2015年12月17日，下午4:26，Maxim Uvarov <maxim.uva...@linaro.org> 写道： > > On 12/17/2015 08:56, HePeng wrote: >> Hi, Maxim >> >> I will present a quick patch that will not pass the kernel style >> check as this one is just for evaluation. > ok, in that ca

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

tches? We will try to help how to improve performance. > > Maxim. > > On 12/14/2015 22:30, Mike Holmes wrote: >> Added to Tuesday agenda >> >> On 12 December 2015 at 22:18, HePeng <xnhp0...@icloud.com >> <mailto:xnhp0...@icloud.com>> wrote: >> &

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

Ping. So what is your decision on this. > 在 2015年12月10日，下午1:06，HePeng <xnhp0...@icloud.com> 写道： > >> >> 在 2015年12月9日，下午6:49，Ola Liljedahl <ola.liljed...@linaro.org >> <mailto:ola.liljed...@linaro.org>> 写道： >> >> On 9 December 2015 a

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

> 在 2015年12月9日，下午6:20，Maxim Uvarov <maxim.uva...@linaro.org> 写道： > > On 12/09/2015 08:54, HePeng wrote: >> Let me further explain this. >> >> Cuckoo hash is a hash table, and as a hash table, it needs to store the >> key-value paris. >> For any inp

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

> 在 2015年12月9日，下午6:49，Ola Liljedahl <ola.liljed...@linaro.org> 写道： > > On 9 December 2015 at 06:31, HePeng <xnhp0...@icloud.com > <mailto:xnhp0...@icloud.com>> wrote: > >> 在 2015年12月8日，下午9:34，Ola Liljedahl <ola.liljed...@linaro.org >> &l

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

ed as a container, like vector in C++ STL. > > > The scheduler itself could use this since its use of queues is subject to > the same issues. > > On Mon, Dec 7, 2015 at 11:39 PM, HePeng <xnhp0...@icloud.com > <mailto:xnhp0...@icloud.com>> wrote: > Hi Ma

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

, it is just used as a container to store key indices. It is quite similar to ODP buffer/pool. And this is the reason I use ODP buffer/pool to store all the keys in the new implementation. > 在 2015年12月9日，下午1:31，HePeng <xnhp0...@icloud.com> 写道： > >> >> 在 2015年12

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

Hi Maxim, I implement a new version of cuckoo hash based on the ODP buffer/pool. As I’ve mentioned earlier, the use of ring in cuckoo hash is like to the use of a container, e.g. a queue in C++ STL. In current ODP implementation, I found that the ODP queue is implemented

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

> 在 2015年12月2日，下午5:30，Maxim Uvarov <maxim.uva...@linaro.org> 写道： > > On 12/02/2015 10:26, HePeng wrote: >>> 在 2015年11月30日，下午11:04，Maxim Uvarov <maxim.uva...@linaro.org> 写道： >>> >>> On 11/30/2015 11:18, HePeng wrote: >>>> Hi, Maxim,

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

> 在 2015年11月30日，下午11:04，Maxim Uvarov <maxim.uva...@linaro.org> 写道： > > On 11/30/2015 11:18, HePeng wrote: >> Hi, Maxim, >> How is everything going, about the ring? > > > Hello Peng, > > We need to take a look it it's possible to rewrite your hash i

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

Cuckoo Hash Table is an efficient hash table variant which has a very high utilization (load/total entries > 90%). In our tests, the utilization is around 94%. Here is a brief introduction on cuckoo hash: https://en.wikipedia.org/wiki/Cuckoo_hashing

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

Please ignore this patch, it contains a silly mistake on hash.h which modifies its comments causing a typo. sorry. > 在 2015年11月26日，上午10:20，Peng 写道： > > Signed-off-by: Peng > --- > helper/Makefile.am |2 + >

Re: [lng-odp] Is there an errno api in ODP?

Hi, Maxim, The problem is that I want to add a patch that is located in the helper/ dir. There are no platform layout in helper/. > 在 2015年11月25日，下午5:02，Maxim Uvarov <maxim.uva...@linaro.org> 写道： > > On 11/25/2015 11:53, HePeng wrote: >> Hi, >>

[lng-odp] Is there an errno api in ODP?

Hi, I am preparing some patches for ODP. I need to set errno value for some functions, is there an API? all errno related APIs are just to read errno. Thanks. ___ lng-odp mailing list lng-odp@lists.linaro.org

[lng-odp] Is there an errno api in ODP?

Hi, I am preparing some patches for ODP. I need to set errno value for some functions, is there an API? all errno related APIs are just to read errno. Thanks. ___ lng-odp mailing list lng-odp@lists.linaro.org

Re: [lng-odp] [PATCH] [API-NEXT PATCH v5] api: hash: Added crc32 and crc32c hash functions

Hi, Maxim > 在 2015年10月23日，下午11:40，Maxim Uvarov 写道： > > Somehow that email inside previous version thread it's hard to follow it. I am having troubles in using git send-email to reply to specific emails, even I’ve tried using —reply-to message-id, the email is sent as

Re: [lng-odp] [API-NEXT PATCH] api: clib: added standard c library api

> 在 2015年10月16日，下午8:16，Bill Fischofer 写道： > > Why would you not expect a platform to provide an optimized implementation of > these stdlib functions itself? GCC, in particular, seems to do a good job of > this for most platforms. Hi Bill, DPDK has its own

Re: [lng-odp] [PATCH v2] Add CRC as an odp api, and a SW implementation in linux-generic. Add copyright license.

> 在 2015年10月14日，下午7:46，Savolainen, Petri (Nokia - FI/Espoo) > 写道： > > As Maxim mentioned any patches that modify api files should target the > api-next branch and should be named like this > > [API-NEXT PATCH v3] api: hash: Added crc32 and crc32c hash functions >

Re: [lng-odp] [PATCH 5/8] add fbk hash table

> 在 2015年10月9日，下午4:36，Ola Liljedahl <ola.liljed...@linaro.org> 写道： > > On 9 October 2015 at 10:33, HePeng <xnhp0...@icloud.com > <mailto:xnhp0...@icloud.com>> wrote: > >> 在 2015年10月9日，下午4:26，Ola Liljedahl <ola.liljed...@linaro.org >> <mailto

Re: [lng-odp] [PATCH 5/8] add fbk hash table

> 在 2015年10月9日，下午4:26，Ola Liljedahl <ola.liljed...@linaro.org> 写道： > > On 8 October 2015 at 14:43, HePeng <xnhp0...@icloud.com > <mailto:xnhp0...@icloud.com>> wrote: > >> 在 2015年10月8日，下午8:13，Ola Liljedahl <ola.liljed...@linaro.org >> <mailto

Re: [lng-odp] [PATCH 5/8] add fbk hash table

So we should change the code into ODP conventions, and resubmit in a v2? > 在 2015年10月8日，下午4:25，Mike Holmes 写道： > > http://docs.opendataplane.org/master/linux-generic-doxygen-html/api_guide_lines.html > >

Re: [lng-odp] [PATCH 5/8] add fbk hash table

There are some discussion about moving the crc into the ODP APIs. see the thread [lng-odp] [PATCH 1/5] Add Jhash and CRC functions > 在 2015年10月8日，下午5:27，Mike Holmes <mike.hol...@linaro.org> 写道： > > > On Oct 8, 2015 5:20 AM, "HePeng" <xnhp0...@icloud.com

Re: [lng-odp] [PATCH 2/5] Modify the Ring structure

Ping. > 在 2015年9月27日，下午10:24，rujiacs 写道： > > Add interfaces odph_ring_sp_enqueue() and odph_ring_sc_dequeue() to satify > the requirement of the cuckoo hash table. > Add odph_ring_free() to free the shared memory allocated to a ring. > > Signed-off-by: rujiacs

Re: [lng-odp] [PATCH 4/5] Add four byte key hash table

Thank you for the reviewing, will check for it and re-submit the patch in a v2. > 在 2015年10月8日，下午8:43，Ola Liljedahl 写道： > > On 27 September 2015 at 16:24, rujiacs > wrote: > Four byte key(fbk) hash table is a part of hash

Re: [lng-odp] [PATCH 5/8] add fbk hash table

> 在 2015年10月8日，下午8:13，Ola Liljedahl 写道： > > On 8 October 2015 at 10:02, Bill Fischofer > wrote: > Trying to keep the rte_ prefix would be confusing. One of the precepts of > ODP is that it doesn't

Re: [lng-odp] [PATCH 1/5] Add Jhash and CRC functions

odp [mailto:lng-odp-boun...@lists.linaro.org > <mailto:lng-odp-boun...@lists.linaro.org>] On Behalf Of EXT Ola Liljedahl > Sent: Wednesday, October 07, 2015 6:12 PM > To: HePeng > Cc: 杨馥榕; LNG ODP Mailman List > Subject: Re: [lng-odp] [PATCH 1/5] Add Jhash and CRC functions &g

Re: [lng-odp] How about adding an algorithm APIs to ODP

project. Thanks, Peng He So thanks for the suggestion and welcome. On Tue, Aug 25, 2015 at 6:28 AM, HePeng xnhp0...@icloud.com mailto:xnhp0...@icloud.com wrote: Hi, I am new to the ODP project, so I am not sure that should I send this email to the mailing list or to somewhere

Re: [lng-odp] How about adding an algorithm APIs to ODP

在 2015年8月26日，下午1:14，Maxim Uvarov maxim.uva...@linaro.org 写道： On 08/26/15 05:06, HePeng wrote: 在 2015年8月25日，下午11:01，Maxim Uvarov maxim.uva...@linaro.org mailto:maxim.uva...@linaro.org 写道： On 08/25/15 17:06, Mike Holmes wrote: HI HePeng, You can help us greatly even if you can't

Re: [lng-odp] How about adding an algorithm APIs to ODP

Bill, Thanks, will look at it. 在 2015年8月26日，下午7:46，Bill Fischofer bill.fischo...@linaro.org 写道： HePeng, As Mike mentioned, the TM Implementation is currently being staged in its own repository for ease of development. The patches for that implementation should be appearing on the ODP

[lng-odp] How about adding an algorithm APIs to ODP

Hi, I am new to the ODP project, so I am not sure that should I send this email to the mailing list or to somewhere else. The thing is that I did some investigation on the code itself, and find that there are not any algorithm APIs in ODP. By algorithms, I mean IP lookup,

Re: [lng-odp] How about adding an algorithm APIs to ODP

for linux-generic, however at present these are for internal use. It might be possible to extend them, along with your ideas/code into a general set of APIs for this area. So thanks for the suggestion and welcome. On Tue, Aug 25, 2015 at 6:28 AM, HePeng xnhp0...@icloud.com mailto:xnhp0

Re: [lng-odp] How about adding an algorithm APIs to ODP

在 2015年8月25日，下午11:01，Maxim Uvarov maxim.uva...@linaro.org 写道： On 08/25/15 17:06, Mike Holmes wrote: HI HePeng, You can help us greatly even if you can't contribute the code for what you need. Can you provide a short list in priority order of the specific requirement or APIs you