[lng-odp] Releasing resources in ODP

2015-08-17 Thread Mario Torrecillas Rodriguez
Hi all, As some of you know we at ARM have been working on prototyping a packet processing application using ODP as the HW abstraction API ­ one of the goals of this work is to ³validate² the API from the application point of view and provide contributions where it makes sense if we think that it

Re: [lng-odp] Releasing resources in ODP

2015-08-17 Thread Mario Torrecillas Rodriguez
especially when trying to minimize traffic loss. I don't think resource creation and tearing down is dataplane job, these functions should be called from a control plane thread. Thanks, Alex On 17 August 2015 at 11:59, Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com wrote: Hi all

Re: [lng-odp] [API-NEXT PATCH 2/5] linux-generic: schedule: implement scheduler groups

2015-07-30 Thread Mario Torrecillas Rodriguez
The problem with using count as a way of determining whether the slot is unallocated or not is that count keeps the current number of threads in the group. If a group is created with no threads in it (which is allowed by the implementation as far as I can see), then no thread will be able to

Re: [lng-odp] loopback interface

2015-05-28 Thread Mario Torrecillas Rodriguez
On a related noteŠ It is my current understanding that, with the current set of APIs, classification has to be performed right after IO. What makes me think that is that the classification API seems to be linked to the packetIO API. So, my question is, firstly, am I right with my assumption? And

[lng-odp] [PATCHv7] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-02-05 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: * Fixed pktio test issue

[lng-odp] [PATCHv6] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-02-04 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: * Renamed odp_errno.h

[lng-odp] [PATCHv5] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-02-04 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: * Added doxygen group

[lng-odp] [PATCHv4] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-01-29 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: * Changed printf

[lng-odp] [PATCHv3] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-01-21 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: * Changed doxygen

Re: [lng-odp] [PATCHv2] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-01-20 Thread Mario Torrecillas Rodriguez
Thanks for the review Petri. A short comment inlined. On 20/01/2015 13:38, Savolainen, Petri (NSN - FI/Espoo) petri.savolai...@nsn.com wrote: --- /dev/null +++ b/platform/linux-generic/include/api/odp_errno.h @@ -0,0 +1,61 @@ +/* Copyright (c) 2015, Linaro Limited + * All rights reserved.

[lng-odp] [PATCHv2] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-01-19 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: * Moved __odp_errno

[lng-odp] [PATCH] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-01-16 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) platform/linux-generic/Makefile.am | 2

Re: [lng-odp] [PATCHv6] validation: synchronizer tests

2015-01-12 Thread Mario Torrecillas Rodriguez
The barrier tests seems to be fine actually, it always either hangs on the no_barrier test, or doesn¹t hang at all. I¹m looking into this now, it might be a design problem rather than a bug in the code. Mario. From: Mike Holmes mike.hol...@linaro.org Date: Friday, 9 January 2015 18:29 To:

Re: [lng-odp] [PATCHv7] validation: synchronizer tests

2015-01-12 Thread Mario Torrecillas Rodriguez
barrier was being used. Mario. On 12/01/2015 11:25, Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com wrote: First set of synchronizer tests. This patch includes tests for locks, barriers and atomics. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com

[lng-odp] [PATCHv7] validation: synchronizer tests

2015-01-12 Thread Mario Torrecillas Rodriguez
First set of synchronizer tests. This patch includes tests for locks, barriers and atomics. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: Fixed issue

[lng-odp] [PATCHv6] validation: synchronizer tests

2015-01-08 Thread Mario Torrecillas Rodriguez
First set of synchronizer tests. This patch includes tests for locks, barriers and atomics. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: Addressed

[lng-odp] [PATCHv4] validation: synchronizer tests

2014-12-18 Thread Mario Torrecillas Rodriguez
First set of synchronizer tests. This patch includes tests for locks, barriers and atomics (sunny day tests only). Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from

Re: [lng-odp] [PATCHv4] validation: synchronizer tests

2014-12-18 Thread Mario Torrecillas Rodriguez
too (e.g. now gitignore contains the binary). Mario. On 18/12/2014 10:51, Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com wrote: First set of synchronizer tests. This patch includes tests for locks, barriers and atomics (sunny day tests only). Signed-off-by: Mario Torrecillas

[lng-odp] [PATCHv2] validation: synchronizer tests

2014-12-17 Thread Mario Torrecillas Rodriguez
First set of synchronizer tests. This patch includes tests for locks, barriers and atomics (sunny day tests only). Most of this code comes from Barry Spinney and Yan Songming. Please note that this code depends on ticketlock_trylock Signed-off-by: Mario Torrecillas Rodriguez

[lng-odp] [PATCHv3] validation: synchronizer tests

2014-12-17 Thread Mario Torrecillas Rodriguez
First set of synchronizer tests. This patch includes tests for locks, barriers and atomics (sunny day tests only). Most of this code comes from Barry Spinney and Yan Songming. Please note that this code depends on ticketlock_trylock Signed-off-by: Mario Torrecillas Rodriguez

Re: [lng-odp] [PATCHv3] validation: synchronizer tests

2014-12-17 Thread Mario Torrecillas Rodriguez
This version of the patch should fix all the issues mentioned so far (by Jerin and Maxim, I believe). Cheers, Mario. On 17/12/2014 16:31, Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com wrote: First set of synchronizer tests. This patch includes tests for locks, barriers

[lng-odp] [PATCH 1/1] validation: synchronizer tests

2014-12-16 Thread Mario Torrecillas Rodriguez
on ticketlock_trylock Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- test/validation/Makefile.am |7 +- test/validation/common/odp_common.c | 241 ++ test/validation/common/odp_common.h | 28 + test/validation/common

Re: [lng-odp] [PATCH 1/1] validation: synchronizer tests

2014-12-16 Thread Mario Torrecillas Rodriguez
. Mario. On 16/12/2014 09:44, Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com wrote: (This code contribution is provided under the terms of agreement LES-LTM-21309) First set of synchronizer tests. This patch includes tests for locks, barriers and atomics (sunny day tests only). Most

Re: [lng-odp] [PATCH] validation:add atomic test in odp syncronizers

2014-12-14 Thread Mario Torrecillas Rodriguez
I have combined both patches into a single one using Barry¹s as the baseline. I need to fix a couple of minor issues that I have and do some cleanup but I¹ll most likely send the patch tomorrow so that we can continue working on this unified set of synchroniser tests from now on. Like Mike said,

Re: [lng-odp] [PATCH] linux-generic: odp_ticketlock.c: performance regression

2014-12-03 Thread Mario Torrecillas Rodriguez
I don¹t think cur_ticket will be read/written by more than one thread simultaneously, only the one which owns the lock will attempt to update it. Mario. On 03/12/2014 17:16, Maxim Uvarov maxim.uva...@linaro.org wrote: On 12/03/2014 05:20 PM, Ola Liljedahl wrote: Ping! Needed more review for

[lng-odp] About making odp_compiler.h and odp_byteorder.h internal

2014-11-28 Thread Mario Torrecillas Rodriguez
Hi Petri, all, According to the document containing the list of remaining tasks, these two APIs need to be made internal (at least, this is explicitly mentioned in the case of odp_compiler. For odp_byteorder it is not clear whether the plan is to move it to its own header file or merge it with