Re: [lng-odp] [Bug 1259] C++ compile and link to odp lib generates new warnings

2015-02-24 Thread Simon Kågström
ons? They're > one of the most useful features of C and make for vastly more readable code. > > On Tue, Feb 24, 2015 at 1:01 AM, Simon Kågström > mailto:simon.kagst...@netinsight.net>> > wrote: > > On 2015-02-23 21:17, bugzilla-dae...@bugs.linaro.org >

Re: [lng-odp] [Bug 1259] C++ compile and link to odp lib generates new warnings

2015-02-23 Thread Simon Kågström
On 2015-02-23 21:17, bugzilla-dae...@bugs.linaro.org wrote: > Some googling suggests that this is because the ODP API files do not have a > named namespace and as a result default to the namespace 'anonymous'. > However, > anonymous is limited to a single translation unit. [...] > #ifdef __cplu

Re: [lng-odp] [PATCH] test: miscellaneous: Add CPP test

2015-02-19 Thread Simon Kågström
On 2015-02-18 19:36, Mike Holmes wrote: > +++ b/test/miscellaneous/odp_api_from_cpp.cpp > @@ -0,0 +1,12 @@ > +#include > +#include > +#include > + #include triggers some more errors, so it would be good to include. Probably other headers should be included as well, but these are the ones I'v

Re: [lng-odp] [PATCH 2/2] test: Add compile-under-C++ test (currently failing)

2015-02-18 Thread Simon Kågström
On 2015-02-16 14:00, Maxim Uvarov wrote: > On 02/13/2015 02:37 PM, Simon Kagstrom wrote: >> To make the C++ test more complete, it should include a larger set of >> the header files. I just saw that including odp/helper/eth.h will >> trigger another C++ build failure (with _Static_assert, can be re

Re: [lng-odp] [PATCH 2/2] test: Add compile-under-C++ test (currently failing)

2015-02-18 Thread Simon Kågström
(I don't remember if I actually sent this messages, sorry if it's a duplicate!) On 2015-02-16 14:00, Maxim Uvarov wrote: > On 02/13/2015 02:37 PM, Simon Kagstrom wrote: >> To make the C++ test more complete, it should include a larger set of >> the header files. I just saw that including odp/helpe

Re: [lng-odp] [Bug 300] __Static_assert in linux generic is a C11 feature

2015-02-17 Thread Simon Kågström
On 2015-02-17 10:38, Ola Liljedahl wrote: > On 17 February 2015 at 08:10, Simon Kågström > wrote: >> On 2015-02-16 18:19, bugzilla-dae...@bugs.linaro.org wrote: >>> Mike Holmes <mailto:mike.hol...@linaro.org> changed bug 300 >>> <https://bugs.linaro.org

Re: [lng-odp] [Bug 300] __Static_assert in linux generic is a C11 feature

2015-02-16 Thread Simon Kågström
On 2015-02-16 18:19, bugzilla-dae...@bugs.linaro.org wrote: > Mike Holmes changed bug 300 > > What Removed Added > Resolution--- WONTFIX > StatusCONFIRMED RESOLVED > > *Comment # 5

Re: [lng-odp] [PATCH 2/2] inux-generic: Make _odp_typeval C++-safe

2015-02-09 Thread Simon Kågström
On 2015-02-10 03:28, Bill Fischofer wrote: > Taras and I were just discussing this issue and he suggested that the > current definition could be replaced by: > > #define _odp_typeval(handle) ((unit32_t)handle) > > We need to verify that this works in all cases, but presumably C++ > wouldn't have

Re: [lng-odp] [PATCH 1/2] linux-generic: Unbreak build due to missing timer_types.h

2015-02-09 Thread Simon Kågström
On 2015-02-10 03:50, Ola Liljedahl wrote: > On 9 February 2015 at 22:36, Simon Kagstrom > wrote: >> Fixes >> >> odp/timer.h:25:34: fatal error: odp/plat/timer_types.h: No such file or >> directory > This works when compiling with gcc (i.e. without this patch, we > actually don't understand why

[lng-odp] [PATCH] linux-generic: Add space to avoid C++11 literal/identifier warning

2014-12-09 Thread Simon Kågström
When building with --std=c++0x or --std=c++11, you will otherwise get this warning: C++11 requires a space between literal and identifier [-Wliteral-suffix] ODP_VERSION_TO_STR(ODP_VERSION_API_GENERATION) "."\ Signed-off-by: Simon Kagstrom --- platform/linux-generic/include/api/odp_version