Re: [lng-odp] odp timer thoughts

On Thu, Jan 28, 2016 at 09:31:52PM +0300, Maxim Uvarov wrote: > I have some thoughts and questions about timer implementation in > linux-generic. > > Current implementation: > > sigev.sigev_notify = SIGEV_THREAD; > sigev.sigev_notify_function = timer_notify; > sigev.sigev_val

Re: [lng-odp] [PATCHv2 1/5] validation: pktio: make MAC address and promiscuous mode optional

On Mon, Jan 25, 2016 at 02:56:09PM +, Elo, Matias (Nokia - FI/Espoo) wrote: > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > > Stuart > > Haslam > > Sent: Friday, January 22, 2016 8:48 PM > > To:

Re: [lng-odp] [PATCH] linux-generic: validation: fix dependency for tests-validation.env

On Thu, Jan 28, 2016 at 01:59:53PM +0300, Maxim Uvarov wrote: > That is merged, but looks like this commit generates error: > > make[2]: Leaving directory > `/opt/Linaro/check-odp.git/build/odp-apply/opendataplane-1.6.0.0.git367.gc251351/_build/scripts' > make[2]: Entering directory > `/opt/Lina

Re: [lng-odp] [PATCHv2 4/5] linux-generic: netmap: support segmented packets

it from this series without also dropping 5/5, and that would partly negate the purpose of the series. I'll merge the series to API-NEXT and resend without this patch. > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT &

[lng-odp] [PATCH] linux-generic: validation: fix dependency for tests-validation.env

igure --enable-test-vald --with-testdir --prefix=$(pwd)/mytests make install installcheck As the tests-environment.env file generated during the first make (with test-vald disabled) isn't updated. Signed-off-by: Stuart Haslam --- platform/linux-generic/test/Makefile.am | 15 ++- 1 fi

Re: [lng-odp] [API-NEXT PATCHv8 0/5] pktio statistics counters

gt; 14 files changed, 769 insertions(+), 4 deletions(-) > create mode 100644 platform/linux-generic/pktio/ethtool.c > create mode 100644 platform/linux-generic/pktio/sysfs.c > For the series Reviewed-and-tested-by: Stuart Haslam ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [API-NEXT PATCHv7 5/5] validation: implement pktio statistics counters

On Fri, Jan 22, 2016 at 03:45:40PM +0300, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov > --- > test/validation/pktio/pktio.c | 166 > ++ > test/validation/pktio/pktio.h | 2 + > 2 files changed, 168 insertions(+) > > diff --git a/test/validation/pk

[lng-odp] [PATCHv2 5/5] linux-generic: validation: add netmap test

). Signed-off-by: Stuart Haslam --- platform/linux-generic/test/Makefile.am| 5 + platform/linux-generic/test/pktio/pktio_run_netmap | 133 + 2 files changed, 138 insertions(+) create mode 100755 platform/linux-generic/test/pktio/pktio_run_netmap diff --git a/platform

[lng-odp] [PATCHv2 2/5] linux-generic: pktio: support using netmap: prefix

ktio_open("netmap:eth0") fails. It's useful to be able to explicitly use the netmap interface, especially when testing, if you don't want fallback to other pktio types. Signed-off-by: Stuart Haslam --- platform/linux-generic/include/odp_packet_netmap.h | 2 ++ platf

[lng-odp] [PATCHv2 3/5] linux-generic: pktio: add support for netmap VALE and pipe virtual ports

used for connections between virtual machines. netmap pipes connect two virtual netmap ports with a crossover connection, they can be used in a setup where a master process works as a dispatcher towards slave processes. Signed-off-by: Stuart Haslam --- platform/linux-generic/include

[lng-odp] [PATCHv2 4/5] linux-generic: netmap: support segmented packets

Replace the nm_inject() helper with our own version so that odp_packet_copydata_out() can be used as this understands segmented packets. Signed-off-by: Stuart Haslam --- platform/linux-generic/pktio/netmap.c | 57 --- 1 file changed, 52 insertions(+), 5 deletions

[lng-odp] [PATCHv2 1/5] validation: pktio: make MAC address and promiscuous mode optional

e test will also now restore the state to how it was at the beginning of the test, which it didn't necessarily do previously. Signed-off-by: Stuart Haslam --- test/validation/pktio/pktio.c | 80 +++ 1 file changed, 58 insertions(+), 22 deletions(-) dif

[lng-odp] [PATCHv2 0/5] netmap virtual ports and validation tests

switch. For example names "valea:0" and "valea:1" give you two ports on the same switch. To open a pipe use names e.g. "valea:0{0" for master and "valea:0}0" for slave. Stuart Haslam (5): validation: pktio: make MAC address and promiscuous mode optional li

[lng-odp] [RESEND PATCH] linux-generic: pktio: remove unwanted initialisation

Remove an unwanted initialisation and fix a bad indentation which crept in during a merge. Signed-off-by: Stuart Haslam Reviewed-by: Ivan Khoronzhuk --- Added missing s-o-b. platform/linux-generic/pktio/loop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/platform

Re: [lng-odp] [API-NEXT PATCH v3 0/6] Multi-queue pktio for poll mode

On Thu, Jan 21, 2016 at 08:17:18AM +, Elo, Matias (Nokia - FI/Espoo) wrote: > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > > Stuart > > Haslam > > Sent: Wednesday, January 20, 2016 6:58 PM > &g

Re: [lng-odp] [PATCH] validation: pktio: assign MAC address if one loop pktio is used

On Thu, Jan 14, 2016 at 12:56:31PM +0200, Ivan Khoronzhuk wrote: > In case of one loop pktio the MAC address is not set in the packets > but should be. > > Signed-off-by: Ivan Khoronzhuk > --- > test/validation/pktio/pktio.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletion

Re: [lng-odp] [PATCH] linux-generic: timer: limit notification about resolution incorrectness

On Fri, Jan 22, 2016 at 05:07:31PM +0200, Ivan Khoronzhuk wrote: > https://bugs.linaro.org/show_bug.cgi?id=1992 > > Signed-off-by: Ivan Khoronzhuk Reviewed-and-Tested-by: Stuart Haslam > --- > platform/linux-generic/odp_timer.c | 14 ++ > 1 file changed, 1

Re: [lng-odp] [PATCH] linux-generic: packet_io: expose pktio_tbl and is_free()

On Wed, Jan 20, 2016 at 06:29:53PM +, Zoltan Kiss wrote: > The table and the accessor would be used by ODP-DPDK, when it scans > through all the pktio interfaces to flush out TX completed buffers. > > Signed-off-by: Zoltan Kiss Reviewed-by: Stuart Haslam > --- > plat

Re: [lng-odp] [API-NEXT PATCH v3 0/6] Multi-queue pktio for poll mode

On Tue, Jan 19, 2016 at 06:14:24PM +, Stuart Haslam wrote: > On Mon, Jan 11, 2016 at 01:39:37PM +0200, Petri Savolainen wrote: > I did notice a bit of an issue when testing though, but it wasn't > introduced by these changes. When trying to test socket pktios I

Re: [lng-odp] [PATCH] test/performance: pktio: perform an initial warmup run

x27;t those results from l2fwd? this patch is a change to odp_pktio_perf. The change isn't really intended to improve performance, just to make results more consistent. You're not likely to notice any difference on machine with non-isolated cores as runs won't be consistent anyway

Re: [lng-odp] [API-NEXT PATCH v3 0/6] Multi-queue pktio for poll mode

generic/odp_queue.c | 2 + > platform/linux-generic/pktio/netmap.c | 124 +--- > test/performance/odp_l2fwd.c | 797 > - > 6 files changed, 632 insertions(+), 516 deletions(-) > One minor nit about missing help te

Re: [lng-odp] [API-NEXT PATCH v3 6/6] test: l2fwd: added poll queue mode

On Mon, Jan 11, 2016 at 01:39:43PM +0200, Petri Savolainen wrote: > Added poll queue mode (mode == 4), which uses poll type queues > for packet input. Configuration and functionality is very similar > to direct recv mode. > > Signed-off-by: Petri Savolainen > --- > test/performance/odp_l2fwd.c |

Re: [lng-odp] [API-NEXT PATCH v3 0/6] Multi-queue pktio for poll mode

On Mon, Jan 18, 2016 at 05:58:37PM +0300, Maxim Uvarov wrote: > Stuart, can you please review this? > > Maxim. I've just run it through the validation tests and all seems well, I've have a closer look at the changes tomorrow. -- Stuart. ___ lng-odp ma

Re: [lng-odp] [PATCHv19 9/9] linux-generic: internal ipc_pktio test

On Mon, Jan 18, 2016 at 12:59:44PM +0300, Maxim Uvarov wrote: > On 01/15/2016 15:57, Stuart Haslam wrote: > >On Mon, Dec 21, 2015 at 01:56:11PM +0300, Maxim Uvarov wrote: > >>2 example ipc pktio applications create ipc pktio to each other and do > >>packet transfer, v

[lng-odp] [PATCH] validation: pktio: reduce stdout noise

Printing the pktio info every time a pktio is opened generates a load of noise on stdout and makes it difficult to see the status of individual test cases. Signed-off-by: Stuart Haslam --- Log goes from this: http://people.linaro.org/~stuart.haslam/pktio1.log To this: http://people.linaro.org

Re: [lng-odp] [PATCH] validation: pktio: don't continue if packet with > MTU is sent

On Fri, Jan 15, 2016 at 05:53:20PM +0200, Ivan Khoronzhuk wrote: > > > On 15.01.16 17:51, Stuart Haslam wrote: > >On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote: > >>If packet with size > MTU is sent the test can crash farther, > >>so better

Re: [lng-odp] [PATCH] validation: pktio: don't continue if packet with > MTU is sent

On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote: > If packet with size > MTU is sent the test can crash farther, > so better to stop here. > > Signed-off-by: Ivan Khoronzhuk Signed-off-by: Stuart Haslam > --- > test/validation/pktio/pktio.c | 2 +-

[lng-odp] [PATCH] linux-generic: pktio: support multiple loop interfaces

ers for N are 0-254. Signed-off-by: Stuart Haslam --- .../linux-generic/include/odp_packet_io_internal.h | 1 + platform/linux-generic/pktio/loop.c| 40 +- 2 files changed, 32 insertions(+), 9 deletions(-) diff --git a/platform/linux-generic/include/odp_packet_io_i

[lng-odp] [PATCH] linux-generic: pktio: remove unwanted initialisation

Remove an unwanted initialisation and fix a bad indentation which crept in during a merge. --- platform/linux-generic/pktio/loop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/platform/linux-generic/pktio/loop.c b/platform/linux-generic/pktio/loop.c index 47745ad..95644c4

Re: [lng-odp] [PATCH] test/performance: pktio: perform an initial warmup run

ping^2 On 11 December 2015 at 16:54, Stuart Haslam wrote: > ping - needs review. > > On 28 October 2015 at 18:45, Stuart Haslam wrote: >> The results from the initial test run are often worse than would >> normally be expected due to there being no warm up phase. As a >

[lng-odp] [PATCH API-NEXT] api: pktio: remove unused ODP_PKTIO_ANY

ODP_PKTIO_ANY is defined in the API header but there's no description of its intended use and it wouldn't make sense to pass it to the majority of exisitng APIs that take odp_pktio_t handles. It's not currently used anywhere, so remove it. Signed-off-by: Stuart Haslam ---

Re: [lng-odp] [PATCHv19 8/9] linux-generic: add ipc pktio support

On Mon, Dec 21, 2015 at 01:56:10PM +0300, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/Makefile.am | 3 + > .../linux-generic/include/odp_buffer_internal.h| 3 + > .../linux-generic/include/odp_packet_io_internal.h | 38 ++ > .../includ

Re: [lng-odp] [PATCHv19 9/9] linux-generic: internal ipc_pktio test

On Mon, Dec 21, 2015 at 01:56:11PM +0300, Maxim Uvarov wrote: > 2 example ipc pktio applications create ipc pktio to each other and do > packet transfer, validation magic numbers and packets sequence counters > inside it. > It looks like there's a race somewhere as I get occasional failures: #2

Re: [lng-odp] Maintain code copy-pasted from linux-generic in ODP-DPDK

On Thu, Jan 14, 2016 at 04:13:06PM +, Zoltan Kiss wrote: > > > On 13/01/16 13:37, Mike Holmes wrote: > > > > > >On 13 January 2016 at 03:49, Maxim Uvarov >> wrote: > > > >On 01/12/2016 21:57, Zoltan Kiss wrote: > > > >Hi, > > > >We have a c

Re: [lng-odp] [PATCH v2] test: perf: l2fwd detect missing odp_generator

On Wed, Jan 13, 2016 at 08:52:07AM -0500, Mike Holmes wrote: > The script did not check that the odp_generator was present. > Updates to ensure the clean up is always called at EXIT > > Signed-off-by: Mike Holmes Reviewed-by: Stuart Haslam > --- > v2: >Use stuarts

Re: [lng-odp] [PATCH] validation: classification: remove double frees

On Wed, Jan 13, 2016 at 03:30:03PM +0300, Maxim Uvarov wrote: > Please resend this patch with Review. Original patch is missing for > unknown reason. > > Maxim. Mails from Nicolas get flagged as spam by google, looks to be due to a DKIM failure. "It has a from address in kalray.eu but has fail

Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

input format > > Fixes ipv4 address input format issue. > > Maxim. > > On 01/13/2016 13:43, Stuart Haslam wrote: > >On Tue, Jan 05, 2016 at 04:10:36PM +0100, Nicolas Morey-Chaisemartin wrote: > >>Signed-off-by: Nicolas Morey-Chaisemartin > >Reviewed-by:

Re: [lng-odp] [PATCH] test: perf: l2fwd detect missing odp_generator

On Tue, Jan 12, 2016 at 05:36:35PM -0500, Mike Holmes wrote: > The script did not check that the odp_generator was present and worse it > failed silently if it was not present. > > Signed-off-by: Mike Holmes > --- > test/performance/odp_l2fwd_run | 10 ++ > 1 file changed, 10 insertions(

Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

On Tue, Jan 05, 2016 at 04:10:36PM +0100, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin Reviewed-by: Stuart Haslam > --- > example/classifier/odp_classifier.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/

Re: [lng-odp] [PATCH 2/2] example: ipsec: initialise packet length and tailroom correctly

On Wed, Jan 06, 2016 at 04:10:01PM -0600, Bill Fischofer wrote: > On Wed, Jan 6, 2016 at 5:33 AM, Stuart Haslam > wrote: > > > The example scripts run_esp_out, run_ah_out and run_both_out are failing > > due to test packet meta data being initialised incorrectly. > >

Re: [lng-odp] [PATCH 0/2] Execute a linux-generic process mode test

On Wed, Jan 06, 2016 at 02:23:04PM +, Stuart Haslam wrote: > On Tue, Jan 05, 2016 at 10:29:30AM -0500, Mike Holmes wrote: > > Linux generic supports threads and theoretically processes as the worker > > and control tasks but process mode is never tested. > > Add the

Re: [lng-odp] [PATCH 0/2] Execute a linux-generic process mode test

checked in. Other than that the changes look good to me. Reviewed-and-Tested-by: Stuart Haslam > .../test/{ => validation}/Makefile.am | 14 +- > .../test/{ => validation}/pktio/.gitignore | 0 > .../test/{ => validation}/pktio/Makefile.am

[lng-odp] [PATCHv4] validation: pktio: test batch receive

Modify the tests that currently transmit packets in batches to also receive packets in batches. This adds coverage of odp_queue_deq_multi() and odp_schedule_multi() specifically against a packet input queue, as this doesn't get tested anywhere else in the validation suite. Signed-off-by: S

Re: [lng-odp] [PATCHv3] validation: pktio: test batch receive

On Wed, Jan 06, 2016 at 07:30:42AM -0500, Mike Holmes wrote: > Needs a rebase > Awh man, more time API changes. v4 coming up. -- Stuart. ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [API-NEXT PATCH] linux-generic: netmap: add odp_pktio_link_status()

On Mon, Jan 04, 2016 at 11:59:35AM +0200, Matias Elo wrote: > Implements new odp_pktio_link_status() API call and renames > old netmap_link_status() to netmap_wait_for_link(). > > Also fixes invalid comments. > > Signed-off-by: Matias Elo Reviewed-by: Stuart Haslam >

Re: [lng-odp] [PATCHv3] validation: pktio: test batch receive

On Fri, Dec 18, 2015 at 12:07:57PM +, Stuart Haslam wrote: > Modify the tests that currently transmit packets in batches to also > receive packets in batches. This adds coverage of odp_queue_deq_multi() > and odp_schedule_multi() specifically against a packet input queue, > as this

[lng-odp] [PATCH 1/2] example: ipsec: fix endianness of IP address checks

Convert IP addresses in packet header from network to CPU byte order before comparing with policy cache. Signed-off-by: Stuart Haslam --- example/ipsec/odp_ipsec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index

[lng-odp] [PATCH 2/2] example: ipsec: initialise packet length and tailroom correctly

The example scripts run_esp_out, run_ah_out and run_both_out are failing due to test packet meta data being initialised incorrectly. Signed-off-by: Stuart Haslam --- This is a minimal change to fix the bug, but I'm not convinced the way packets are created here is valid. It

Re: [lng-odp] [PATCH] validation: pktio: refactor error handling during sequence check

ikely that seq reaches UINT32_MAX, the function > should check for it. > > Signed-off-by: Zoltan Kiss Reviewed-by: Stuart Haslam > --- > diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c > index 4de3ff8..ff6ece9 100644 > --- a/test/validation/

[lng-odp] [PATCH] validation: export missing test functions

All test functions should be non-static and declared in the module's header file. Signed-off-by: Stuart Haslam --- test/validation/classification/classification.h | 6 ++ test/validation/classification/odp_classification_test_pmr.c | 10 +- test/validation/

[lng-odp] [PATCH] linux-generic: validation: pktio: report test as skipped when setup fails

ff-by: Stuart Haslam --- platform/linux-generic/test/pktio/pktio_run | 4 1 file changed, 4 insertions(+) diff --git a/platform/linux-generic/test/pktio/pktio_run b/platform/linux-generic/test/pktio/pktio_run index 3f73556..7029ab2 100755 --- a/platform/linux-generic/test/pktio/pktio_run

[lng-odp] [PATCHv3] validation: pktio: test batch receive

Modify the tests that currently transmit packets in batches to also receive packets in batches. This adds coverage of odp_queue_deq_multi() and odp_schedule_multi() specifically against a packet input queue, as this doesn't get tested anywhere else in the validation suite. Signed-off-by: S

Re: [lng-odp] [PATCHv2] validation: pktio: test batch receive

On Fri, Dec 18, 2015 at 01:43:18PM +0300, Maxim Uvarov wrote: > One comment bellow, other things look good. > > Maxim. > > On 12/11/2015 20:10, Stuart Haslam wrote: > >Modify the tests that currently transmit packets in batches to also > >receive packets in bat

Re: [lng-odp] [API-NEXT PATCH 09/19] linux-generic: netmap: add netmap_link_status() function

On Wed, Dec 16, 2015 at 03:45:34PM +0200, Petri Savolainen wrote: > From: Matias Elo > > Added a separate function for determining if the netmap link > is up. > > Signed-off-by: Matias Elo > --- > platform/linux-generic/pktio/netmap.c | 48 > +-- > 1 file chang

Re: [lng-odp] [PATCHv2] validation: pktio: test batch receive

On Fri, Dec 11, 2015 at 05:10:51PM +, Stuart Haslam wrote: > Modify the tests that currently transmit packets in batches to also > receive packets in batches. This adds coverage of odp_queue_deq_multi() > and odp_schedule_multi() specifically against a packet input queue, > as this

Re: [lng-odp] [API-NEXT PATCHv4 1/5] linux-generic: sockets: implement pktio statistics counters

On Tue, Dec 15, 2015 at 03:25:31PM +0300, Maxim Uvarov wrote: > On 12/03/2015 15:32, Stuart Haslam wrote: > >On Tue, Nov 24, 2015 at 04:10:44PM +0300, Maxim Uvarov wrote: > >>Signed-off-by: Maxim Uvarov > >>--- > >> platform/linux-generic/Makefile.am

[lng-odp] [PATCH] linux-generic: include netmap headers with -isystem

The netmap header file has some dubious casts that generate errors when -Wcast-qual is enabled. Include it as a system header so that the compiler ignores those errors without having to ignore errors in our own source files. Signed-off-by: Stuart Haslam --- platform/linux-generic/m4

[lng-odp] [PATCHv2] validation: pktio: test batch receive

Modify the tests that currently transmit packets in batches to also receive packets in batches. This adds coverage of odp_queue_deq_multi() and odp_schedule_multi() specifically against a packet input queue, as this doesn't get tested anywhere else in the validation suite. Signed-off-by: S

Re: [lng-odp] [PATCH] test/performance: pktio: perform an initial warmup run

ping - needs review. On 28 October 2015 at 18:45, Stuart Haslam wrote: > The results from the initial test run are often worse than would > normally be expected due to there being no warm up phase. As a > simple way to warm up run first test stage twice, ignoring the > results of t

Re: [lng-odp] [PATCHv5 0/4] TAP pktio

es. > ODP_WAIT_FOR_NETWORK used to run tests. > * rebased on current master > > Version 4: > * changed error handling part in tap_pktio_send. (Stuart Haslam) > > Version 3: > * return 77 (TEST_SKIPPED) if user is not root. (Stuart Haslam) > >

Re: [lng-odp] [PATCHv5 2/4] validation: pktio: ability to wait for external network

On Thu, Dec 10, 2015 at 06:32:02PM +0300, Ilya Maximets wrote: > 'ODP_WAIT_FOR_NETWORK' environment variable may be used > to wait some time right after pktio_open(). > > Signed-off-by: Ilya Maximets > --- > > 'ODP_WAIT_FOR_NETWORK' also may be used to remove sleep(1) > from netmap pktio in the

Re: [lng-odp] [API-NEXT PATCH v2 4/5] linux-generic: netmap: add multi queue support

On Wed, Nov 25, 2015 at 03:15:52PM +0200, Matias Elo wrote: > Added multi queue support to netmap pktio. > > Signed-off-by: Matias Elo > --- > platform/linux-generic/include/odp_packet_netmap.h | 34 +- > platform/linux-generic/pktio/netmap.c | 426 > ++--- > 2 fil

Re: [lng-odp] [PATCH] example: classifier: fix add queue param init call

On Fri, Dec 11, 2015 at 02:46:28PM +0530, Balasubramanian Manoharan wrote: > Fixes crash caused by queue param not being initialized. > > Signed-off-by: Balasubramanian Manoharan That fixed it.. Reviewed-by: Stuart Haslam > --- > example/classifier/odp_classifier.c | 1 + &g

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

On Thu, Dec 10, 2015 at 06:01:05PM +0300, Maxim Uvarov wrote: > How to reproduce that it is broken? > I was looking at: sudo ODP_PLATFORM=linux-generic ./test/performance/odp_l2fwd_run This shows a few packets going through initially then 0. Turns out this is related to the netmap pktio, this w

Re: [lng-odp] [PATCH] test: performance: set a packet rate pass threshold for l2fwd

ping odp_generator appears to be broken on master, this would've caught it. Stuart. On 11 November 2015 at 15:01, Stuart Haslam wrote: > Report a failure if the maximum achieved packet rate is less than a > predefined threshold (currently set at 5000pps). > > Signed-off-

Re: [lng-odp] [HELP] odp_classification no match ?

On Thu, Dec 10, 2015 at 06:48:06PM +0530, Bala Manoharan wrote: > Looks like a previous commit has changed the Ip address format > As a work around pls provide IP address format in hexadecimal. > For eg "10.10.10.1" ==> "A.A.A.1". > In my case fixing the IP address format (s/SCNx32/SCNd32) just e

Re: [lng-odp] [HELP] odp_classification no match ?

On Thu, Dec 10, 2015 at 08:48:53AM +, Kury Nicolas wrote: > Hi > > > I'm trying odp_classification (ODP linux-generic 1.5) and I'm not sure if I'm > doing something wrong or if it's a bug. > > uname -a : 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC > 2015 x86_64 x86_64

Re: [lng-odp] [API-NEXT PATCH] validation: Makefiles: change install location

On Thu, Dec 10, 2015 at 02:29:30PM +0300, Maxim Uvarov wrote: > All tests should be installed under testdir variable and not in the bin > directory. > > Signed-off-by: Maxim Uvarov Reviewed-by: Stuart Haslam > --- > test/validation/hash/Makefile.am | 2 +- > tes

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

On Thu, Dec 03, 2015 at 08:39:26AM -0500, Mike Holmes wrote: > It does miss it apparently - just shows you we still need a human eye > I have this in my ~/.gitconfig [core] whitespace = trailing-space,space-before-tab,indent-with-non-tab and it warns about it: Applying: helper: table:

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

On Tue, Dec 08, 2015 at 03:17:46PM +, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > > Ilya Maximets > > Sent: Tuesday, December 08, 2015 4:48 PM >

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

On Tue, Dec 08, 2015 at 12:21:06PM +, Elo, Matias (Nokia - FI/Espoo) wrote: > Hi Ilya, > > I had completely missed your previous patch. You could also remove the two > errno value checks in pktio_test_send_failure(). They are not defined in the > API, so they should not be tested. > > -Mati

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

On Tue, Dec 08, 2015 at 03:25:01PM +0300, Ilya Maximets wrote: > > > On 08.12.2015 15:16, Stuart Haslam wrote: > > On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote: > >> On 08.12.2015 14:24, Stuart Haslam wrote: > >>> On Mon, Dec 07, 2015 at 0

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote: > On 08.12.2015 14:24, Stuart Haslam wrote: > > On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote: > >> Creates a new pktio type that allows for creating and > >> sending/receiving packets throug

Re: [lng-odp] [PATCH 00/10] Pktio checks

./classification/odp_classification_test_pmr.c | 25 +++-- > test/validation/pktio/pktio.c | 116 > ++--- > 4 files changed, 140 insertions(+), 28 deletions(-) > For the series: Reviewed-by: Stuart Haslam -- Stuart. ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] linux-generic: socket: set up __odp_errno on ioctl failures

On Mon, Dec 07, 2015 at 05:25:03PM +0300, Ilya Maximets wrote: > Also debug output enhanced. > > Signed-off-by: Ilya Maximets Reviewed-by: Stuart Haslam > --- > platform/linux-generic/pktio/socket.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-)

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote: > Creates a new pktio type that allows for creating and > sending/receiving packets through TAP interface. > It is intended for use as a simple conventional communication > method between applications that use kernel network stack > (pi

Re: [lng-odp] [PATCHv2 3/3] linux-generic: pktio: add test for tap pktio

On Wed, Dec 02, 2015 at 04:13:25PM +0300, Ilya Maximets wrote: > Signed-off-by: Ilya Maximets > --- > platform/linux-generic/test/Makefile.am | 1 + > platform/linux-generic/test/pktio/Makefile.am | 3 +- > platform/linux-generic/test/pktio/pktio_run_tap | 111 > +++

Re: [lng-odp] [API-NEXT PATCHv4 1/5] linux-generic: sockets: implement pktio statistics counters

On Tue, Nov 24, 2015 at 04:10:44PM +0300, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/Makefile.am | 2 + > .../linux-generic/include/odp_packet_io_internal.h | 11 ++ > platform/linux-generic/include/odp_packet_socket.h | 6 + > platform/l

[lng-odp] [PATCHv3 3/3] Makefile.am: run tests during distcheck

The distcheck target is intended to ensure that a built distribution will actually work. As part of the process it runs "make check" and "make installcheck", but these don't actually do much useful testing without the appropriate flags having been passed during configur

[lng-odp] [PATCHv3 1/3] validation: ability to specify test install directory

he default behaviour to not install test binaries or scripts and adds a configure parameter (--with-testdir) to explicitly enable installation. These changes are required in order to be able to package the tests separately (e.g. in OpenEmbedded) and also to enable post-install testing. Signed-off-

[lng-odp] [PATCHv3 2/3] linux-generic: validation: add run-test script for post install testing

components do actually get installed correctly, using "make installcheck". ./configure --enable-test-vald --with-testdir DESTDIR=$(pwd)/test-install make install installcheck Signed-off-by: Stuart Haslam --- Change in v2: moved an endif in the Makefile to fix issue with distcheck pl

Re: [lng-odp] [API-NEXT PATCH v3 6/7] linux-generic: pktio: dummy multi-queue pktio

On Fri, Nov 20, 2015 at 02:40:29PM +0100, Anders Roxell wrote: > On 2015-11-20 13:40, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > Did you try --with-netmap-path=xxx ? > > No, didn't see that I had to do that... > what will that give me? =) > When you build with netmap enabled it adds "-Wno-c

[lng-odp] [PATCHv2 1/3] validation: ability to specify test install directory

he default behaviour to not install test binaries or scripts and adds a configure parameter (--with-testdir) to explicitly enable installation. These changes are required in order to be able to package the tests separately (e.g. in OpenEmbedded) and also to enable post-install testing. Signed-off-

[lng-odp] [PATCHv2 3/3] Makefile.am: run tests during distcheck

The distcheck target is intended to ensure that a built distribution will actually work. As part of the process it runs "make check" and "make installcheck", but these don't actually do much useful testing without the appropriate flags having been passed during configur

[lng-odp] [PATCHv2 2/3] linux-generic: validation: add run-test script for post install testing

components do actually get installed correctly, using "make installcheck". ./configure --enable-test-vald --with-testdir DESTDIR=$(pwd)/test-install make install installcheck Signed-off-by: Stuart Haslam --- Change in v2: moved an endif in the Makefile to fix issue with distcheck pl

Re: [lng-odp] [PATCH] validation: pktio: test batch receive

On Thu, Nov 19, 2015 at 01:43:23PM +0200, Ivan Khoronzhuk wrote: > Sruart, Maxim > > It will likely have conflicts with time API that gets rid of cycles > dependency. > It should be rebased on api-next or api-next merged in master and then > rebased. > OK, I'll wait for it to get a Reviewed-by

Re: [lng-odp] [PATCH 4/5] validation: classification: add odp_cls_cos_pool_set() api

On Tue, Nov 17, 2015 at 11:46:52AM +0530, Balasubramanian Manoharan wrote: > Assigns a packet pool to CoS using odp_cls_cos_pool_set() api. > This tests that you can assign a pool to a CoS but since it uses the same default_pool it doesn't actually test that it's possible to deliver packets into

Re: [lng-odp] [PATCH 1/5] api: classification: add odp_cls_cos_pool_set() api

On Tue, Nov 17, 2015 at 11:46:49AM +0530, Balasubramanian Manoharan wrote: > odp_cls_cos_pool_set() api is used to configure packet pool to CoS. > The packets arriving at the CoS is allocated from the configured pool > > Signed-off-by: Balasubramanian Manoharan > --- > include/odp/api/classifica

Re: [lng-odp] [PATCH 3/5] linux-generic: classification: implements odp_cls_cos_pool_set() api

On Tue, Nov 17, 2015 at 11:46:51AM +0530, Balasubramanian Manoharan wrote: > Adds support for configuring packet pool to a class-of-service. > linux-generic packet parser is enhanced to parse a packet directly from > a memory location rather than from odp_packet_t. > > packet receive code is modif

[lng-odp] [PATCH] validation: remove strict dependency on CUnit 2.1-3

time. We now don't use the CU_TestInfo structure directly in any of our tests so a couple of small changes in the common code make the issue go away. Tested with CUnit versions 2.1-2.dfsg-1 (packaged with Ubuntu 14.04) and 2.1-3 (which most people will still be using). Signed-off-by: Stuart

[lng-odp] [PATCH] validation: pktio: test batch receive

Modify the tests that currently transmit packets in batches to also receive packets in batches. This adds coverage of odp_queue_deq_multi() and odp_schedule_multi() specifically against a packet input queue, as this doesn't get tested anywhere else in the validation suite. Signed-off-by: S

[lng-odp] [PATCH] validation: scheduler: add missing ticketlock unlock

The scheduler validation test occasionally deadlocks due to a missing ticketlock unlock. Signed-off-by: Stuart Haslam --- test/validation/scheduler/scheduler.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/test/validation/scheduler/scheduler.c b/test

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

On Wed, Nov 18, 2015 at 03:30:31PM +, Stuart Haslam wrote: > On Tue, Nov 17, 2015 at 11:15:14AM -0600, Bill Fischofer wrote: > > Add a basic ODP overview to the User's Guide, providing > > an overview of ODP concepts, components, etc. Included > > are a number of d

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

On Tue, Nov 17, 2015 at 11:15:14AM -0600, Bill Fischofer wrote: > Add a basic ODP overview to the User's Guide, providing > an overview of ODP concepts, components, etc. Included > are a number of diagrams covering component structure > as well as packet RX, event scheduling, and packet TX > proces

Re: [lng-odp] [API-NEXT PATCHv2 1/5] linux-generic: sockets: implement pktio statistics counters

On Wed, Nov 18, 2015 at 12:34:24PM +0300, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/Makefile.am | 2 + > .../linux-generic/include/odp_packet_io_internal.h | 11 ++ > platform/linux-generic/include/odp_packet_socket.h | 6 + > platform/l

Re: [lng-odp] [API-NEXT PATCHv2 1/5] linux-generic: sockets: implement pktio statistics counters

On Wed, Nov 18, 2015 at 12:34:24PM +0300, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/Makefile.am | 2 + > .../linux-generic/include/odp_packet_io_internal.h | 11 ++ > platform/linux-generic/include/odp_packet_socket.h | 6 + > platform/l

Re: [lng-odp] [PATCH v3] linux-generic: pktio: print out the name of pktio used

On Mon, Nov 16, 2015 at 05:37:07PM +, Zoltan Kiss wrote: > For debug purposes, otherwise it's not trivial to figure out which pktio was > successful. > > Signed-off-by: Zoltan Kiss Reviewed-by: Stuart Haslam > -- > > v2: > - change the string for loopback a

Re: [lng-odp] [PATCH v2] linux-generic: pktio: print out the name of pktio used

On Wed, Nov 11, 2015 at 05:51:18PM +, Zoltan Kiss wrote: > For debug purposes, otherwise it's not trivial to figure out which pktio was > successful. > > Signed-off-by: Zoltan Kiss > -- > > v2: > - change the string for loopback and socket interfaces > - also add it to odp_pktio_print() > >

[lng-odp] [PATCH] linux-generic: validation: run config tests

Add the new config tests to the TESTS list so that they get run via "make check". Signed-off-by: Stuart Haslam --- platform/linux-generic/test/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic/test/Makefile.am b/platform/linux-generic/test/Makefil

Re: [lng-odp] [API-NEXT PATCH 1/5] linux-generic: sockets: implement pktio statistics counters

On Fri, Nov 13, 2015 at 04:56:58PM +0300, Maxim Uvarov wrote: > On 11/13/2015 16:45, Stuart Haslam wrote: > >On Thu, Nov 12, 2015 at 05:14:22PM +0300, Maxim Uvarov wrote: > >>On 11/10/2015 21:29, Stuart Haslam wrote: > >>>On Mon, Nov 09, 2015 at 02:21:49PM +0300, Ma

  1   2   3   4   5   6   7   >