Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

2017-04-27 Thread Bill Fischofer
On Thu, Apr 27, 2017 at 6:34 PM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > Bill, > > Thank you for your review! > > On 27.04.2017 20:34, Bill Fischofer wrote: > > I realize this is still an RFC, but FYI, this has some compilation > issues: > > > > CC

Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

2017-04-27 Thread Dmitry Eremin-Solenikov
Bill, Thank you for your review! On 27.04.2017 20:34, Bill Fischofer wrote: > I realize this is still an RFC, but FYI, this has some compilation issues: > > CC odp_ipsec.lo > odp_ipsec.c: In function ‘odp_ipsec_in’: > odp_ipsec.c:1219:16: error: comparison between signed and unsigned >

Re: [lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

2017-04-27 Thread Bill Fischofer
I realize this is still an RFC, but FYI, this has some compilation issues: CC odp_ipsec.lo odp_ipsec.c: In function ‘odp_ipsec_in’: odp_ipsec.c:1219:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] while (in_pkt < input->num_pkt && out_pkt <

[lng-odp] [[RFCv2] 4/4] linux-gen: ipsec: draft IPsec implementation

2017-04-27 Thread Dmitry Eremin-Solenikov
For now it's only a preview with the following limitation: - No inline processing support - No SA lookups - Only IPv4 support - No zeroing of mutable IPv4 options for AH ICV calculation - No replay protection - No ESN support Signed-off-by: Dmitry Eremin-Solenikov