class of service create function now takes pool, queue, drop policy and
name as input parameters.
Adds class of service parameter structure odp_cls_cos_param_t and
initialization function odp_cls_cos_param_init()
Signed-off-by: Balasubramanian Manoharan
---
v2: additional documentation and review
On Wed, Dec 16, 2015 at 3:28 AM, Balasubramanian Manoharan <
bala.manoha...@linaro.org> wrote:
> class of service create function now takes pool, queue, drop policy and
> name as input parameters.
> Adds class of service parameter structure odp_cls_cos_param_t and
> initialization function odp_cls
The reason for having odp_cls_xxx is that class of service module
contains class of service and packet matching rule and we need a
common syntax to identify the module hence odp_cls_xxx is used as
common prefix.
I agree all the functions in classifier module needs to be changed to
add the prefix o
My argument is that odp_cls_cos_xxx is redundant and odp_cos_xxx is both
less cumbersome and more intuitive for the application writer. Consider
that if a Class of Service is only used in classification then there's no
need for the redundant cls prefix. But if we ever extend classes of
service to
DPI API could define “Pattern Matching Rules”.
-Petri
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Bill
Fischofer
Sent: Thursday, December 17, 2015 11:59 AM
To: Bala Manoharan
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification
*From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of *EXT
> Bill Fischofer
> *Sent:* Thursday, December 17, 2015 11:59 AM
> *To:* Bala Manoharan
> *Cc:* LNG ODP Mailman List
> *Subject:* Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add
> class of serivc
FI/Espoo)
Cc: Bala Manoharan; LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of
serivce create api
I agree with that general convention, however a class of service is a first
class entity (like a pool). It's why we have odp_pool_create() and
is shallow/fixed packet inspection on predefined header
> fields (to keep it fast).
>
>
>
> -Petri
>
>
>
>
>
>
>
> *From:* EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
> *Sent:* Thursday, December 17, 2015 1:27 PM
> *To:* Savolainen, Petri (Nok
ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of
serivce create api
Fair enough, but then it seems we then need to add the odp_cls prefix to a lot
more APIs and typedefs in the existing classification.h to be fully consistent.
Right now there
*Cc:* Bala Manoharan; LNG ODP Mailman List
> *Subject:* Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add
> class of serivce create api
>
>
>
> Fair enough, but then it seems we then need to add the odp_cls prefix to a
> lot more APIs and typedefs in the existing cl
, December 17, 2015 1:54 PM
>>
>>
>> To: Savolainen, Petri (Nokia - FI/Espoo)
>> Cc: Bala Manoharan; LNG ODP Mailman List
>> Subject: Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add
>> class of serivce create api
>>
>>
>>
>>
> >>
> >>
> >>
> >> From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
> >> Sent: Thursday, December 17, 2015 1:54 PM
> >>
> >>
> >> To: Savolainen, Petri (Nokia - FI/Espoo)
> >> Cc: Bala Manoharan; LNG
;> >>
>> >>
>> >>
>> >>
>> >>
>> >> From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
>> >> Sent: Thursday, December 17, 2015 1:54 PM
>> >>
>> >>
>> >> To: Savolainen, Petri (Nokia
t; >>
>> >>
>> >>
>> >> -Petri
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
>> >> Sent: Thursday, December 17, 2015 1:54 PM
>
;> a
>>> >> chain of queues, scheduling, application processing and TM. The
>>> >> initial
>>> >> input queue, pool or packet input drop policy does not matter in later
>>> >> stages. So this CoS (and those parameters) are significant
-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Balasubramanian Manoharan
> Sent: Wednesday, December 16, 2015 11:29 AM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class
> of serivce create api
>
> class of service create
wed-by: Petri Savolainen
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
Balasubramanian Manoharan
Sent: Wednesday, December 16, 2015 11:29 AM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class
of s
EXT/PATCHv2 1/6] api: classification: add class
of serivce create api
class of service create function now takes pool, queue, drop policy and
name as input parameters.
Adds class of service parameter structure odp_cls_cos_param_t and
initialization function odp_cls_cos_param_init()
Signed-off
18 matches
Mail list logo
