As a proposition, we had talk some time ago about,
You moved packet creation to common classification file.
Maybe it's time to assign correct src/dst MAC address, taken from pktio?
In separate patch.
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
On 3 August 2015 at 21:23, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
As a proposition, we had talk some time ago about,
You moved packet creation to common classification file.
Maybe it's time to assign correct src/dst MAC address, taken from pktio?
In separate patch.
Yes. I agree
One more issue
On 30.07.15 18:20, Balasubramanian Manoharan wrote:
Additional test suite is added to classification validation suite to test
individual PMRs. This suite will test the defined PMRs by configuring
pktio separately for every test case.
Signed-off-by: Balasubramanian Manoharan
On 3 August 2015 at 21:44, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
One more issue
On 30.07.15 18:20, Balasubramanian Manoharan wrote:
Additional test suite is added to classification validation suite to test
individual PMRs. This suite will test the defined PMRs by configuring
I don’t think this has to be API-NEXT, it does touch a helper but that is
not the API from odp/include
On 3 August 2015 at 12:24, Bala Manoharan bala.manoha...@linaro.org wrote:
On 3 August 2015 at 21:44, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
One more issue
On 30.07.15 18:20,
On 03.08.15 19:24, Bala Manoharan wrote:
On 3 August 2015 at 21:44, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
One more issue
On 30.07.15 18:20, Balasubramanian Manoharan wrote:
Additional test suite is added to classification
On 3 August 2015 at 22:01, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
On 03.08.15 19:24, Bala Manoharan wrote:
On 3 August 2015 at 21:44, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
One more issue
On 30.07.15 18:20,
Bala,
...
what in case of TCP? Incorrect seq num?
Looks like a coding error. TCP should be added using a boolean flag.
Incorrect seq num is tested in the ASSERT function after
receiving the
packet.
Seq num is used to check whether
On 3 August 2015 at 22:16, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
Bala,
...
what in case of TCP? Incorrect seq num?
Looks like a coding error. TCP should be added using a boolean
flag.
Incorrect seq num is tested in the ASSERT function after
Hi, Bala
On 30.07.15 18:20, Balasubramanian Manoharan wrote:
Additional test suite is added to classification validation suite to test
individual PMRs. This suite will test the defined PMRs by configuring
pktio separately for every test case.
Signed-off-by: Balasubramanian Manoharan
Hi,
On 3 August 2015 at 17:52, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
Hi, Bala
On 30.07.15 18:20, Balasubramanian Manoharan wrote:
Additional test suite is added to classification validation suite to test
individual PMRs. This suite will test the defined PMRs by configuring
I am sorry, as this is not well documented yet (I am currentely working on
the documentation), but this patch does not respect the naming convention
for test function, test-suite...
Possibly you started your work on this before my modification went in...
Anyway here follows the naming convention
Hi Christophe,
Thanks for pointing this out :) I had started this work before the naming
conventions were mandated.
I will follow the naming conventions followed here before my final patch is
out.
I will update these changes along with review comments I get ;)
Regards,
Bala
On 31 July 2015 at
Additional test suite is added to classification validation suite to test
individual PMRs. This suite will test the defined PMRs by configuring
pktio separately for every test case.
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
helper/include/odp/helper/tcp.h
14 matches
Mail list logo
