[lng-odp] [API-NEXT 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

2017-03-08 Thread Dmitry Eremin-Solenikov
Switch AES-CBC and 3DES-CBC to use generic (EVP) interface instad of low level interface (as recommended by OpenSSL documentation). This allows to use the same code path for all non-AEAD ciphers. The only AEAD cipher (AES-GCM) already uses EVP interface. Generalization of that code can happen if th

Re: [lng-odp] [API-NEXT 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

2017-03-09 Thread Bill Fischofer
Checkpatch issue with this part: WARNING: Missing a blank line after declarations #163: FILE: platform/linux-generic/odp_crypto.c:312: + EVP_CIPHER_CTX *ctx = &session->cipher.ctx; + EVP_CIPHER_CTX_init(ctx); CHECK: Avoid CamelCase: #234: FILE: platform/linux-generic/odp_crypto.c:357: + rc = EVP

Re: [lng-odp] [API-NEXT 6/8] linux-generic: crypto: switch to EVP interface for cipher algorithms

2017-03-09 Thread Dmitry Eremin-Solenikov
On 09.03.2017 17:17, Bill Fischofer wrote: > Checkpatch issue with this part: > > WARNING: Missing a blank line after declarations > #163: FILE: platform/linux-generic/odp_crypto.c:312: > +EVP_CIPHER_CTX *ctx = &session->cipher.ctx; > +EVP_CIPHER_CTX_init(ctx); OK, I should fix this. The rest com