Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-22 Thread Mike Holmes
On 22 April 2015 at 06:55, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 04/22/2015 12:39 AM, Mike Holmes wrote: Code rules IMHO - the compiler will ensure we follow the rules. Can we add test cases to prove the behavior across all platforms, linux-generic being one of them, and

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-22 Thread Taras Kondratiuk
On 04/20/2015 02:04 PM, Taras Kondratiuk wrote: On 04/17/2015 11:55 PM, Rosenboim, Leonid wrote: Guys, There are several versions of the Classifier API document floating in Google docs, here is one such copy:

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-22 Thread Radu-Andrei Bulie
; Bulie Radu-Andrei-B37577; bala.manoha...@linaro.org Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation On 04/20/2015 02:04 PM, Taras Kondratiuk wrote: On 04/17/2015 11:55 PM, Rosenboim, Leonid wrote: Guys, There are several

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-22 Thread Radu-Andrei Bulie
@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation On 04/22/2015 04:39 PM, Radu-Andrei Bulie wrote: Hi, One question. The operation of linking a pmr to a port is performed by pmr creation function by providing as src_cos the default port cos

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-22 Thread Taras Kondratiuk
On 04/22/2015 04:39 PM, Radu-Andrei Bulie wrote: Hi, One question. The operation of linking a pmr to a port is performed by pmr creation function by providing as src_cos the default port cos? Right. ___ lng-odp mailing list lng-odp@lists.linaro.org

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-22 Thread Taras Kondratiuk
On 04/22/2015 12:39 AM, Mike Holmes wrote: Code rules IMHO - the compiler will ensure we follow the rules. Can we add test cases to prove the behavior across all platforms, linux-generic being one of them, and thus the code is correct no matter what is written anywhere else. Presumably the api

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-21 Thread Ola Liljedahl
On 21 April 2015 at 14:26, Maxim Uvarov maxim.uva...@linaro.org wrote: On 04/21/15 15:01, Bill Fischofer wrote: Behavior is undefined if rules are ambiguous. Consider the following rules: protocol == UDP -- CoS A port == 1234 -- CoS B What happens if a UDP packet for port 1234 arrives?

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-21 Thread Bala Manoharan
On 21 April 2015 at 18:15, Ola Liljedahl ola.liljed...@linaro.org wrote: On 21 April 2015 at 14:26, Maxim Uvarov maxim.uva...@linaro.org wrote: On 04/21/15 15:01, Bill Fischofer wrote: Behavior is undefined if rules are ambiguous. Consider the following rules: protocol == UDP -- CoS A

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-21 Thread Bill Fischofer
Behavior is undefined if rules are ambiguous. Consider the following rules: protocol == UDP -- CoS A port == 1234 -- CoS B What happens if a UDP packet for port 1234 arrives? Answer: undefined. The result may be either CoS A or CoS B. A better rule set would be: protocol == UDP -- CoS A CoS

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-21 Thread Bill Fischofer
The design doc says what I've been saying here. It's the application's responsibility to ensure that the rule set specified is unambiguous. On Tue, Apr 21, 2015 at 8:08 AM, Bala Manoharan bala.manoha...@linaro.org wrote: On 21 April 2015 at 18:15, Ola Liljedahl ola.liljed...@linaro.org wrote:

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-21 Thread Mike Holmes
Code rules IMHO - the compiler will ensure we follow the rules. Can we add test cases to prove the behavior across all platforms, linux-generic being one of them, and thus the code is correct no matter what is written anywhere else. Presumably the api documentation matches the code but it should

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-21 Thread Ola Liljedahl
On 20 April 2015 at 21:49, Bill Fischofer bill.fischo...@linaro.org wrote: Classification is a collaboration between the implementation and the application. It is the application's responsibility to write unambiguous classification rules and it is the implementation's job to perform the

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-20 Thread Taras Kondratiuk
On 04/17/2015 11:55 PM, Rosenboim, Leonid wrote: Guys, There are several versions of the Classifier API document floating in Google docs, here is one such copy: https://docs.google.com/document/d/14KMqNPIgd7InwGzdP2EaI9g_V3o0_wxpgp3N-nd-RBE/edit?usp=sharing Here is a different

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-20 Thread Ola Liljedahl
On 17 April 2015 at 22:55, Rosenboim, Leonid leonid.rosenb...@caviumnetworks.com wrote: Guys, There are several versions of the Classifier API document floating in Google docs, here is one such copy:

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-20 Thread Bill Fischofer
Classification is a collaboration between the implementation and the application. It is the application's responsibility to write unambiguous classification rules and it is the implementation's job to perform the match as efficiently and as specifically as possible. On Mon, Apr 20, 2015 at 7:33

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-17 Thread Rosenboim, Leonid
Guys, There are several versions of the Classifier API document floating in Google docs, here is one such copy: https://docs.google.com/document/d/14KMqNPIgd7InwGzdP2EaI9g_V3o0_wxpgp3N-nd-RBE/edit?usp=sharing Here is a different perspective on what PMR and COS mean, perhaps in terms of an

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-16 Thread Radu-Andrei Bulie
Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Taras Kondratiuk Sent: Thursday, April 16, 2015 12:54 PM To: leonid.rosenb...@caviumnetworks.com; bala.manoha...@linaro.org Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH] api: classification: connect

Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation

2015-04-16 Thread Radu-Andrei Bulie
] Sent: Thursday, April 16, 2015 4:11 PM To: Bulie Radu-Andrei-B37577 Cc: leonid.rosenb...@caviumnetworks.com; bala.manoha...@linaro.org; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH] api: classification: connect PMR on creation On 04/16/2015 02:04 PM, Radu-Andrei Bulie wrote