Re: [lng-odp] [API-NEXT PATCH] api: queue: remove const qualifier of passed down event array

2016-04-22 Thread Savolainen, Petri (Nokia - FI/Espoo)
No. Actually, odp_pktout_send() should be defined with const odp_packet_t packets[]. Const array tells that the function does not modify handle values. It used when an array is input vs. not used when it’s output (implementation writes the array). E.g. in this case, when enqueue fails, the appl

Re: [lng-odp] [API-NEXT PATCH] api: queue: remove const qualifier of passed down event array

2016-04-21 Thread Bill Fischofer
On Thu, Apr 21, 2016 at 1:31 PM, Zoltan Kiss wrote: > As the description says, normally this function consumes the events, which > means there is no point to expect the array to stay intact. Other functions > like odp_pktout_send() doesn't do that as well. > > Signed-off-by: Zoltan Kiss > Revie

[lng-odp] [API-NEXT PATCH] api: queue: remove const qualifier of passed down event array

2016-04-21 Thread Zoltan Kiss
As the description says, normally this function consumes the events, which means there is no point to expect the array to stay intact. Other functions like odp_pktout_send() doesn't do that as well. Signed-off-by: Zoltan Kiss --- diff --git a/include/odp/api/spec/queue.h b/include/odp/api/spec/q