Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-20 Thread Bill Fischofer
Reviewed-and-tested-by: Bill Fischofer On Tue, Jun 20, 2017 at 2:10 PM Maxim Uvarov wrote: > Does anybody wants to add his review to this patch? According to call a > lot of people needed this patch but no review provided. > > Maxim. > > On

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-20 Thread Maxim Uvarov
Does anybody wants to add his review to this patch? According to call a lot of people needed this patch but no review provided. Maxim. On 06/19/17 15:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> I think queue_t should be removed completely. We should just use >> odp_queue_t for internal

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
> I think queue_t should be removed completely. We should just use > odp_queue_t for internal interfaces as well. Looking at the code, > using odp_queue_t would introduce 3 extra addition instructions and > the impact to cache does not change. We can run l2fwd benchmark and > compare the numbers.

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-16 Thread Honnappa Nagarahalli
On 16 June 2017 at 05:25, Elo, Matias (Nokia - FI/Espoo) wrote: > >>> void *buf_hdr[], int num, int >>> *ret); >>> typedef int (*schedule_init_global_fn_t)(void); >>> typedef int (*schedule_term_global_fn_t)(void); >>> diff --git

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-16 Thread Honnappa Nagarahalli
On 16 June 2017 at 03:03, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > Honnappa Nagarahalli wrote: >> On 12 June 2017 at 06:11, Petri Savolainen >> wrote: >> > Clean up function and parameter naming after modular interface >> > patch.

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-16 Thread Elo, Matias (Nokia - FI/Espoo)
>> void *buf_hdr[], int num, int >> *ret); >> typedef int (*schedule_init_global_fn_t)(void); >> typedef int (*schedule_term_global_fn_t)(void); >> diff --git a/platform/linux-generic/odp_queue.c >> b/platform/linux-generic/odp_queue.c >> index

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-16 Thread Peltonen, Janne (Nokia - FI/Espoo)
Honnappa Nagarahalli wrote: > On 12 June 2017 at 06:11, Petri Savolainen > wrote: > > Clean up function and parameter naming after modular interface > > patch. Queue_t type is referred as "queue internal": queue_int or > > q_int. Term "handle" is reserved for API

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-15 Thread Honnappa Nagarahalli
On 12 June 2017 at 06:11, Petri Savolainen wrote: > Clean up function and parameter naming after modular interface > patch. Queue_t type is referred as "queue internal": queue_int or > q_int. Term "handle" is reserved for API level handles (e.g. > odp_queue_t,

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-14 Thread Dmitry Eremin-Solenikov
On 12.06.2017 14:11, Petri Savolainen wrote: > Clean up function and parameter naming after modular interface > patch. Queue_t type is referred as "queue internal": queue_int or > q_int. Term "handle" is reserved for API level handles (e.g. > odp_queue_t, odp_pktio_t, etc) through out linux-gen

[lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-12 Thread Petri Savolainen
Clean up function and parameter naming after modular interface patch. Queue_t type is referred as "queue internal": queue_int or q_int. Term "handle" is reserved for API level handles (e.g. odp_queue_t, odp_pktio_t, etc) through out linux-gen implementation. Signed-off-by: Petri Savolainen