Re: [lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

2017-02-23 Thread Bill Fischofer
I'd like to revise my some of my earlier review comments now that I understand what's going on here with respect to the use of constructors. I don't like trying to "fake out" various ODP calls as as part of constructor processing as I think that's both risky and not very extensible (or portable

Re: [lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

2017-02-23 Thread Yi He
On 23 February 2017 at 04:57, Bill Fischofer wrote: > > > On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> The functions to register and probe enumerator classes are added. >> >> Signed-off-by: Christophe Milard

Re: [lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

2017-02-22 Thread Bill Fischofer
On Wed, Feb 22, 2017 at 6:55 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > The functions to register and probe enumerator classes are added. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/Makefile.am | 1 + >

[lng-odp] [API-NEXT PATCH 02/21] linux-gen: drv: enumerator_class registration

2017-02-22 Thread Christophe Milard
The functions to register and probe enumerator classes are added. Signed-off-by: Christophe Milard --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/_modules.c | 4 + platform/linux-generic/drv_driver.c