Re: [lng-odp] [API-NEXT PATCH 04/14] api: shm: add flag to guarantee address unicity on all ODP threads

2016-10-10 Thread Christophe Milard
Patch 4 and 6 are really part of the implementation of 2 different functions (locking memory and guaranteeing single virtual address). Yes, they both add a flag, but isn't strange to do 2 different unrelated things in one patch? If you insist, I can merge, but it feels wrong to me... When it comes

Re: [lng-odp] [API-NEXT PATCH 04/14] api: shm: add flag to guarantee address unicity on all ODP threads

2016-10-07 Thread Maxim Uvarov
On 10/07/16 13:35, Christophe Milard wrote: The ODP_SHM_SINGLE_VA flag is created: when set (at odp_shm_reserve()), this flag guarantees that all ODP threads sharing this memory block will see the block at the same address (regadless of ODP thread type -pthread vs process- or fork time) Signed-o

[lng-odp] [API-NEXT PATCH 04/14] api: shm: add flag to guarantee address unicity on all ODP threads

2016-10-07 Thread Christophe Milard
The ODP_SHM_SINGLE_VA flag is created: when set (at odp_shm_reserve()), this flag guarantees that all ODP threads sharing this memory block will see the block at the same address (regadless of ODP thread type -pthread vs process- or fork time) Signed-off-by: Christophe Milard --- include/odp/api