[lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse

2016-02-09 Thread Petri Savolainen
IPv4 address parse function is commonly needed by test applications. A common parse function harmonizes the definition IPv4 address as a command line parameter. Signed-off-by: Petri Savolainen --- helper/Makefile.am | 1 + helper/include/odp/helper/ip.h | 22 +- helper/ip.c

Re: [lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse

2016-02-09 Thread Bala Manoharan
IMO, it is better to add feature for parsing the subnet mask for ipv4 address in the same function. We can add the string format in CIDR notation as "xxx.xxx.xxx.xxx/yy" where yy is subnet prefix. The mask will be filled as a uint32_t same as in ipv4 address. syntax will be something like odph_ipv

Re: [lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse

2016-02-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
: EXT Bala Manoharan [mailto:bala.manoha...@linaro.org] Sent: Wednesday, February 10, 2016 6:40 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse IMO, it is better to add feature for parsing the

Re: [lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse

2016-02-10 Thread Bala Manoharan
*subnet_mask, const > char *str); > > > > > > -Petri > > > > > > > > *From:* EXT Bala Manoharan [mailto:bala.manoha...@linaro.org] > *Sent:* Wednesday, February 10, 2016 6:40 AM > *To:* Savolainen, Petri (Nokia - FI/Espoo) > *Cc:* LNG ODP Mailma

Re: [lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse

2016-02-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
: [lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse On 10 February 2016 at 15:36, Savolainen, Petri (Nokia - FI/Espoo) mailto:petri.savolai...@nokia.com>> wrote: Yes, subnet support is needed and I left it for future development. This ipv4_addr function is for single IP ad

Re: [lng-odp] [API-NEXT PATCH 2/4] helper: ip: added ipv4 address parse

2016-02-10 Thread Tilli, Juha-Matti (Nokia - FI/Espoo)
uch a minor issue), so you can consider all patches in the series: Reviewed-By: Juha-Matti Tilli -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Petri Savolainen Sent: Tuesday, February 09, 2016 2:25 PM To: lng-odp@lists.linaro.org Subject: [lng-od