Reviewed-by: Petri Savolainen petri.savolai...@nokia.com
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
ext Zoltan Kiss
Sent: Monday, August 24, 2015 7:49 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [API-NEXT PATCH v6] api: packet
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
ext Bala Manoharan
Sent: Tuesday, August 25, 2015 1:14 PM
To: Zoltan Kiss
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH v6] api: packet: allow access to
packet flow hash
Hi Zoltan,
Few comments inline...
On 24 August 2015 at 22:18, Zoltan Kiss zoltan.k...@linaro.org wrote:
Applications can read the computed hash (if any) and set it if they want
to store any extra information in it.
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org
---
v2:
- focus on RSS
Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH v6] api: packet: allow access to
packet flow hash values
Hi Zoltan,
Few comments inline...
On 24 August 2015 at 22:18, Zoltan Kiss zoltan.k...@linaro.org wrote:
Applications can read the computed hash (if any) and set it if they
want
Hi,
On 25/08/15 12:24, Bala Manoharan wrote:
The concern with adding additional has_hash_flag was that there will
an if check in the system for every read hash value and since this
comes in the fast path it might get costly if application reads it in
several places. Anyhow that can be optimized
I don't see what problems would arise by saying that if the has is not
present we return zeros for the hash value. Hashes serve a statistical
function. The 1-in-4-billion chance that an actual hash value would be
misinterpreted as unset simply means that the application will take some
default
1:14 PM
To: Zoltan Kiss
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH v6] api: packet: allow access to
packet flow hash values
Hi Zoltan,
Few comments inline...
On 24 August 2015 at 22:18, Zoltan Kiss zoltan.k...@linaro.org wrote:
Applications can read the computed hash
On 25/08/15 11:14, Bala Manoharan wrote:
Hi Zoltan,
Few comments inline...
On 24 August 2015 at 22:18, Zoltan Kiss zoltan.k...@linaro.org wrote:
Applications can read the computed hash (if any) and set it if they want
to store any extra information in it.
Signed-off-by: Zoltan Kiss
Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Tuesday, August 25, 2015 3:02 PM
To: Zoltan Kiss
Cc: Bala Manoharan; Savolainen, Petri (Nokia - FI/Espoo); LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH v6] api: packet: allow access to packet
flow hash values
I don't see what
, August 25, 2015 3:02 PM
*To:* Zoltan Kiss
*Cc:* Bala Manoharan; Savolainen, Petri (Nokia - FI/Espoo); LNG ODP
Mailman List
*Subject:* Re: [lng-odp] [API-NEXT PATCH v6] api: packet: allow access
to packet flow hash values
I don't see what problems would arise by saying that if the has is not
present
Applications can read the computed hash (if any) and set it if they want
to store any extra information in it.
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org
---
v2:
- focus on RSS hash only
- use setter/getter's
v3:
- do not mention pointers
- add a note
- add new patches for implementation
11 matches
Mail list logo
