[lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-07 Thread Bill Fischofer
Change the internal hash_name_and_kind() function to eliminate the use of architecture-specific hash instructions. This eliminates build issues surrounding ARM variants. Future optimizations will use the arch directory consistent with other ODP modules. Signed-off-by: Bill Fischofer --- platform

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-07 Thread Maxim Uvarov
shift still is not fixed: odp_name_table.c:186:4: error: right shift count >= width of type [-Werror] if ((hash_tbl_entry >> 48) == 0x7FFF) ^ odp_name_table.c:188:4: error: right shift count >= width of type [-Werror] else if ((hash_tbl_entry >> 48) == 0) On 12/07/2015 14:09, Bill F

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-07 Thread Bill Fischofer
v1 should not have that problem. What error do you get when trying that? check-odp with M32_ON_64 works fine for me. On Mon, Dec 7, 2015 at 9:01 AM, Maxim Uvarov wrote: > shift still is not fixed: > > odp_name_table.c:186:4: error: right shift count >= width of type [-Werror] > if ((hash_t

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-07 Thread Maxim Uvarov
On 12/07/2015 20:14, Bill Fischofer wrote: v1 should not have that problem. What error do you get when trying that? check-odp with M32_ON_64 works fine for me. export GIT_ODP=/opt/Linaro/odp2.git export CLEANUP=1 export GIT_BRANCH=`(cd $GIT_ODP; git symbolic-ref HEAD | cut -d / -f 3)` ./build

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-07 Thread Bill Fischofer
./build-all.sh for me insists that crc32w isn't supported on ARM, despite the fact that the patch removes those references. So it looks like the check-odp stuff is still flagging errors with the broken api-next rather than testing the patch that fixes these. It's confusing trying to see what chec

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
ng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Maxim Uvarov > Sent: Monday, December 07, 2015 5:01 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use > odp_hash_crc32c() api to avoid arch issues > > shift still is not fixed:

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Maxim Uvarov
: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim Uvarov Sent: Monday, December 07, 2015 5:01 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues shift still is not fixed: odp_name_ta

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Tuesday, December 08, 2015 10:44 AM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use > odp_ha

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Maxim Uvarov
PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues On 12/08/2015 10:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: Bill, hash_tbl_entry is now uintptr_t, which is 64 bits on a 64 bit build and 32 bits on a 32 bit build. These shifts and all other lines that expect that

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Bill Fischofer
lto:maxim.uva...@linaro.org] >>> Sent: Tuesday, December 08, 2015 10:44 AM >>> To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org >>> Subject: Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use >>> odp_hash_crc32c() api to avoid arch issues &

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Maxim Uvarov
08, 2015 10:44 AM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> Subject: Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues