Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Hi Ivan, On 19 August 2015 at 15:02, Ivan Khoronzhuk wrote: > Hi Bala, > > just several comments I forgot to mention. > > On 19.08.15 08:45, Bala Manoharan wrote: > >> Ivan, >> >> On 18 August 2015 at 22:39, Ivan Khoronzhuk > > wrote: >> >> post test review

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Hi Bala, just several comments I forgot to mention. On 19.08.15 08:45, Bala Manoharan wrote: Ivan, On 18 August 2015 at 22:39, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: post test review. I've tested. It works for me. (except UDP/TCP src, as it's not supported). W

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Ivan, On 18 August 2015 at 22:39, Ivan Khoronzhuk wrote: > post test review. > > I've tested. It works for me. (except UDP/TCP src, as it's not supported). > Why you didn't add here others PMR? Are you planing it after? > Also there is no some "inter-PMR" tests, like: > 1 - create PMR_dudp-CoS1

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

post test review. I've tested. It works for me. (except UDP/TCP src, as it's not supported). Why you didn't add here others PMR? Are you planing it after? Also there is no some "inter-PMR" tests, like: 1 - create PMR_dudp-CoS1 (port X) 2 - create PMR_dtcp-CoS2 (same port X) 3 - send UDP packet wi

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Ivan, On 18 August 2015 at 21:43, Ivan Khoronzhuk wrote: > Bala, > > On 18.08.15 18:54, Bala Manoharan wrote: > >> Ivan, >> >> On 18 August 2015 at 21:15, Ivan Khoronzhuk > > wrote: >> >> Bala, >> >> On 18.08.15 18:16, Bala Manoharan wrote: >> >>

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Bala, On 18.08.15 18:54, Bala Manoharan wrote: Ivan, On 18 August 2015 at 21:15, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: Bala, On 18.08.15 18:16, Bala Manoharan wrote: Hi Ivan, On 18 August 2015 at 19:22, Ivan Khoronzhuk mailto:ivan.khoronz...@lina

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Ivan, On 18 August 2015 at 21:15, Ivan Khoronzhuk wrote: > Bala, > > On 18.08.15 18:16, Bala Manoharan wrote: > >> Hi Ivan, >> >> On 18 August 2015 at 19:22, Ivan Khoronzhuk > > wrote: >> >> Hi, Bala >> >> Note: Your patch is based on API-NEXT and it ob

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Bala, On 18.08.15 18:16, Bala Manoharan wrote: Hi Ivan, On 18 August 2015 at 19:22, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: Hi, Bala Note: Your patch is based on API-NEXT and it obliged me to do some modifications with odp_pktio_param_t before testing. Also I'm

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Hi Ivan, On 18 August 2015 at 19:22, Ivan Khoronzhuk wrote: > Hi, Bala > > Note: Your patch is based on API-NEXT and it obliged me to do some > modifications > with odp_pktio_param_t before testing. Also I'm still not sure about using > odp_pmr_terms_cap(), but maybe it's OK to simply fail. > >

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

+/** TCP header length (Minimum Header length without options)*/ +/** If options field is added to TCP header then the correct header value +should be updated by the application */ +#define ODPH_TCPHDR_LEN 20 What about to name it ODPH_MIN_TCPHDR_LEN. But it's style already. So, better leave

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Hi, Bala Note: Your patch is based on API-NEXT and it obliged me to do some modifications with odp_pktio_param_t before testing. Also I'm still not sure about using odp_pmr_terms_cap(), but maybe it's OK to simply fail. Short pretesting review farther below On 12.08.15 11:53, Balasubramanian Ma

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

One moment. I need to checkout, I deep enough in some other stuff. On 18.08.15 14:53, Maxim Uvarov wrote: Ivan, did you test that patches? Do you want to add your review-by? Maxim. On 08/17/15 19:08, Bala Manoharan wrote: Ping. On 14 August 2015 at 22:00, Ivan Khoronzhuk mailto:ivan.khoronz.

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Ivan, did you test that patches? Do you want to add your review-by? Maxim. On 08/17/15 19:08, Bala Manoharan wrote: Ping. On 14 August 2015 at 22:00, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: On 14.08.15 19:29, Bala Manoharan wrote: Hi Ivan, I am plan

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Ping. On 14 August 2015 at 22:00, Ivan Khoronzhuk wrote: > > On 14.08.15 19:29, Bala Manoharan wrote: > >> Hi Ivan, >> >> I am planning to add MAC support in a separate patch. >> I believe MAC should be easier to get-in since it has been agreed. >> > > Ok. > _

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

On 14.08.15 19:29, Bala Manoharan wrote: Hi Ivan, I am planning to add MAC support in a separate patch. I believe MAC should be easier to get-in since it has been agreed. Ok. ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Hi Ivan, I am planning to add MAC support in a separate patch. I believe MAC should be easier to get-in since it has been agreed. Regards, Bala On 14 August 2015 at 21:57, Ivan Khoronzhuk wrote: > Hi, Bala > > Just checked if you added real MAC and seems you forgot to. > Or maybe you are plani

Re: [lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Hi, Bala Just checked if you added real MAC and seems you forgot to. Or maybe you are planing to do it in separate patch. On 12.08.15 11:53, Balasubramanian Manoharan wrote: Additional test suite is added to classification validation suite to test individual PMRs. This suite will test the defin

[lng-odp] [API-NEXT PATCHv2] validation: classification: added additional suite to test individual PMRs

Additional test suite is added to classification validation suite to test individual PMRs. This suite will test the defined PMRs by configuring pktio separately for every test case. Fixes: https://bugs.linaro.org/show_bug.cgi?id=1542 https://bugs.linaro.org/show_bug.cgi?id=1544 https://bugs.linaro