Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-16 Thread Bill Fischofer
oo) > labs.com> >> Cc: lng-odp@lists.linaro.org >> Subject: Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: >> implement reference apis >> >> I've been playing around with odp_bench_packet and there are two >> problems with using this test: >> >&g

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Sunday, January 15, 2017 5:09 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-15 Thread Maxim Uvarov
Might be off-topic but do we need to check somewhere in odp tests that cpu frequency scaling is turend off? My latop likes to play with frequencies and even warn up does not work because it goes to maximum speed, then overheated and cpu frequency lowered. If we count time in cpu cycles - measuremen

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-15 Thread Bill Fischofer
I've been playing around with odp_bench_packet and there are two problems with using this test: 1. The test performs multiple runs of each test TEST_SIZE_RUN_COUNT times, which is good, however it only reports the average cycle time for these runs, There is considerable variability when running in

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-14 Thread Bill Fischofer
Please ignore v2. It had a memory leak that Matias' excellent odp_bench_packet test found. A corrected v3 is posted at http://patches.opendataplane.org/patch/7879/ On Sat, Jan 14, 2017 at 10:04 AM, Bill Fischofer wrote: > Hi Petri, > > I've posted v2 of the tuning patch at > http://patches.openda

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-14 Thread Bill Fischofer
Hi Petri, I've posted v2 of the tuning patch at http://patches.opendataplane.org/patch/7878/ which adds optimization to the odp_packet_free_multi() routine as well as odp_packet_free(). So both of these should now be a very similar for freeing reference and non-reference packets. I'd still like a

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Bill Fischofer
I've posted patch http://patches.opendataplane.org/patch/7857/ as an initial step towards resolving this issue. Petri: can you make your test program available to me so I can try to reproduce your results locally. I don't have quite the scale or controlled environment that you do but this should sa

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Bill Fischofer
On Thu, Jan 12, 2017 at 6:58 AM, Bill Fischofer wrote: > On Thu, Jan 12, 2017 at 6:52 AM, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >>> >> > Huge performance degradation. Numbers are now many times worse than >>> >> before or after my optimizations. To me this shows that almost a >>> compl

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Bill Fischofer
On Thu, Jan 12, 2017 at 6:52 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> >> > Huge performance degradation. Numbers are now many times worse than >> >> before or after my optimizations. To me this shows that almost a >> complete >> >> rewrite (or revert) is needed. >> >> >> >> My guess is

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
> >> > Huge performance degradation. Numbers are now many times worse than > >> before or after my optimizations. To me this shows that almost a > complete > >> rewrite (or revert) is needed. > >> > >> My guess is this is due to the atomics needed for reference counting > >> not being properly inl

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Bill Fischofer
oo) > labs.com> >> Cc: lng-odp@lists.linaro.org >> Subject: Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: >> implement reference apis >> >> On Thu, Jan 12, 2017 at 6:12 AM, Savolainen, Petri (Nokia - FI/Espoo) >> wrote: >> > This patch is now merg

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, January 12, 2017 2:22 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv6 2/5]

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Bill Fischofer
ailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Thursday, January 05, 2017 4:56 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement >> reference api

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
inaro.org > Subject: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement > reference apis > > Implement the APIs: > - odp_packet_ref_static() > - odp_packet_ref() > - odp_packet_ref_pkt() > - odp_packet_is_ref() > - odp_packet_unshared_len() > > Thi

[lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

2017-01-05 Thread Bill Fischofer
Implement the APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_unshared_len() This also involves functional upgrades to the existing packet manipulation APIs to work with packet references as input arguments. Signed-off-by: Bill Fischofe