-by: Petri Savolainen
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
Maxim Uvarov
Sent: Friday, December 11, 2015 2:45 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [PATCH] api: pktio link status
Signed-off-by: Maxim Uvarov
---
v1 was
, December 14, 2015 10:43 AM
> To: Alexandru Badicioiu
> Cc: LNG ODP Mailman List
> Subject: Re: [lng-odp] [PATCH] api: pktio link status
>
>
>
> _link_up() might be confused with setting command. Not with getting
> status command.
>
> How about:
> odp_pktio_st
_link_up() looks consistent with ODP naming convention - setting the link
up would be named _link_up_set().
Alex
On 14 December 2015 at 10:42, Maxim Uvarov wrote:
>
>
> _link_up() might be confused with setting command. Not with getting status
> command.
>
> How about:
> odp_pktio_status_link_u
_link_up() might be confused with setting command. Not with getting
status command.
How about:
odp_pktio_status_link_up()?
There might be some other statuses for pktio which we can extend later
and use the same prefix odp_pktio_status_
Maxim.
On 12/11/2015 15:53, Alexandru Badicioiu wro
Wouldn't be the application code more clear if the function is renamed to
_link_up()?
Return values clearly suggest this. The application has to remember that 1
means link up and 0 means link down.
Alex
On 11 December 2015 at 14:44, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> v
s.linaro.org] On Behalf Of EXT
> Maxim Uvarov
> Sent: Friday, December 11, 2015 2:45 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH] api: pktio link status
>
> Signed-off-by: Maxim Uvarov
> ---
> v1 was link_state(), now it's link_status().
>
> inc
Signed-off-by: Maxim Uvarov
---
v1 was link_state(), now it's link_status().
include/odp/api/packet_io.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index 443841e..8999b2c 100644
--- a/include/odp/api/packet_io.h
+++
