Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

Merged, thanks. On 06/08/15 19:01, Mike Holmes wrote: On 5 June 2015 at 08:22, Nicolas Morey-Chaisemartin > wrote: Signed-off-by: Nicolas Morey-Chaisemartin mailto:nmo...@kalray.eu>> Reviewed-by: Mike Holmes http://inaro.org>> :) I think we should not impo

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

On 5 June 2015 at 08:22, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > Reviewed-by: Mike Holmes I think we should not impose something that is affecting others, derived platforms can of course add this back in if they need to for their documentation or make s

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

The linux-generic platform is indeed used as a "base class" however given this it would seem that the include order should be reversed so that $(WITH_PLATFORM) is first. This would have the effect of allowing it to override any linux-generic include files of the same name. I dont think it will

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

What we did to avoid pointing into the linux-generic folder in the Makefiles is use symlinks to linux-generic sources. This way we keep the linux-generic files up-to-date when pulling but avoid build dependencies between platform folders. On 06/06/2015 12:22 AM, Bill Fischofer wrote: > The linux

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

On 5 June 2015 at 18:22, Bill Fischofer wrote: > The linux-generic platform is indeed used as a "base class" however given > this it would seem that the include order should be reversed so that > $(WITH_PLATFORM) is first. This would have the effect of allowing it to > override any linux-generic

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

The linux-generic platform is indeed used as a "base class" however given this it would seem that the include order should be reversed so that $(WITH_PLATFORM) is first. This would have the effect of allowing it to override any linux-generic include files of the same name. On Fri, Jun 5, 2015 at

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

This works for linux-generic, but derived platforms such as odp-dpdk depend on this link back to linux-generic becasue they inherit from it. Having this in linux-generic makes it simpler for the derived works, but I could also see the argument that it should be removed in linux-generic and added ba

[lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

Signed-off-by: Nicolas Morey-Chaisemartin --- doc/doxygen.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg index 6283387..213a903 100644 --- a/doc/doxygen.cfg +++ b/doc/doxygen.cfg @@ -13,7 +13,6 @@ WARN_NO_PARAMDOC = YES INPUT = $(SRCDIR)/doc \ $(