Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-24 Thread Maxim Uvarov
looks like everybody agree. Merged. Maxim. On 05/23/16 19:37, Christophe Milard wrote: And on the top of this , I intend to write a patch to simplify this interface, so hopefully this will become obsolete soon :-) On 23 May 2016 at 18:31, Christophe Milard

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
And on the top of this , I intend to write a patch to simplify this interface, so hopefully this will become obsolete soon :-) On 23 May 2016 at 18:31, Christophe Milard wrote: > OK. if everyone now agrees, maybe this can be marked as reviewed :-). 3 > extra

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
OK. if everyone now agrees, maybe this can be marked as reviewed :-). 3 extra comments should not generate a storm, should it? It fixes a doxygen warning on the helper... Christophe. On 23 May 2016 at 18:00, Mike Holmes wrote: > I was looking for some definitions that

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Mike Holmes
I was looking for some definitions that would save us having to perpetuate this topic into its 5/6th week. I hoped to find a model. I agree, we dont want to work on helper support for anything new unless it brought a robust proven model. On 23 May 2016 at 11:58, Christophe Milard

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
I don't think we should implement this by our own. If we do somthing about it, it would just be awrapper for some functions, I guess... On 23 May 2016 at 17:47, Mike Holmes wrote: > Did a quick google on possibilities for how to implement an odp_thread, > 99% of which we

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Mike Holmes
Did a quick google on possibilities for how to implement an odp_thread, 99% of which we dont support , but might make an interesting project. https://software.intel.com/en-us/articles/choosing-the-right-threading-framework On 23 May 2016 at 11:34, Christophe Milard

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Ola Liljedahl
On 23 May 2016 at 17:34, Christophe Milard wrote: > > > On 23 May 2016 at 17:31, Ola Liljedahl wrote: > >> >> >> On 23 May 2016 at 17:28, Christophe Milard >> wrote: >> >>> This is for linux helpers: in odp

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
On 23 May 2016 at 17:31, Ola Liljedahl wrote: > > > On 23 May 2016 at 17:28, Christophe Milard > wrote: > >> This is for linux helpers: in odp linux, just pthreads and processes are >> supported as odpthreads.(well actually processes are

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Ola Liljedahl
On 23 May 2016 at 17:28, Christophe Milard wrote: > This is for linux helpers: in odp linux, just pthreads and processes are > supported as odpthreads.(well actually processes are not supported yet, but > we head to it). > You can use C and C++ threads in Linux as

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
This is for linux helpers: in odp linux, just pthreads and processes are supported as odpthreads.(well actually processes are not supported yet, but we head to it). If we support something else in some future, we'll update the comment then. Christophe On 23 May 2016 at 17:23, Ola Liljedahl

Re: [lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Ola Liljedahl
On 23 May 2016 at 17:04, Christophe Milard wrote: > Signed-off-by: Christophe Milard > --- > helper/include/odp/helper/linux.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

[lng-odp] [PATCH] helper: fixing doxygen comments for odpthread creation parameters

2016-05-23 Thread Christophe Milard
Signed-off-by: Christophe Milard --- helper/include/odp/helper/linux.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/helper/include/odp/helper/linux.h b/helper/include/odp/helper/linux.h index 01c348d..2e89833 100644 ---