Re: [lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

2016-11-29 Thread Bill Fischofer
On Tue, Nov 29, 2016 at 11:25 AM, Maxim Uvarov wrote: > Coverity also does not like such division: > > *** CID 1382604: Incorrect expression (UNINTENDED_INTEGER_DIVISION) > /platform/linux-generic/arch/x86/odp_sysinfo_parse.c: 75 in > odp_cpu_hz_current() > 69 } > 70 } > 71 > 72

Re: [lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

2016-11-29 Thread Maxim Uvarov
Coverity also does not like such division: *** CID 1382604: Incorrect expression (UNINTENDED_INTEGER_DIVISION) /platform/linux-generic/arch/x86/odp_sysinfo_parse.c: 75 in odp_cpu_hz_current() 69 } 70 } 71 72 fclose(file); 73 if (mhz) { 74 /* check for o

Re: [lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

2016-10-27 Thread Bill Fischofer
On Thu, Oct 27, 2016 at 9:42 AM, Maxim Uvarov wrote: > In near future cpu mhz more likely will not overflow 64 > bit value, but it makes sense to add assert for > overflow check. > https://bugs.linaro.org/show_bug.cgi?id=2425 > > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/arch/

[lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

2016-10-27 Thread Maxim Uvarov
In near future cpu mhz more likely will not overflow 64 bit value, but it makes sense to add assert for overflow check. https://bugs.linaro.org/show_bug.cgi?id=2425 Signed-off-by: Maxim Uvarov --- platform/linux-generic/arch/x86/odp_sysinfo_parse.c | 7 ++- 1 file changed, 6 insertions(+),