Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-02 Thread Maxim Uvarov
I merged this patch because it does not introduce problem and the same static inlines in all others arches. Separate patch will be needed if we decide to un inline all of them. Maxim. On 02/01/17 21:41, Brian Brooks wrote: > On 02/01 08:38:08, Mike Holmes wrote: >> If this is in the API, then to

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Brian Brooks
On 02/01 08:38:08, Mike Holmes wrote: > If this is in the API, then to be ABI compatible it must compile into the > lib and not be a static inline I would think, unless we are sure that for a > given cpu arch it will never differ which may be true. > > > On 1 February 2017 at 06:12, Bill Fischofe

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Mike Holmes
If this is in the API, then to be ABI compatible it must compile into the lib and not be a static inline I would think, unless we are sure that for a given cpu arch it will never differ which may be true. On 1 February 2017 at 06:12, Bill Fischofer wrote: > On Wed, Feb 1, 2017 at 2:17 AM, Maxim

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 2:17 AM, Maxim Uvarov wrote: > it's abi function, has to be declared with _STATIC. For others arches also. Actually, in this case since the purpose of the call is to waste time, inlining it would be counterproductive, which is why these routines don't follow those ABI rule

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Maxim Uvarov
it's abi function, has to be declared with _STATIC. For others arches also. Maxim. On 1 February 2017 at 01:34, Bill Fischofer wrote: > On Thu, Jan 26, 2017 at 9:31 PM, Brian Brooks > wrote: > > Signed-off-by: Brian Brooks > > Reviewed-by: Bill Fischofer > > > --- > > platform/linux-generi

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-01-31 Thread Bill Fischofer
On Thu, Jan 26, 2017 at 9:31 PM, Brian Brooks wrote: > Signed-off-by: Brian Brooks Reviewed-by: Bill Fischofer > --- > platform/linux-generic/arch/arm/odp/api/cpu_arch.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/platform/linux-generic/arch/arm/odp/api/cpu_arch.h > b/plat

[lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-01-26 Thread Brian Brooks
Signed-off-by: Brian Brooks --- platform/linux-generic/arch/arm/odp/api/cpu_arch.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/platform/linux-generic/arch/arm/odp/api/cpu_arch.h b/platform/linux-generic/arch/arm/odp/api/cpu_arch.h index 22b1da2d..7c75a690 100644 --- a/platform/linu