Remove duplicated code and use preexisting metadata copy function
Signed-off-by: Nicolas Morey-Chaisemartin
---
platform/linux-generic/odp_packet.c | 34 ++
1 file changed, 2 insertions(+), 32 deletions(-)
diff --git a/platform/linux-generic/odp_packet.c
b/plat
On 09/14/2015 11:14 AM, Nicolas Morey-Chaisemartin wrote:
> Remove duplicated code and use preexisting metadata copy function
>
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> platform/linux-generic/odp_packet.c | 34 ++
> 1 file changed, 2 insertions(+), 32
odp_packet_copy() can copy between pools, which may have different sized
user areas, hence the size checks.
The user ptr is vestigial and probably should be deprecated at some point.
On Mon, Sep 14, 2015 at 4:34 AM, Nicolas Morey-Chaisemartin <
nmo...@kalray.eu> wrote:
>
>
> On 09/14/2015 11:14
On 10/01/2015 05:05 PM, Bill Fischofer wrote:
> odp_packet_copy() can copy between pools, which may have different sized
> user areas, hence the size checks.
Ok. But then does it make sense to copy a subpart of the user data ?
If dst user_area >= src user_area it's going to work well but in the o
The checks are there to avoid buffer overruns. Whether or not the copies
make sense is an application responsibility.
On Monday, October 5, 2015, Nicolas Morey-Chaisemartin
wrote:
>
>
> On 10/01/2015 05:05 PM, Bill Fischofer wrote:
> > odp_packet_copy() can copy between pools, which may have dif
Ping
On 09/14/2015 11:14 AM, Nicolas Morey-Chaisemartin wrote:
> Remove duplicated code and use preexisting metadata copy function
>
> Signed-off-by: Nicolas Morey-Chaisemartin
> ---
> platform/linux-generic/odp_packet.c | 34 ++
> 1 file changed, 2 insertions(+)
On Mon, Sep 14, 2015 at 4:14 AM, Nicolas Morey-Chaisemartin <
nmo...@kalray.eu> wrote:
> Remove duplicated code and use preexisting metadata copy function
>
> Signed-off-by: Nicolas Morey-Chaisemartin
>
Reviewed-by: Bill Fischofer
> ---
> platform/linux-generic/odp_packet.c | 34
> ++---
Merged,
Maxim.
On 10/16/2015 17:39, Bill Fischofer wrote:
On Mon, Sep 14, 2015 at 4:14 AM, Nicolas Morey-Chaisemartin
mailto:nmo...@kalray.eu>> wrote:
Remove duplicated code and use preexisting metadata copy function
Signed-off-by: Nicolas Morey-Chaisemartin mailto:nmo...@kalray.e