Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

On 10/16/2015 15:03, Nicolas Morey-Chaisemartin wrote: Maybe close should call stop implictely to avoid redundancy ? Term => Close Close => Stop Looks like I mixed up something. There is only one patch from Petri: [API-NEXT PATCH] api: pktio: improve pktio_start and stop documentation which

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

Petri sent a patch for api which says that pktio has to be stopped. I think you also need to send stop before close in that patch. Maxim. On 10/14/2015 10:53, Nicolas Morey-Chaisemartin wrote: There at still 3 loops with the same = 1, <=PKTIO_ENTRIES in the packet_io.c file. Can we keep this

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

Merged, Maxim. On 10/16/2015 15:03, Nicolas Morey-Chaisemartin wrote: Maybe close should call stop implictely to avoid redundancy ? Term => Close Close => Stop On 10/16/2015 01:59 PM, Maxim Uvarov wrote: Petri sent a patch for api which says that pktio has to be stopped. I think you also

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

Maybe close should call stop implictely to avoid redundancy ? Term => Close Close => Stop On 10/16/2015 01:59 PM, Maxim Uvarov wrote: > Petri sent a patch for api which says that pktio has to be stopped. > > I think you also need to send stop before close in that patch. > > Maxim. > > On

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

On 10/13/2015 20:05, Nicolas Morey-Chaisemartin wrote: Right now, pktio_term calls term on all pktio type but some pktio might still be be opened. Although the user should probably close its pktio before termintating the application, it is safer to iterate on all pktio and close them in the

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

On 14 October 2015 at 10:53, Nicolas Morey-Chaisemartin wrote: > There at still 3 loops with the same = 1, <=PKTIO_ENTRIES in the > packet_io.c file. > Can we keep this patch this way and then send a new patch that fixes all > these loops at once? > > Nicolas > > Yes, I think

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

There at still 3 loops with the same = 1, <=PKTIO_ENTRIES in the packet_io.c file. Can we keep this patch this way and then send a new patch that fixes all these loops at once? Nicolas On 10/14/2015 09:52 AM, Maxim Uvarov wrote: > On 10/14/2015 10:21, Nicolas Morey-Chaisemartin wrote: >> >> On

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

On 10/14/2015 10:21, Nicolas Morey-Chaisemartin wrote: On 10/14/2015 08:48 AM, Maxim Uvarov wrote: On 10/13/2015 20:05, Nicolas Morey-Chaisemartin wrote: Right now, pktio_term calls term on all pktio type but some pktio might still be be opened. Although the user should probably close its

Re: [lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

On 10/14/2015 08:48 AM, Maxim Uvarov wrote: > On 10/13/2015 20:05, Nicolas Morey-Chaisemartin wrote: >> Right now, pktio_term calls term on all pktio type but >> some pktio might still be be opened. Although the user should >> probably close its pktio before termintating the application, >> it

[lng-odp] [PATCH] linux-generic: pktio: close all pktio when term is called

Right now, pktio_term calls term on all pktio type but some pktio might still be be opened. Although the user should probably close its pktio before termintating the application, it is safer to iterate on all pktio and close them in the pktio_term function. Signed-off-by: Nicolas