Re: [lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

2016-05-11 Thread Bill Fischofer
On Wed, May 11, 2016 at 10:21 AM, Maxim Uvarov wrote: > On 05/11/16 00:50, Bill Fischofer wrote: > > >> >> On Tue, May 10, 2016 at 11:19 AM, Maxim Uvarov > > wrote: >> >> Ola, can you please review this patch? >> >> Bill, Bala, >> >> I am not sure that

Re: [lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

2016-05-11 Thread Maxim Uvarov
On 05/11/16 00:50, Bill Fischofer wrote: On Tue, May 10, 2016 at 11:19 AM, Maxim Uvarov mailto:maxim.uva...@linaro.org>> wrote: Ola, can you please review this patch? Bill, Bala, I am not sure that this change is correct. There is 2 things: 1. Align on 16 bytes: The

Re: [lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

2016-05-10 Thread Bill Fischofer
On Tue, May 10, 2016 at 11:19 AM, Maxim Uvarov wrote: > Ola, can you please review this patch? > > Bill, Bala, > > I am not sure that this change is correct. > > There is 2 things: > 1. Align on 16 bytes: > The entire struct will be aligned on a 16 byte boundary if ODP_ATOMIC_U128 is defined.

Re: [lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

2016-05-10 Thread Maxim Uvarov
Ola, can you please review this patch? Bill, Bala, I am not sure that this change is correct. There is 2 things: 1. Align on 16 bytes: typedef struct tick_buf_s { odp_atomic_u64_t exp_tck;/* Expiration tick or TMO_xxx */ odp_buffer_t tmo_buf;/* ODP_BUFFER_INVALID if timer not active *

Re: [lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

2016-05-09 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 10 May 2016 at 07:25, Bill Fischofer wrote: > The tick_buf_t struct may be larger than 16 bytes when a lock char is > needed so correct the ODP_STATIC_ASSERT to reflect this. This addresses > bug https://bugs.linaro.org/show_bug.cgi?id=2211 when compili

[lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

2016-05-09 Thread Bill Fischofer
The tick_buf_t struct may be larger than 16 bytes when a lock char is needed so correct the ODP_STATIC_ASSERT to reflect this. This addresses bug https://bugs.linaro.org/show_bug.cgi?id=2211 when compiling with clang. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_timer.c | 2 +- 1