Re: [lng-odp] [PATCH] queue: queue_deq: delete atomic fetch and inc

2016-01-19 Thread Bill Fischofer
This patch is incomplete. You also have to change the declaration of sync_in (in odp_queue_internal.h) as well as its initialization in odp_queue_init_global() for this to be able to compile and run. The patch should also be versioned. This one should have been marked PATCHv2 since it is a revis

[lng-odp] [PATCH] queue: queue_deq: delete atomic fetch and inc

2016-01-19 Thread Zaibo Xu
As all the queue_deq is locked by queue lock, I think it doesn't need to atomic opertion here any more. Signed-off-by: Zaibo Xu --- platform/linux-generic/odp_queue.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-g

Re: [lng-odp] [PATCH] queue: queue_deq: delete atomic fetch and inc

2016-01-15 Thread Bill Fischofer
This patch is incorrect. The atomics are needed since odp_schedule_order_lock() does not lock the queue. On Thursday, January 14, 2016, Zaibo Xu wrote: > As all the queue_deq is locked by queue lock, I think it doesn't need > to atomic opertion here any more. > > Signed-off-by: Zaibo Xu > > ---

[lng-odp] [PATCH] queue: queue_deq: delete atomic fetch and inc

2016-01-14 Thread Zaibo Xu
As all the queue_deq is locked by queue lock, I think it doesn't need to atomic opertion here any more. Signed-off-by: Zaibo Xu --- platform/linux-generic/odp_queue.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generi