Re: [lng-odp] [PATCH 1/2] test: pktio_perf: fix pthread_t offset for tx threads

2015-07-02 Thread Maxim Uvarov
On 07/01/15 16:40, Nicolas Morey-Chaisemartin wrote: Offset wrongly used num_tx_workers instead of num_rx_workers which caused threads to be badly joined. Without this patch: $./test/performance/odp_pktio_perf -c 3 Segmentation fault (core dumped) Nikolas, I can not reproduce that bug.

Re: [lng-odp] [PATCH 1/2] test: pktio_perf: fix pthread_t offset for tx threads

2015-07-02 Thread Stuart Haslam
On Thu, Jul 02, 2015 at 11:21:33AM +0200, Nicolas Morey-Chaisemartin wrote: It may not segfault depending on what is on your stack at this point and in the pthread_t. Depending on #RX #Tx or the opposit, it eithers join a thread twice, or join an unitiliazed pthread_t. On 07/02/2015

Re: [lng-odp] [PATCH 1/2] test: pktio_perf: fix pthread_t offset for tx threads

2015-07-02 Thread Maxim Uvarov
Merged! Thanks, Maxim. On 07/02/15 12:32, Stuart Haslam wrote: On Thu, Jul 02, 2015 at 11:21:33AM +0200, Nicolas Morey-Chaisemartin wrote: It may not segfault depending on what is on your stack at this point and in the pthread_t. Depending on #RX #Tx or the opposit, it eithers join a thread

Re: [lng-odp] [PATCH 1/2] test: pktio_perf: fix pthread_t offset for tx threads

2015-07-02 Thread Nicolas Morey-Chaisemartin
It may not segfault depending on what is on your stack at this point and in the pthread_t. Depending on #RX #Tx or the opposit, it eithers join a thread twice, or join an unitiliazed pthread_t. On 07/02/2015 11:18 AM, Maxim Uvarov wrote: On 07/01/15 16:40, Nicolas Morey-Chaisemartin wrote:

[lng-odp] [PATCH 1/2] test: pktio_perf: fix pthread_t offset for tx threads

2015-07-01 Thread Nicolas Morey-Chaisemartin
Offset wrongly used num_tx_workers instead of num_rx_workers which caused threads to be badly joined. Without this patch: $./test/performance/odp_pktio_perf -c 3 Segmentation fault (core dumped) Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu ---