[lng-odp] [PATCH 5/5] validation: cls: split pmr chain test

2016-01-12 Thread Ivan Khoronzhuk
These tests are simple classification tests and better to see results for each of them separately. Signed-off-by: Ivan Khoronzhuk --- test/validation/classification/classification.h| 22 --- .../classification/odp_classification_tests.c | 72 -- 2 files changed,

Re: [lng-odp] [PATCH 5/5] validation: cls: split pmr chain test

2016-01-13 Thread Bala Manoharan
The idea behind this suite is to have a mechanism to test the behaviour of the system after applying all the different PMR, default CoS, error CoS and L2 and L3 CoS values. your suggested changes tests each and every configuration individually which defeats the idea of the suite. There is a dedicat

Re: [lng-odp] [PATCH 5/5] validation: cls: split pmr chain test

2016-01-13 Thread Ivan Khoronzhuk
On 14.01.16 07:55, Bala Manoharan wrote: The idea behind this suite is to have a mechanism to test the behaviour of the system after applying all the different PMR, default CoS, error CoS and L2 and L3 CoS values. your suggested changes tests each and every configuration individually which defe

Re: [lng-odp] [PATCH 5/5] validation: cls: split pmr chain test

2016-01-14 Thread Bala Manoharan
Agreed. Error CoS and L2 should be added as separate suites and I would preferable add them in odp_classification_test_pmr.c so that each are tested separately. Maybe rename the file also :) As I pointed out enhancements can be done once API freeze is accepted. Regards, Bala On 14 January 2016 a