Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Ivan Khoronzhuk
It shouldn't depend on catalog the project is built. On 15.10.15 18:10, Ivan Khoronzhuk wrote: This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. This revert helps me to revert messages like: "fatal: No names found, cannot describe anything." in case if I build ODP outside of source

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Ivan Khoronzhuk
I build it at api-next and see this: ... fatal: No names found, cannot describe anything. CC odp_system_info.lo fatal: No names found, cannot describe anything. CC odp_thread.lo fatal: No names found, cannot describe anything. CC odp_thrmask.lo CC odp_ticketlock.lo

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Nicolas Morey-Chaisemartin
Please forget the first two sentences of my previous mail. I started writing an alternate patch and then realized it was fixed in master already. On 10/15/2015 05:20 PM, Nicolas Morey-Chaisemartin wrote: > Maybe changing the directory before running git_hash.sh would fix your issue > and keep

[lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Ivan Khoronzhuk
This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. This revert helps me to revert messages like: "fatal: No names found, cannot describe anything." in case if I build ODP outside of source catalog by: ../../odp/configure --enable-test-perf --enable-test-vald make Seems it's connected

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Nicolas Morey-Chaisemartin
Maybe changing the directory before running git_hash.sh would fix your issue and keep the old make working ? Something like This was fixed some time ago: commit 06537738ea438c3e339fc269dedb4ed6c5e48f07 Author: Anders Roxell Date: Fri Aug 14 15:25:05 2015 +0200

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

2015-10-15 Thread Nicolas Morey-Chaisemartin
The issue come from git_hash it self. Not the Makefile. I'm sending a patch right now. On 10/15/2015 05:28 PM, Ivan Khoronzhuk wrote: > I build it at api-next and see this: > ... > fatal: No names found, cannot describe anything. > CC odp_system_info.lo > fatal: No names found, cannot