Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

Sent: Wednesday, August 03, 2016 15:01 To: Forrest Shi ; bala.manoha...@linaro.org Cc: lng-odp Subject: Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion On 08/03/16 05:05, Forrest Shi wrote: Hi, this is the coverage report of call the function by l3fwd. thanks, Forrest in

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

gt; Cc: lng-odp > Subject: Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string > conversion > > On 08/03/16 05:05, Forrest Shi wrote: > > Hi, > > > > this is the coverage report of call the function by l3fwd. > > > > thanks, > > Forrest >

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

On 08/03/16 05:05, Forrest Shi wrote: Hi, this is the coverage report of call the function by l3fwd. thanks, Forrest in that case it's ok, we just need new functions called at least from somewhere.. Maxim. On 3 August 2016 at 09:57, Forrest Shi > wrote:

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

Hi, this is the coverage report of call the function by l3fwd. thanks, Forrest On 3 August 2016 at 09:57, Forrest Shi wrote: > Hi Maxim & Bala， > > It is a reverse function of the odph_eth_addr_parse(...). > > It could be used by l2fwd-simple, ipsec or other example like l3fwd to > avoid dupli

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

Hi Maxim & Bala， It is a reverse function of the odph_eth_addr_parse(...). It could be used by l2fwd-simple, ipsec or other example like l3fwd to avoid duplicate or similar code. thanks, Forrest On 2 August 2016 at 23:50, Maxim Uvarov wrote: > On 08/02/16 18:21, Bala Manoharan wrote: > >> on

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

On 08/02/16 18:21, Bala Manoharan wrote: one minor question: Is this API mainly for debugging or is there any other use case? Apart from this that is good point. We need code coverage to merge this function. Please add some simple test for helpers tests also. Maxim. Reviewed-by: Balasubrama

Re: [lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

one minor question: Is this API mainly for debugging or is there any other use case? Apart from this Reviewed-by: Balasubramanian Manoharan Regards, Bala On 2 August 2016 at 14:20, wrote: > From: Xuelin Shi > > generate mac string representation (XX:XX:XX:XX:XX:XX) of odph_ethaddr_t > > Sig

[lng-odp] [PATCH v2] helper/eth: add mac address to string conversion

From: Xuelin Shi generate mac string representation (XX:XX:XX:XX:XX:XX) of odph_ethaddr_t Signed-off-by: Xuelin Shi --- v2: fix style issue. helper/eth.c| 11 +++ helper/include/odp/helper/eth.h | 14 ++ 2 files changed, 25 insertions(+) diff --git a/